Checkbox Provider - Canonical Certification Client

Merge ~zongminl/plainbox-provider-certification-client:add-ubuntucore-jobs into plainbox-provider-certification-client:master

  1. Git
  2. lp:~zongminl/plainbox-provider-certification-client
  3. add-ubuntucore-jobs
  4. Merge into master
Proposed by Vic Liu
Status: Merged
Approved by: Vic Liu
Approved revision: 4c875f9b9f026991ee5c15094cc9aa8d36ebd9b1
Merged at revision: af27af9a9e3ddc4bcf075d1aed688c850277f93f
Proposed branch: ~zongminl/plainbox-provider-certification-client:add-ubuntucore-jobs
Merge into: plainbox-provider-certification-client:master
Diff against target: 34 lines (+5/-0)
2 files modified
units/client-cert-iot-server-20-04.pxu (+3/-0)
units/client-cert-iot-ubuntucore-20.pxu (+2/-0)
Reviewer Review Type Date Requested Status
Jonathan Cave Approve
Kristin Chuang (community) Approve
Vic Liu Needs Resubmitting
Patrick Liu Approve
Review via email: mp+396722@code.launchpad.net

Commit message

Add ubuntucore-manual and ubuntucore-automated to test plan client-cert-iot-ubuntucore-20

To post a comment you must log in.
Revision history for this message
Patrick Liu (patliu) wrote :

+1

review: Approve
Revision history for this message
Kristin Chuang (hyac109) wrote :

"client-cert-iot-server-20-04-manual" currently nests "client-cert-iot-ubuntucore-20-manual", which means that the new ubuntucore-manual[1] cases will be run in classic environments as well.

We won't need the following cases in classic images though:
- ubuntucore/os-reinstall-mode
- ubuntucore/os-recovery-mode
Those 2 will need to be excluded from the "client-cert-iot-server-20-04-manual" plan to make this change complete.

[1]https://git.launchpad.net/plainbox-provider-checkbox/tree/units/ubuntucore/test-plan.pxu#n16

review: Needs Fixing
Revision history for this message
Vic Liu (zongminl) wrote :

Thanks for the advice, I also excluded snappy/os-.* jobs.

review: Needs Resubmitting
Revision history for this message
Kristin Chuang (hyac109) wrote :

Thanks Vic! lgtm, +1

review: Approve
Revision history for this message
Jonathan Cave (jocave) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/client-cert-iot-server-20-04.pxu b/units/client-cert-iot-server-20-04.pxu
2index d0fccc3..c074802 100644
3--- a/units/client-cert-iot-server-20-04.pxu
4+++ b/units/client-cert-iot-server-20-04.pxu
5@@ -18,6 +18,9 @@ include:
6 nested_part:
7 # until there is reason to diverge, nest these plans
8 client-cert-iot-ubuntucore-20-manual
9+exclude:
10+ ubuntucore/os-.*
11+ snappy/os-.*
12
13
14 id: client-cert-iot-server-20-04-automated
15diff --git a/units/client-cert-iot-ubuntucore-20.pxu b/units/client-cert-iot-ubuntucore-20.pxu
16index 84b4ed8..aaaee38 100644
17--- a/units/client-cert-iot-ubuntucore-20.pxu
18+++ b/units/client-cert-iot-ubuntucore-20.pxu
19@@ -47,6 +47,7 @@ bootstrap_include:
20 net_if_management
21 nested_part:
22 self-manual
23+ ubuntucore-manual
24 audio-manual
25 bluetooth-manual
26 camera-manual
27@@ -124,6 +125,7 @@ bootstrap_include:
28 net_if_management
29 nested_part:
30 self-automated
31+ ubuntucore-automated
32 com.intel.ipdt::ipdt-plan
33 audio-automated
34 bluez-automated

Subscribers

People subscribed via source and target branches

to all changes: