Checkbox Limerick

Merge ~zongminl/checkbox-limerick/+git/checkbox-limerick-classic:fix-snapcraft7-build-error into ~checkbox-dev/checkbox-limerick/+git/checkbox-limerick-classic:master

  1. Git
  2. lp:~zongminl/checkbox-limerick/+git/checkbox-limerick-classic
  3. fix-snapcraft7-build-error
  4. Merge into master
Proposed by Vic Liu
Status: Merged
Approved by: Vic Liu
Approved revision: 3ff3bb5d07fd7cff965242b161d66689bb02a4b8
Merged at revision: da5d116642899ce9ccbedc4de53c27770d7445ab
Proposed branch: ~zongminl/checkbox-limerick/+git/checkbox-limerick-classic:fix-snapcraft7-build-error
Merge into: ~checkbox-dev/checkbox-limerick/+git/checkbox-limerick-classic:master
Diff against target: 14 lines (+3/-0)
1 file modified
snap/snapcraft.yaml (+3/-0)
Reviewer Review Type Date Requested Status
Patrick Liu (community) Approve
Vincent Liao Approve
Rick Wu Pending
PeiYao Chang Pending
StanleyHuang Pending
Review via email: mp+457218@code.launchpad.net

Commit message

Fix: Add required packages to build-packages field in snapcraft.yaml to fix snapcraft 7.x build error

To post a comment you must log in.
Revision history for this message
Vincent Liao (liaou3) wrote :

+1

review: Approve
Revision history for this message
Patrick Liu (patliu) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
2index 308405e..33528e1 100644
3--- a/snap/snapcraft.yaml
4+++ b/snap/snapcraft.yaml
5@@ -63,6 +63,9 @@ parts:
6 python3 manage.py install --layout=relocatable --prefix=/providers/checkbox-provider-limerick --root="$SNAPCRAFT_PART_INSTALL"
7 build-packages:
8 - python3-jinja2
9+ - python3-xlsxwriter
10+ - python3-packaging
11+ - python3-urwid
12 parts-meta-info:
13 plugin: nil
14 build-attributes: [no-patchelf]

Subscribers

People subscribed via source and target branches

to all changes: