Merge lp:~zmanji/ecryptfs/1270455 into lp:ecryptfs
Proposed by
Zameer Manji
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Tyler Hicks | ||||
Proposed branch: | lp:~zmanji/ecryptfs/1270455 | ||||
Merge into: | lp:ecryptfs | ||||
Diff against target: |
52 lines (+13/-2) 2 files modified
tests/lib/etl_funcs.sh (+1/-1) tests/run_tests.sh (+12/-1) |
||||
To merge this branch: | bzr merge lp:~zmanji/ecryptfs/1270455 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tyler Hicks | Disapprove | ||
Review via email: mp+202197@code.launchpad.net |
Description of the change
This fixes Launchpad Bug 1270455 by allowing the tester to pass arbitrary mount flags to the test runner.
To post a comment you must log in.
Unmerged revisions
- 825. By Zameer Manji
-
Adding -o flags option to pass arbitrary flags to ecryptfs through the test harness.
Hi Zameer - I apologize for it taking so long for us to get to this merge proposal. I'm slowly trying to get on top of outstanding maintenance tasks.
This is a simple and needed change, but I don't want to add an option to run_tests.sh at this point. There are a very small number of people that would ever want to change the test mount options and the command line options of run_test.sh are getting more complex than I would like.
Additionally, I think users of run_tests.sh would expect the -o flag to be used to set the mount options, not append an option. One may also just want to replace or change an existing default mount option. I think we need to give it a little more thought before we use the -o option...
You can currently overwrite the default test mount options by setting the ETL_MOUNT_OPTS environment variable. However, that doesn't solve your problem because you want to simply append an additional mount option onto the list of defaults. So, I propose that we create a new environment variable, ETL_APPENDED_ MOUNT_OPTS, that can be set when running the tests.
I've created a merge proposal here:
https:/ /code.launchpad .net/~tyhicks/ ecryptfs/ lp1270455/ +merge/ 226229