Merge lp:~ziminq/drizzle/fix-bug550090 into lp:~drizzle-trunk/drizzle/development

[ziminq]

This bug is caused due to the member used without being initialized at first.
The calling path can be reached to the execution of 'select' statement by 'select * from show_tables' and 'show tables'. On the later case, the select statement is setShowPredicate() at first, while for the former case, it's not. Hence, it causes the bug.

[Brian Aker (brianaker)]

Hi!

Thanks, you were right on the bug.I applied a different solution to the problem though. Inside of the table function if schema was not found, then the current schema should be used. If that is not found? Then the table function should return zero rows.

Thanks!

Cheers,
  -Brian

review: Disapprove

Unmerged revisions

1442. By ziminq on 2010-04-06

fix bug 550090

=== modified file 'drizzled/statement/select.h'
--- drizzled/statement/select.h	2010-02-19 00:48:09 +0000
+++ drizzled/statement/select.h	2010-04-06 13:26:24 +0000
@@ -22,6 +22,7 @@
 #define DRIZZLED_STATEMENT_SELECT_H
 
 #include <drizzled/statement.h>
+#include <drizzled/session.h>
 
 namespace drizzled
 {
@@ -40,7 +41,10 @@
   Select(Session *in_session)
     :
       Statement(in_session)
-  {}
+  {
+    if (not in_session->db.empty())
+      show_schema= in_session->db;
+  }
 
   void setShowPredicate(const std::string &schema_arg, const std::string &table_arg)
   {