Code review comment for lp:~zikzak/oosalespromotions/sale_promotions
Revision history for this message
| Sharoon Thomas http://openlabs.co.in (sharoonthomas) wrote | # |
review:
Needs Fixing
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Hello Raimon,
Line 1486 - 1523
Using globals is a bad idea for the following reasons:
1. It will not allow new modules to add types of operations. So new modules written will not even be able to disallow or allow certain operations.
2. Makes program slower because of the way python does attribute access. (insignificant but still valid when you consider the application of e-commerce)
Hence, could you please fix that and propose a merge. Thanks...