Code review comment for lp:~zhuzhaoyuan/mysql-proxy/zhuzhaoyuan

Revision history for this message
Kay Roepke (kay-roepke) wrote :

On Feb 6, 2009, at 2:39 PM, Joshua Zhu wrote:

> But I think the patch below should be applied, otherwise the program
> would crash when the read_handshake() hook returning
> proxy.PROXY_SEND_RESULT
> or proxy.PROXY_SEND_QUERY(see proxy_lua_read_handshake() for more
> details).

good catch!

thanks,
-k
--
Kay Roepke
Software Engineer, MySQL Enterprise Tools

Sun Microsystems GmbH Sonnenallee 1, DE-85551 Kirchheim-Heimstetten
Geschaeftsfuehrer: Thomas Schroeder, Wolfang Engels, Dr. Roland Boemer
Vorsitz d. Aufs.rat.: Martin Haering HRB MUC 161028

« Back to merge proposal