Merge lp:~zhenqiang-chen/gcc-linaro/shrink-wrap into lp:gcc-linaro

Proposed by Zhenqiang Chen
Status: Merged
Approved by: Yvan Roux
Approved revision: no longer in the source branch.
Merge reported by: Christophe Lyon
Merged at revision: not available
Proposed branch: lp:~zhenqiang-chen/gcc-linaro/shrink-wrap
Merge into: lp:gcc-linaro
To merge this branch: bzr merge lp:~zhenqiang-chen/gcc-linaro/shrink-wrap
Reviewer Review Type Date Requested Status
Yvan Roux Approve
Review via email: mp+167696@code.launchpad.net

Description of the change

Enable shrink-wrap for ARM.

To post a comment you must log in.
Revision history for this message
Linaro Toolchain Builder (cbuild) wrote :

cbuild has taken a snapshot of this branch at r122047 and queued it for build.

The diff against the ancestor r122046 is available at:
 http://cbuild.validation.linaro.org/snapshots/gcc-linaro-4.8+bzr122047~zhenqiang-chen~shrink-wrap.diff

and will be built on the following builders:
 a9-builder a9hf-builder armv5-builder i686 x86_64 xaarch64 xaarch64_bare xcortexa15hf

You can track the build queue at:
 http://cbuild.validation.linaro.org/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.8+bzr122047~zhenqiang-chen~shrink-wrap
cbuild-ancestor: lp:gcc-linaro+bzr122046
cbuild-state: check

Revision history for this message
Yvan Roux (yvan-roux) wrote :

* Diff matches upstream, but on 4.8 the Linaro ChangeLog policy has changed:
  the changes has to log in the ChangeLog.linaro under each sub-directory, thus
  you have to split it in gcc/ChangeLog.linaro and gcc/testsuite/ChangeLog.linaro

* waiting for results

review: Needs Information
Revision history for this message
Yvan Roux (yvan-roux) wrote :

* xaarch64, x86_64, : gcc.dg/shrink-wrap-alloca.c failed

+ armv5, a15, AArch64_bare diffs are missing=> re-spawned ancestor

review: Needs Information
Revision history for this message
Zhenqiang Chen (zhenqiang-chen) wrote :

gcc.dg/shrink-wrap-alloca.c is a new test case for shrink-wrap. The fail is due to a warning message for 64-bit system.

gcc.dg/shrink-wrap-alloca.c:4:14: warning: conflicting types for built-in function ‘alloca’ [enabled by default]
 extern int * alloca (int);
              ^
This is a test case issue.

I will submit a bug and fix the test case later.

Revision history for this message
Yvan Roux (yvan-roux) wrote :

* a15 is clean and AArch64_bare is clean too with the expected shrink-wrap test case failure.
* armv5 still failing

Revision history for this message
Yvan Roux (yvan-roux) wrote :

* armv5 manual compare is clean

review: Approve
Revision history for this message
Christophe Lyon (christophe-lyon) wrote :

Committed upstream as rev 199923.

Subscribers

People subscribed via source and target branches

to all changes: