Merge lp:~zhenqiang-chen/gcc-linaro/arm-linux-gnueabihf into lp:gcc-linaro/4.7

Proposed by Zhenqiang Chen
Status: Rejected
Rejected by: Michael Hope
Proposed branch: lp:~zhenqiang-chen/gcc-linaro/arm-linux-gnueabihf
Merge into: lp:gcc-linaro/4.7
To merge this branch: bzr merge lp:~zhenqiang-chen/gcc-linaro/arm-linux-gnueabihf
Reviewer Review Type Date Requested Status
Linaro Toolchain Builder Needs Fixing
Ulrich Weigand Pending
Review via email: mp+105039@code.launchpad.net

Description of the change

Add arm-linux-gnueabihf support.

To post a comment you must log in.
Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild has taken a snapshot of this branch at r114985 and queued it for build.

The diff against the ancestor r114984 is available at:
 http://builds.linaro.org/toolchain/snapshots/gcc-linaro-4.7+bzr114985~zhenqiang-chen~arm-linux-gnueabihf.diff

and will be built on the following builders:
 a9-builder armv5-builder i686 x86_64

You can track the build queue at:
 http://ex.seabright.co.nz/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.7+bzr114985~zhenqiang-chen~arm-linux-gnueabihf
cbuild-ancestor: lp:gcc-linaro+bzr114984
cbuild-state: check

Revision history for this message
Linaro Toolchain Builder (cbuild) wrote :
Revision history for this message
Linaro Toolchain Builder (cbuild) wrote :
Revision history for this message
Linaro Toolchain Builder (cbuild) wrote :
Revision history for this message
Linaro Toolchain Builder (cbuild) wrote :
Revision history for this message
Michael Hope (michaelh1) wrote :

I've spawned this into the hf builder as well.

Revision history for this message
Linaro Toolchain Builder (cbuild) wrote :

cbuild had trouble building this on armv7l-precise-cbuild296-ursa3-cortexa9hfr1.

See the *failed.txt logs under the build results at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr114985~zhenqiang-chen~arm-linux-gnueabihf/logs/armv7l-precise-cbuild296-ursa3-cortexa9hfr1

The test suite results were not checked.

cbuild-checked: armv7l-precise-cbuild296-ursa3-cortexa9hfr1

review: Needs Fixing
Revision history for this message
Ulrich Weigand (uweigand) wrote :

In file included from /usr/include/stdio.h:28:0,
                 from ../../../../gcc-linaro-4.7/libgcc/../gcc/tsystem.h:88,
                 from ../../../../gcc-linaro-4.7/libgcc/libgcc2.c:29:
/usr/include/features.h:357:25: fatal error: sys/cdefs.h: No such file or directory

This seems to be some setup issue on the HF builder?

Revision history for this message
Michael Hope (michaelh1) wrote :

Sorry, this is my fault for using Zhenqiang's merge request to test the builders. I'll spin my own.

Revision history for this message
Ulrich Weigand (uweigand) wrote :

For completeness' sake, I think you should also update this line in
./gcc/ada/gcc-interface/Makefile.in:

ifeq ($(strip $(filter-out arm% linux-gnueabi,$(arch) $(osys)-$(word 4,$(targ)))),)

I think this now needs to be "linux-gnueabi%" instead of just "linux-gnueabi".

(Of course, you should test an Ada build to ensure this works; I think the automated builders skip Ada.)

Also, the patch needs a ChangeLog.linaro entry.

Otherwise, this patch looks good to me.

Revision history for this message
Michael Hope (michaelh1) wrote :

Subscribers

People subscribed via source and target branches