Merge lp:~zhangew401/scope-aggregator/fix-lp-1604212 into lp:scope-aggregator

Proposed by Zhang Enwei
Status: Merged
Approved by: Kyle Nitzsche
Approved revision: 168
Merged at revision: 168
Proposed branch: lp:~zhangew401/scope-aggregator/fix-lp-1604212
Merge into: lp:scope-aggregator
Diff against target: 38 lines (+11/-5)
2 files modified
CMakeLists.txt (+1/-1)
src/utils.cpp (+10/-4)
To merge this branch: bzr merge lp:~zhangew401/scope-aggregator/fix-lp-1604212
Reviewer Review Type Date Requested Status
Kyle Nitzsche (community) Approve
Gary.Wang Approve
Penk Chen Pending
Review via email: mp+300406@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Gary.Wang (gary-wzl77) wrote :

Thanks for this merge proposal.
It looks good to me.

P.S.
I think this issue was introduced by this MP
https://code.launchpad.net/~gary-wzl77/scope-aggregator/4.8-opt
Sorry.

review: Approve
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

LGTM - thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2016-07-07 21:53:05 +0000
3+++ CMakeLists.txt 2016-07-19 02:03:53 +0000
4@@ -1,4 +1,4 @@
5-set(VERSION "4.9")
6+set(VERSION "4.10")
7
8 # Supress qDebug() output
9 ADD_DEFINITIONS( -DQT_NO_DEBUG_OUTPUT )
10
11=== modified file 'src/utils.cpp'
12--- src/utils.cpp 2016-07-07 21:03:37 +0000
13+++ src/utils.cpp 2016-07-19 02:03:53 +0000
14@@ -280,14 +280,20 @@
15 {
16 QString child_dept = scope_o[QStringLiteral("child_department")].toString();
17
18- if (agg_scope_->lang().size() == 2 && child_dept.contains(QStringLiteral("LANGCODE")))
19+ if (agg_scope_->lang().size() == 2)
20 {
21- child_dept = child_dept.replace(QStringLiteral("LANGCODE"), qstr(agg_scope_->lang()));
22+ if (child_dept.contains(QStringLiteral("LANGCODE")))
23+ {
24+ child_dept = child_dept.replace(QStringLiteral("LANGCODE"), qstr(agg_scope_->lang()));
25+ }
26 scopeLocalId_childDept_m[local_id] = child_dept.toStdString();
27 }
28- if (agg_scope_->country().size() == 2 && child_dept.contains(QStringLiteral("COUNTRYCODE")))
29+ if (agg_scope_->country().size() == 2)
30 {
31- child_dept = child_dept.replace(QStringLiteral("COUNTRYCODE"), qstr(agg_scope_->country()));
32+ if (child_dept.contains(QStringLiteral("COUNTRYCODE")))
33+ {
34+ child_dept = child_dept.replace(QStringLiteral("COUNTRYCODE"), qstr(agg_scope_->country()));
35+ }
36 scopeLocalId_childDept_m[local_id] = child_dept.toStdString();
37 }
38 qDebug() << qstr("=== CHDEPT. lang: %1 local %2. dept %3").arg(qstr(agg_scope_->lang()),

Subscribers

People subscribed via source and target branches

to all changes: