lp:~zeutschel/goobi-production/refactoring-filesystem-and-shellscript-functions

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:goobi-production/1.7

Ralf Claussnitzer (community): Approve on 2012-05-30

Matthias Ronge (community): Needs Resubmitting on 2012-05-30

Henning Gerhardt: Disapprove on 2012-05-22

Diff: 825 lines (+379/-194)

11 files modified

src/de/sub/goobi/beans/Benutzer.java (+2/-3)
src/de/sub/goobi/beans/Prozess.java (+9/-14)
src/de/sub/goobi/config/ConfigMain.java (+2/-4)
src/de/sub/goobi/export/dms/ExportDms.java (+2/-2)
src/de/sub/goobi/export/download/ExportMets.java (+2/-1)
src/de/sub/goobi/helper/FilesystemHelper.java (+75/-3)
src/de/sub/goobi/helper/Helper.java (+15/-136)
src/de/sub/goobi/helper/HelperSchritte.java (+1/-1)
src/de/sub/goobi/helper/ShellScript.java (+264/-0)
src/de/sub/goobi/helper/WebDav.java (+5/-29)
src/de/sub/goobi/helper/ldap/Ldap.java (+2/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

60. By Matthias Ronge on 2012-05-30

Fixed null pointer exception & improved error messages

59. By Matthias Ronge on 2012-05-30

Merged with current state of lp:goobi-production

58. By Matthias Ronge on 2012-04-24

This change contains various code restructuring concerning the filesystem operations and shell scripting. It’s also a step towards downsizing the god object “Helper”.

Changes to Filesystem operations:

- File system functionality has been moved from “Helper” and “Prozess” into a new Class “FilesystemHelper”.
- Code has been refactored, checking for existence of a directory has been centralised.
- A locking issue with the file renaming functionality, especially under Windows, has been fixed.

Changes to Shell scripting:

- Scripting functionality has been moved from “Helper” into a new Class “ShellScript”.
- White spaces in path names are now correctly passed to the ProcessBuilder.
- The error level return value can now be accessed independend of output to stderr.
- Code has been refactored, the results parsing has been centralised, stub methods isEmptyCommand() and closeProcessStreams() have been re-integrated.

57. By Ralf Claussnitzer on 2012-04-20

fixes lp:788160 Error reading in TIFF images (in metadata editor)

56. By Ralf Claussnitzer on 2012-04-20

fixes lp:980612 invalid default database schema

55. By Ralf Claussnitzer on 2012-04-19

Adding a ant task for compiling JSP files

54. By Ralf Claussnitzer on 2012-04-17

fixes lp:955072 missing feature in "Additional task notes"

53. By Ralf Claussnitzer on 2012-04-17

Add ant build target for standalone CLI client.

52. By Ralf Claussnitzer on 2012-04-16

fixes lp:983083 inconsistent behavior when deleting a user

51. By Ralf Claussnitzer on 2012-04-16

fixes lp:974221 Backup rotation faulty