Merge lp:~zeroincombenze/openobject-italia/7.0 into lp:~openobject-italia-core-devs/openobject-italia/italian-addons-7.0

[Antonio M. - Zeroincombenze]

[FIX] Bug #1335867 Randomly Tax has diff. rates

Added new check condition

[Antonio M. - Zeroincombenze (zeroincombenze)]

Bug #1335867
Randomly, software report follow wrong error message:
"The taxes %s have different rates"
As in example file, undeductible tax has 2 sub codes, first with suffix a for undeductible rate and last with suffix b for deductible rate.
The last one has type = 'balance' in order to receive all residual amount.

The wrong code at line 35, property '_have_same_rate' does not check for this condition and returns a unpredictable value, as is randomly recorded.

[Lorenzo Battistini (elbati)]

LGTM

Thanks!

review: Approve (code review)

[Davide Corio (enlightx-deactivatedaccount)]

review: Approve (code review, no test)

[Lorenzo Battistini (elbati)]

This project is now hosted on https://github.com/OCA/l10n-italy. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

Unmerged revisions

241. By openerp <openerp@shs-av-dev> on 2014-06-30

[FIX] Bug #1335867 Randomly Tax has diff. rates

=== modified file 'l10n_it_partially_deductible_vat/AUTHORS.txt'
--- l10n_it_partially_deductible_vat/AUTHORS.txt	2013-01-08 22:58:30 +0000
+++ l10n_it_partially_deductible_vat/AUTHORS.txt	2014-07-01 11:44:22 +0000
@@ -1,2 +1,3 @@
-Lorenzo Battistini <[e-mail]>
-Franco Tampieri <[e-mail]>
+Lorenzo Battistini <[e-mail]>
+Franco Tampieri <[e-mail]>
+Antonio M. Vigliotti <[e-mail]>
\ No newline at end of file

=== modified file 'l10n_it_partially_deductible_vat/__openerp__.py'
--- l10n_it_partially_deductible_vat/__openerp__.py	2014-06-23 09:55:36 +0000
+++ l10n_it_partially_deductible_vat/__openerp__.py	2014-07-01 11:44:22 +0000
@@ -25,7 +25,7 @@
 
 {
     "name" : "Italy - Partially Deductible VAT",
-    "version" : "0.1",
+    "version" : "0.2",
     "depends" : ['account'],
     "author" : "OpenERP Italian Community",
     "description": """

=== modified file 'l10n_it_partially_deductible_vat/account.py'
--- l10n_it_partially_deductible_vat/account.py	2013-05-23 16:55:09 +0000
+++ l10n_it_partially_deductible_vat/account.py	2014-07-01 11:44:22 +0000
@@ -32,15 +32,19 @@
 
     _inherit = 'account.tax'
 
+# See Bug #1335867
+# [antoniov: 2014-06-30] if account_tax.type is 'balance', 'amount' value is unpredictable. Random bug!
     def _have_same_rate(self, account_taxes):
         rate = None
         for account_tax in account_taxes:
-            if rate is None:
-                rate = account_tax.amount
-            elif rate != account_tax.amount:
-                return False
+            if account_tax.type != 'balance':
+                if rate is None:
+                    rate = account_tax.amount
+                elif rate != account_tax.amount:
+                    return False
         return True
 
+    
     def get_main_tax(self, tax):
         if not tax.parent_id:
             return tax