Merge lp:~zequence/ubuntu/precise/jackd2/fix-for-956438 into lp:ubuntu/precise/jackd2
Proposed by
Kaj Ailomaa
on 2013-03-18
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Martin Pitt on 2013-03-25 | ||||
Approved revision: | 17 | ||||
Merge reported by: | Martin Pitt | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~zequence/ubuntu/precise/jackd2/fix-for-956438 | ||||
Merge into: | lp:ubuntu/precise/jackd2 | ||||
Diff against target: |
137 lines (+117/-0) 3 files modified
debian/changelog (+7/-0) debian/patches/jackdbus-stop-fix.patch (+109/-0) debian/patches/series (+1/-0) |
||||
To merge this branch: | bzr merge lp:~zequence/ubuntu/precise/jackd2/fix-for-956438 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Pitt | 2013-03-18 | Approve on 2013-03-25 | |
Marc Deslauriers | Needs Fixing on 2013-03-19 | ||
Review via email:
|
Description of the change
Fixes Bug #956438
To post a comment you must log in.
lp:~zequence/ubuntu/precise/jackd2/fix-for-956438
updated
on 2013-03-19
- 17. By Kaj Ailomaa on 2013-03-19
-
cleaned, by removing .orig files from the jackdbus-
stop-fix. patch
Martin Pitt (pitti) wrote : | # |
I uploaded this to precise-proposed review queue, with a proper changelog entry. Thank you!
review:
Approve
NACK on the merge request. Your patch included a bunch of unwanted changes, such as adding "JackLibAPI. cpp.orig" , "JackLockedEngi ne.h.orig" , etc.
Please correct the patch, and submit again. Thanks!