Merge lp:~zeller-benjamin/ubuntu-ui-toolkit/qrcify2 into lp:ubuntu-ui-toolkit/staging

Proposed by Benjamin Zeller
Status: Work in progress
Proposed branch: lp:~zeller-benjamin/ubuntu-ui-toolkit/qrcify2
Merge into: lp:ubuntu-ui-toolkit/staging
Prerequisite: lp:~zeller-benjamin/ubuntu-ui-toolkit/qrcify
Diff against target: 79 lines (+15/-26)
5 files modified
src/Ubuntu/Components/Components.pro (+0/-1)
src/Ubuntu/Components/Styles/Styles.pro (+0/-15)
src/Ubuntu/Components/Styles/qmldir (+0/-10)
src/Ubuntu/Components/components.qrc (+6/-0)
src/Ubuntu/Components/plugin/plugin.cpp (+9/-0)
To merge this branch: bzr merge lp:~zeller-benjamin/ubuntu-ui-toolkit/qrcify2
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Needs Fixing
PS Jenkins bot continuous-integration Needs Fixing
Zsombor Egri Needs Fixing
Review via email: mp+266373@code.launchpad.net

Commit message

- Move Styles module into the main Components plugin

Description of the change

- Move Styles module into the main Components plugin

To post a comment you must log in.
Revision history for this message
Zsombor Egri (zsombi) wrote :

Looks good

review: Approve
Revision history for this message
Zsombor Egri (zsombi) wrote :

Needs some love :)

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1589. By Benjamin Zeller

Merge

1590. By Benjamin Zeller

Beautify

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1591. By Benjamin Zeller

Merge with qrcify

1592. By Benjamin Zeller

Fix package build

1593. By Benjamin Zeller

Rollback temporary changes

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-autolanding/12/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-land-mp/12/console

review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-autolanding/27/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-land-mp/27/console

review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

1593. By Benjamin Zeller

Rollback temporary changes

1592. By Benjamin Zeller

Fix package build

1591. By Benjamin Zeller

Merge with qrcify

1590. By Benjamin Zeller

Beautify

1589. By Benjamin Zeller

Merge

1588. By Benjamin Zeller

Merge base branch

1587. By Benjamin Zeller

Merge staging

1586. By Benjamin Zeller

Merge staging

1585. By Benjamin Zeller

Merge with base branch

1584. By Benjamin Zeller

- Move Styles module into main plugin qrc

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/Components/Components.pro'
2--- src/Ubuntu/Components/Components.pro 2015-05-18 09:53:55 +0000
3+++ src/Ubuntu/Components/Components.pro 2015-10-27 10:44:18 +0000
4@@ -4,5 +4,4 @@
5 ComponentModule.pro \
6 Pickers \
7 Popups \
8- Styles \
9 Themes
10
11=== removed file 'src/Ubuntu/Components/Styles/Styles.pro'
12--- src/Ubuntu/Components/Styles/Styles.pro 2015-10-23 05:42:14 +0000
13+++ src/Ubuntu/Components/Styles/Styles.pro 1970-01-01 00:00:00 +0000
14@@ -1,15 +0,0 @@
15-TARGETPATH = Ubuntu/Components/Styles
16-
17-ARTWORK_FILES = $$system(find artwork -type f)
18-
19-QML_FILES += 1.2/ComboButtonStyle.qml \
20- 1.2/PageHeadStyle.qml \
21- 1.2/PullToRefreshStyle.qml \
22- 1.3/PageHeadStyle.qml \
23- 1.3/ActionBarStyle.qml \
24- 1.3/PageHeaderStyle.qml \
25- $$ARTWORK_FILES
26-
27-load(ubuntu_qml_module)
28-
29-OTHER_FILES+=qmldir
30
31=== removed file 'src/Ubuntu/Components/Styles/qmldir'
32--- src/Ubuntu/Components/Styles/qmldir 2015-10-08 21:19:56 +0000
33+++ src/Ubuntu/Components/Styles/qmldir 1970-01-01 00:00:00 +0000
34@@ -1,10 +0,0 @@
35-module Ubuntu.Components.Styles
36-ComboButtonStyle 1.1 1.2/ComboButtonStyle.qml
37-PullToRefreshStyle 1.1 1.2/PullToRefreshStyle.qml
38-PageHeadStyle 1.1 1.2/PageHeadStyle.qml
39-
40-#version 1.2 introduced by ListItemStyle
41-#version 1.3
42-PageHeadStyle 1.3 1.3/PageHeadStyle.qml
43-ActionBarStyle 1.3 1.3/ActionBarStyle.qml
44-PageHeaderStyle 1.3 1.3/PageHeaderStyle.qml
45
46=== modified file 'src/Ubuntu/Components/components.qrc'
47--- src/Ubuntu/Components/components.qrc 2015-10-27 10:44:18 +0000
48+++ src/Ubuntu/Components/components.qrc 2015-10-27 10:44:18 +0000
49@@ -125,5 +125,11 @@
50 <file>artwork/chevron@27.png</file>
51 <file>artwork/delete@8.png</file>
52 <file>artwork/ListItemDivider6px@8.png</file>
53+ <file>Styles/1.2/ComboButtonStyle.qml</file>
54+ <file>Styles/1.2/PageHeadStyle.qml</file>
55+ <file>Styles/1.2/PullToRefreshStyle.qml</file>
56+ <file>Styles/1.3/ActionBarStyle.qml</file>
57+ <file>Styles/1.3/PageHeadStyle.qml</file>
58+ <file>Styles/1.3/PageHeaderStyle.qml</file>
59 </qresource>
60 </RCC>
61
62=== modified file 'src/Ubuntu/Components/plugin/plugin.cpp'
63--- src/Ubuntu/Components/plugin/plugin.cpp 2015-10-20 09:19:50 +0000
64+++ src/Ubuntu/Components/plugin/plugin.cpp 2015-10-27 10:44:18 +0000
65@@ -260,6 +260,15 @@
66 qmlRegisterType<UCListItemStyle>(styleUri, 1, 2, "ListItemStyle");
67 qmlRegisterType<UCListItemStyle, 1>(styleUri, 1, 3, "ListItemStyle");
68
69+ //register styles
70+ qmlRegisterType(QUrl("qrc:/Ubuntu/Components/Styles/1.2/ComboButtonStyle.qml"), styleUri, 1, 1, "ComboButtonStyle");
71+ qmlRegisterType(QUrl("qrc:/Ubuntu/Components/Styles/1.2/PullToRefreshStyle.qml"), styleUri, 1, 1, "PullToRefreshStyle");
72+ qmlRegisterType(QUrl("qrc:/Ubuntu/Components/Styles/1.2/PageHeadStyle.qml"), styleUri, 1, 1, "PageHeadStyle");
73+
74+ qmlRegisterType(QUrl("qrc:/Ubuntu/Components/Styles/1.3/PageHeadStyle.qml") , styleUri, 1, 3, "PageHeadStyle");
75+ qmlRegisterType(QUrl("qrc:/Ubuntu/Components/Styles/1.3/ActionBarStyle.qml"), styleUri, 1, 3, "ActionBarStyle");
76+ qmlRegisterType(QUrl("qrc:/Ubuntu/Components/Styles/1.3/PageHeaderStyle.qml"), styleUri, 1, 3, "PageHeaderStyle");
77+
78 QQmlExtensionPlugin::initializeEngine(engine, uri);
79 QQmlContext* context = engine->rootContext();
80

Subscribers

People subscribed via source and target branches