Merge lp:~zeller-benjamin/ubuntu-sdk-ide/kitregister into lp:ubuntu-sdk-ide

Proposed by Benjamin Zeller
Status: Merged
Merged at revision: 73
Proposed branch: lp:~zeller-benjamin/ubuntu-sdk-ide/kitregister
Merge into: lp:ubuntu-sdk-ide
Diff against target: 147 lines (+84/-7)
3 files modified
CMakeLists.txt (+27/-7)
create_sdk.sh (+46/-0)
patches/qtc.patch (+11/-0)
To merge this branch: bzr merge lp:~zeller-benjamin/ubuntu-sdk-ide/kitregister
Reviewer Review Type Date Requested Status
Zoltan Balogh Pending
Review via email: mp+275300@code.launchpad.net

Commit message

- Automatically create Kits on creation
- Add a custom ConcatStrings function to make the scripts more readable

Description of the change

- Automatically create Kits on creation
- Add a custom ConcatStrings function to make the scripts more readable

To post a comment you must log in.
70. By Benjamin Zeller

Variable can be undefined

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2015-10-21 12:41:11 +0000
3+++ CMakeLists.txt 2015-10-22 11:04:16 +0000
4@@ -5,9 +5,16 @@
5 project(ubuntu-sdk-ide C CXX)
6
7 include(ExternalProject)
8-
9 include(ProcessorCount)
10
11+function(ConcatStrings targetVar )
12+ set(loc_val ${${targetVar}})
13+ foreach(curr_substr ${ARGN})
14+ set(loc_val "${loc_val}${curr_substr}")
15+ endforeach()
16+ set(${targetVar} ${loc_val} PARENT_SCOPE)
17+endfunction()
18+
19 ProcessorCount(JOBS)
20 if(NOT JOBS EQUAL 0)
21 set(GENERATED_MAKE_FLAGS -j${JOBS})
22@@ -38,8 +45,13 @@
23 )
24
25 SET (DBUSMENU_PREFIX "${CMAKE_BINARY_DIR}/libdbusmenu-qt-build")
26-SET (DBUSMENU_BUILD_SCRIPT
27- "${CMAKE_COMMAND} -DCMAKE_INSTALL_PREFIX=${QT_INSTALL_DIR} -DCMAKE_PREFIX_PATH=${QT_INSTALL_DIR} -DUSE_QT5=true -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_LIBDIR=lib ${DBUSMENU_PREFIX}/libdbusmenu-qt"
28+ConcatStrings (DBUSMENU_BUILD_SCRIPT
29+ "${CMAKE_COMMAND} "
30+ "-DCMAKE_INSTALL_PREFIX=${QT_INSTALL_DIR} "
31+ "-DCMAKE_PREFIX_PATH=${QT_INSTALL_DIR} "
32+ "-DUSE_QT5=true "
33+ "-DCMAKE_BUILD_TYPE=RelWithDebInfo "
34+ "-DCMAKE_INSTALL_LIBDIR=lib ${DBUSMENU_PREFIX}/libdbusmenu-qt "
35 )
36
37 ExternalProject_Add(libdbusmenu-qt
38@@ -68,7 +80,15 @@
39 )
40
41 SET (QTCREATOR_PREFIX "${CMAKE_BINARY_DIR}/qtcreator-build")
42-SET (QTC_PATCH_SCRIPT "bzr branch lp:qtcreator-plugin-ubuntu ${QTCREATOR_PREFIX}/qtcreator/src/plugins/ubuntu -Ossl.cert_reqs=none && sed -i 's/\\(welcome\\)/\\1 \\\\ \\n ubuntu/g' ${QTCREATOR_PREFIX}/qtcreator/src/plugins/plugins.pro"
43+ConcatStrings(QTC_DOWNLOAD_SCRIPT
44+ "dget https://launchpad.net/ubuntu/+archive/primary/+files/qtcreator_3.5.0+dfsg-1ubuntu3.dsc "
45+ "&& rsync -auvr --delete-after qtcreator-3.5.0+dfsg/ ${QTCREATOR_PREFIX}/qtcreator"
46+)
47+ConcatStrings(QTC_PATCH_SCRIPT
48+ "cd ${QTCREATOR_PREFIX}/qtcreator "
49+ "&& patch -p1 ${CMAKE_SOURCE_DIR}/patches/qtc.patch "
50+ "&& bzr branch lp:qtcreator-plugin-ubuntu ${QTCREATOR_PREFIX}/qtcreator/src/plugins/ubuntu -Ossl.cert_reqs=none "
51+ "&& sed -i 's/\\(welcome\\)/\\1 \\\\ \\n ubuntu/g' ${QTCREATOR_PREFIX}/qtcreator/src/plugins/plugins.pro"
52 )
53
54 ExternalProject_Add(qtcreator_3.5.0
55@@ -77,7 +97,7 @@
56 SOURCE_DIR "${QTCREATOR_PREFIX}/qtcreator"
57 BINARY_DIR "${QTCREATOR_PREFIX}/build"
58 INSTALL_DIR "${CMAKE_BINARY_DIR}/ubuntu-sdk-ide"
59- DOWNLOAD_COMMAND sh -c "dget https://launchpad.net/ubuntu/+archive/primary/+files/qtcreator_3.5.0+dfsg-1ubuntu3.dsc && rsync -auvr --delete-after qtcreator-3.5.0+dfsg/ ${QTCREATOR_PREFIX}/qtcreator"
60+ DOWNLOAD_COMMAND sh -c "${QTC_DOWNLOAD_SCRIPT}"
61 PATCH_COMMAND sh -c "${QTC_PATCH_SCRIPT}"
62 CONFIGURE_COMMAND sh -c "${QT_INSTALL_DIR}/bin/qmake -r USE_SYSTEM_BOTAN=1 ${QTCREATOR_PREFIX}/qtcreator"
63 BUILD_COMMAND sh -c "QT_PRIVATE_HEADERS=${QT_INSTALL_DIR} LD_LIBRARY_PATH=${QT_INSTALL_DIR}/lib make ${GENERATED_MAKE_FLAGS}"
64@@ -123,7 +143,7 @@
65 INSTALL_DIR "${QT_KIT_PREFIX}/qt"
66 DOWNLOAD_COMMAND sh -c "cd ${QT_KIT_SOURCE_DIR} && ${CMAKE_SOURCE_DIR}/get_qt_sources.py"
67 UPDATE_COMMAND sh -c "exit 0" #nothing to update
68- PATCH_COMMAND sh -c "cp ${CMAKE_SOURCE_DIR}/desktop_kit_qt.pro ${QT_KIT_SOURCE_DIR}/qt.pro && cp ${CMAKE_SOURCE_DIR}/desktop_kit_configure ${QT_KIT_SOURCE_DIR}/configure"
69+ PATCH_COMMAND sh -c "cp ${CMAKE_SOURCE_DIR}/desktop_kit_qt.pro ${QT_KIT_SOURCE_DIR}/qt.pro && cp ${CMAKE_SOURCE_DIR}/desktop_kit_configure ${QT_KIT_SOURCE_DIR}/configure"
70 CONFIGURE_COMMAND sh -c "${QT_KIT_SOURCE_DIR}/configure -prefix /usr/ubuntu-sdk-dev `cat ${CMAKE_SOURCE_DIR}/kit_config`"
71 BUILD_COMMAND sh -c "make ${GENERATED_MAKE_FLAGS}"
72 INSTALL_COMMAND sh -c "make INSTALL_ROOT=${QT_KIT_PREFIX}/qt install"
73@@ -139,5 +159,5 @@
74 UPDATE_COMMAND sh -c "exit 0" #nothing to update
75 CONFIGURE_COMMAND sh -c "exit 0"
76 BUILD_COMMAND sh -c "cp ${EXTRAS_PREFIX}/ubuntu-sdk-qmake-extras/*.prf ${QT_KIT_PREFIX}/qt/usr/ubuntu-sdk-dev/mkspecs/features"
77- INSTALL_COMMAND sh -c "exit 0"
78+ INSTALL_COMMAND sh -c "cd ${CMAKE_BINARY_DIR} && ${CMAKE_SOURCE_DIR}/create_sdk.sh"
79 )
80
81=== added file 'create_sdk.sh'
82--- create_sdk.sh 1970-01-01 00:00:00 +0000
83+++ create_sdk.sh 2015-10-22 11:04:16 +0000
84@@ -0,0 +1,46 @@
85+#!/bin/bash
86+
87+GCC_UID=""
88+QT_UID="UbuntuSDK-API-Qt"
89+
90+case "$(dpkg-architecture -qDEB_HOST_MULTIARCH 2> /dev/null)" in
91+ x86_64-linux-gnu)
92+ GCC_UID="ProjectExplorer.ToolChain.Gcc:UbuntuSDKGCC-x86_64-linux-gnu"
93+ ./ubuntu-sdk-ide/bin/sdktool addTC \
94+ --id "${GCC_UID}" \
95+ --name "GCC (x86 64bit in /usr/bin/g++)" \
96+ --path /usr/bin/g++ \
97+ --abi x86-linux-generic-elf-64bit \
98+ --supportedAbis x86-linux-generic-elf-64bit,x86-linux-generic-elf-32bit
99+ ;;
100+
101+ i386-linux-gnu)
102+ GCC_UID="ProjectExplorer.ToolChain.Gcc:UbuntuSDKGCC-x86-linux-generic-elf-32bit"
103+ ./ubuntu-sdk-ide/bin/sdktool addTC \
104+ --id "${GCC_UID}" \
105+ --name "GCC (x86 32bit in /usr/bin/g++)" \
106+ --path /usr/bin/g++ \
107+ --abi x86-linux-generic-elf-32bit \
108+ --supportedAbis x86-linux-generic-elf-32bit
109+ ;;
110+
111+ *)
112+ echo "Unknown architecture"
113+ exit 1
114+ ;;
115+esac
116+
117+./ubuntu-sdk-ide/bin/sdktool addQt \
118+ --id "${QT_UID}" \
119+ --name "Ubuntu SDK Desktop Qt" \
120+ --qmake /usr/ubuntu-sdk-dev/bin/qmake \
121+ --type Qt4ProjectManager.QtVersion.Desktop
122+
123+./ubuntu-sdk-ide/bin/sdktool addKit \
124+ --id "UbuntuSDK-API-Desktop-Kit" \
125+ --name "Ubuntu SDK Desktop Kit" \
126+ --debuggerengine 1 \
127+ --debugger /usr/bin/gdb \
128+ --devicetype Desktop \
129+ --toolchain "${GCC_UID}" \
130+ --qt "${QT_UID}"
131
132=== added directory 'patches'
133=== added file 'patches/qtc.patch'
134--- patches/qtc.patch 1970-01-01 00:00:00 +0000
135+++ patches/qtc.patch 2015-10-22 11:04:16 +0000
136@@ -0,0 +1,11 @@
137+--- qtcreator/src/plugins/qtsupport/qtversionmanager.cpp 2015-10-21 17:53:48.000000000 +0200
138++++ qtcreator/src/plugins/qtsupport/qtversionmanager.cpp 2015-10-22 11:50:21.323455563 +0200
139+@@ -458,7 +458,7 @@
140+
141+ QMap<QString, int> currentAutoVersions;
142+ for (QMap<int, BaseQtVersion *>::const_iterator i = m_versions.begin(); i != m_versions.end(); ++i) {
143+- if (i.value()->isAutodetected()) {
144++ if (i.value()->isAutodetected() && !i.value()->autodetectionSource().startsWith(QLatin1String("SDK."))) {
145+ currentAutoVersions.insert(i.value()->qmakeCommand().toString(), i.key());
146+ }
147+ }

Subscribers

People subscribed via source and target branches