Merge lp:~zeller-benjamin/ubuntu-clock-app/sdkcompat2 into lp:ubuntu-clock-app

Proposed by Benjamin Zeller
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 89
Merged at revision: 88
Proposed branch: lp:~zeller-benjamin/ubuntu-clock-app/sdkcompat2
Merge into: lp:ubuntu-clock-app
Diff against target: 47 lines (+11/-4)
2 files modified
CMakeLists.txt (+10/-3)
manifest.json.in (+1/-1)
To merge this branch: bzr merge lp:~zeller-benjamin/ubuntu-clock-app/sdkcompat2
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Nekhelesh Ramananthan Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ Pending
Review via email: mp+233671@code.launchpad.net

Commit message

- Add support for UBUNTU_MANIFEST_PATH
- Let cmake set the architecture of the manifest file automatically

Description of the change

- Add support for UBUNTU_MANIFEST_PATH
- Let cmake set the architecture of the manifest file automatically

To post a comment you must log in.
89. By Benjamin Zeller

Fix manifest file

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Works beautifully! Thanks a lot for this. One less thing change to when running on device or emulator :-)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2014-08-26 11:20:26 +0000
3+++ CMakeLists.txt 2014-09-08 07:40:24 +0000
4@@ -1,7 +1,7 @@
5 project(com.ubuntu.clock C CXX)
6 cmake_minimum_required(VERSION 2.8.9)
7
8-set (UBUNTU_PROJECT_TYPE "ClickApp" CACHE INTERNAL "Tells QtCreator this is a Click application project")
9+set (UBUNTU_MANIFEST_PATH "manifest.json.in" CACHE INTERNAL "Relative path to the manifest file")
10 set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -fno-permissive -pedantic -Wall -Wextra")
11
12 find_package(Qt5Core)
13@@ -53,12 +53,19 @@
14 OUTPUT_VARIABLE QT_IMPORTS_DIR
15 OUTPUT_STRIP_TRAILING_WHITESPACE
16 )
17-set(MODULE_PATH ${QT_IMPORTS_DIR}/ClockApp)
18+ set(MODULE_PATH ${QT_IMPORTS_DIR}/ClockApp)
19 endif(CLICK_MODE)
20
21 if(${CLICK_MODE})
22 message("-- Configuring manifest.json")
23- configure_file(manifest.json manifest.json)
24+
25+ execute_process(
26+ COMMAND dpkg-architecture -qDEB_HOST_ARCH
27+ OUTPUT_VARIABLE CLICK_ARCH
28+ OUTPUT_STRIP_TRAILING_WHITESPACE
29+ )
30+
31+ configure_file(${UBUNTU_MANIFEST_PATH} ${CMAKE_CURRENT_BINARY_DIR}/manifest.json)
32 install(FILES ${CMAKE_CURRENT_BINARY_DIR}/manifest.json DESTINATION ${CMAKE_INSTALL_PREFIX})
33 install(FILES "${APP_HARDCODE}.json" DESTINATION ${CMAKE_INSTALL_PREFIX})
34 else(CLICK_MODE)
35
36=== renamed file 'manifest.json' => 'manifest.json.in'
37--- manifest.json 2014-09-01 19:43:33 +0000
38+++ manifest.json.in 2014-09-08 07:40:24 +0000
39@@ -2,7 +2,7 @@
40 "name": "com.ubuntu.clock",
41 "description": "A sophisticated clock app for Ubuntu Touch",
42 "framework": "ubuntu-sdk-14.10-dev2",
43- "architecture": "armhf",
44+ "architecture": "@CLICK_ARCH@",
45 "title": "Clock",
46 "icon": "clock@30.png",
47 "hooks": {

Subscribers

People subscribed via source and target branches