Merge lp:~zeller-benjamin/qtcreator-plugin-ubuntu/some_fixes into lp:qtcreator-plugin-ubuntu
- some_fixes
- Merge into trunk
Proposed by
Benjamin Zeller
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Zoltan Balogh | ||||
Approved revision: | 285 | ||||
Merged at revision: | 283 | ||||
Proposed branch: | lp:~zeller-benjamin/qtcreator-plugin-ubuntu/some_fixes | ||||
Merge into: | lp:qtcreator-plugin-ubuntu | ||||
Diff against target: |
681 lines (+513/-24) 12 files modified
share/qtcreator/templates/wizards/ubuntu/scope/CMakeLists.txt (+3/-0) share/qtcreator/ubuntu/devicespage/DevicePage.qml (+9/-9) share/qtcreator/ubuntu/devicespage/DeviceStatusTab.qml (+2/-2) share/qtcreator/ubuntu/devicespage/FeatureStateItem.qml (+2/-2) share/qtcreator/ubuntu/devicespage/ScrollableView.qml (+1/-1) share/qtcreator/ubuntu/devicespage/SectionItem.qml (+4/-5) share/qtcreator/ubuntu/devicespage/main.qml (+1/-1) src/ubuntu/images/security-alert.svg (+158/-0) src/ubuntu/images/view-collapse.svg (+163/-0) src/ubuntu/images/view-expand.svg (+163/-0) src/ubuntu/resources.qrc (+3/-0) src/ubuntu/ubuntueditorfactory.cpp (+4/-4) |
||||
To merge this branch: | bzr merge lp:~zeller-benjamin/qtcreator-plugin-ubuntu/some_fixes | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Zoltan Balogh | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email: mp+237909@code.launchpad.net |
Commit message
- Fix error warnings about overriding Actions
- Fix missing devicepage icons on trusty
- Fix bug lp:1379644 "I can only get the test configuration for scope
development"
Description of the change
- Fix error warnings about overriding Actions
- Fix missing devicepage icons on trusty
- Fix bug lp:1379644 "I can only get the test configuration for scope
development"
To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | === modified file 'share/qtcreator/templates/wizards/ubuntu/scope/CMakeLists.txt' |
2 | --- share/qtcreator/templates/wizards/ubuntu/scope/CMakeLists.txt 2014-10-09 07:03:22 +0000 |
3 | +++ share/qtcreator/templates/wizards/ubuntu/scope/CMakeLists.txt 2014-10-10 07:47:39 +0000 |
4 | @@ -2,6 +2,9 @@ |
5 | cmake_minimum_required(VERSION 2.8.10) |
6 | set(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake" "${CMAKE_MODULE_PATH}") |
7 | |
8 | +#do not remove this line, its required for the correct functionality of the Ubuntu-SDK |
9 | +set(UBUNTU_MANIFEST_PATH "manifest.json.in" CACHE INTERNAL "Tells QtCreator location and name of the manifest file") |
10 | + |
11 | # We require g++ 4.9, to avoid ABI breakage with earlier version. |
12 | set(cxx_version_required 4.9) |
13 | if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU") |
14 | |
15 | === modified file 'share/qtcreator/ubuntu/devicespage/DevicePage.qml' |
16 | --- share/qtcreator/ubuntu/devicespage/DevicePage.qml 2014-10-09 07:03:22 +0000 |
17 | +++ share/qtcreator/ubuntu/devicespage/DevicePage.qml 2014-10-10 07:47:39 +0000 |
18 | @@ -2,10 +2,10 @@ |
19 | import QtQuick.Layouts 1.0 |
20 | import QtQuick.Controls 1.0 as Controls |
21 | |
22 | -import Ubuntu.Components 0.1 |
23 | -import Ubuntu.Components.ListItems 0.1 as ListItem |
24 | +import Ubuntu.Components 1.0 |
25 | +import Ubuntu.Components.ListItems 1.0 as ListItem |
26 | import Ubuntu.DevicesModel 0.1 |
27 | -import Ubuntu.Components.Popups 0.1 |
28 | +import Ubuntu.Components.Popups 1.0 |
29 | |
30 | Page { |
31 | id: devicePage |
32 | @@ -217,18 +217,18 @@ |
33 | clip: true |
34 | |
35 | ListItem.Empty { |
36 | + id: errorContainer |
37 | divider.visible: false |
38 | visible: detectionError |
39 | + height: errorText.contentHeight + units.gu(4) |
40 | RowLayout { |
41 | anchors.fill: parent |
42 | - anchors.leftMargin: units.gu(2) |
43 | anchors.rightMargin: units.gu(4) |
44 | - Icon { |
45 | + Image { |
46 | id: errorIcon |
47 | - anchors.left: parent.left |
48 | - name: "security-alert" |
49 | - height:parent.height - units.gu(2) |
50 | - width: height |
51 | + source: "qrc:/ubuntu/images/security-alert.svg" |
52 | + fillMode: Image.PreserveAspectFit |
53 | + Layout.maximumHeight: errorContainer.height |
54 | } |
55 | Label { |
56 | id: errorText |
57 | |
58 | === modified file 'share/qtcreator/ubuntu/devicespage/DeviceStatusTab.qml' |
59 | --- share/qtcreator/ubuntu/devicespage/DeviceStatusTab.qml 2014-08-11 10:46:51 +0000 |
60 | +++ share/qtcreator/ubuntu/devicespage/DeviceStatusTab.qml 2014-10-10 07:47:39 +0000 |
61 | @@ -1,8 +1,8 @@ |
62 | import QtQuick 2.0 |
63 | import QtQuick.Controls 1.0 as Controls |
64 | import QtQuick.Layouts 1.0 |
65 | -import Ubuntu.Components 0.1 |
66 | -import Ubuntu.Components.ListItems 0.1 as ListItem |
67 | +import Ubuntu.Components 1.0 |
68 | +import Ubuntu.Components.ListItems 1.0 as ListItem |
69 | import Ubuntu.DevicesModel 0.1 |
70 | |
71 | RowLayout { |
72 | |
73 | === modified file 'share/qtcreator/ubuntu/devicespage/FeatureStateItem.qml' |
74 | --- share/qtcreator/ubuntu/devicespage/FeatureStateItem.qml 2014-08-06 16:00:53 +0000 |
75 | +++ share/qtcreator/ubuntu/devicespage/FeatureStateItem.qml 2014-10-10 07:47:39 +0000 |
76 | @@ -1,7 +1,7 @@ |
77 | import QtQuick 2.0 |
78 | import QtQuick.Layouts 1.0 |
79 | -import Ubuntu.Components 0.1 |
80 | -import Ubuntu.Components.ListItems 0.1 as ListItem |
81 | +import Ubuntu.Components 1.0 |
82 | +import Ubuntu.Components.ListItems 1.0 as ListItem |
83 | import Ubuntu.DevicesModel 0.1 |
84 | |
85 | ListItem.Standard { |
86 | |
87 | === modified file 'share/qtcreator/ubuntu/devicespage/ScrollableView.qml' |
88 | --- share/qtcreator/ubuntu/devicespage/ScrollableView.qml 2014-10-08 10:06:04 +0000 |
89 | +++ share/qtcreator/ubuntu/devicespage/ScrollableView.qml 2014-10-10 07:47:39 +0000 |
90 | @@ -15,7 +15,7 @@ |
91 | */ |
92 | |
93 | import QtQuick 2.0 |
94 | -import Ubuntu.Components 0.1 |
95 | +import Ubuntu.Components 1.0 |
96 | |
97 | Item { |
98 | id: template |
99 | |
100 | === modified file 'share/qtcreator/ubuntu/devicespage/SectionItem.qml' |
101 | --- share/qtcreator/ubuntu/devicespage/SectionItem.qml 2014-10-08 10:06:04 +0000 |
102 | +++ share/qtcreator/ubuntu/devicespage/SectionItem.qml 2014-10-10 07:47:39 +0000 |
103 | @@ -15,8 +15,8 @@ |
104 | */ |
105 | |
106 | import QtQuick 2.0 |
107 | -import Ubuntu.Components 0.1 |
108 | -import Ubuntu.Components.ListItems 0.1 as ListItem |
109 | +import Ubuntu.Components 1.0 |
110 | +import Ubuntu.Components.ListItems 1.0 as ListItem |
111 | |
112 | ListItem.Expandable { |
113 | id: expandingColumnItem |
114 | @@ -38,9 +38,8 @@ |
115 | id: headerRow |
116 | anchors { left: parent.left; right: parent.right} |
117 | height: childrenRect.height |
118 | - Icon { |
119 | - name: expandingColumnItem.expanded ? "view-collapse" : "view-expand" |
120 | - color: UbuntuColors.orange |
121 | + Image { |
122 | + source: expandingColumnItem.expanded ? "qrc:/ubuntu/images/view-collapse.svg" : "qrc:/ubuntu/images/view-expand.svg" |
123 | width: 24 |
124 | height: 24 |
125 | } |
126 | |
127 | === modified file 'share/qtcreator/ubuntu/devicespage/main.qml' |
128 | --- share/qtcreator/ubuntu/devicespage/main.qml 2014-06-03 12:04:26 +0000 |
129 | +++ share/qtcreator/ubuntu/devicespage/main.qml 2014-10-10 07:47:39 +0000 |
130 | @@ -1,5 +1,5 @@ |
131 | import QtQuick 2.0 |
132 | -import Ubuntu.Components 0.1 |
133 | +import Ubuntu.Components 1.0 |
134 | |
135 | |
136 | MainView { |
137 | |
138 | === added file 'src/ubuntu/images/security-alert.svg' |
139 | --- src/ubuntu/images/security-alert.svg 1970-01-01 00:00:00 +0000 |
140 | +++ src/ubuntu/images/security-alert.svg 2014-10-10 07:47:39 +0000 |
141 | @@ -0,0 +1,158 @@ |
142 | +<?xml version="1.0" encoding="UTF-8" standalone="no"?> |
143 | +<!-- Created with Inkscape (http://www.inkscape.org/) --> |
144 | + |
145 | +<svg |
146 | + xmlns:dc="http://purl.org/dc/elements/1.1/" |
147 | + xmlns:cc="http://creativecommons.org/ns#" |
148 | + xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" |
149 | + xmlns:svg="http://www.w3.org/2000/svg" |
150 | + xmlns="http://www.w3.org/2000/svg" |
151 | + xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd" |
152 | + xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape" |
153 | + width="90" |
154 | + height="90" |
155 | + id="svg4874" |
156 | + version="1.1" |
157 | + inkscape:version="0.48+devel r" |
158 | + viewBox="0 0 90 90.000001" |
159 | + sodipodi:docname="browser-alert02.svg"> |
160 | + <defs |
161 | + id="defs4876" /> |
162 | + <sodipodi:namedview |
163 | + id="base" |
164 | + pagecolor="#ffffff" |
165 | + bordercolor="#666666" |
166 | + borderopacity="1.0" |
167 | + inkscape:pageopacity="0.0" |
168 | + inkscape:pageshadow="2" |
169 | + inkscape:zoom="9.9475983" |
170 | + inkscape:cx="46.126712" |
171 | + inkscape:cy="47.142033" |
172 | + inkscape:document-units="px" |
173 | + inkscape:current-layer="g1311" |
174 | + showgrid="true" |
175 | + showborder="true" |
176 | + fit-margin-top="0" |
177 | + fit-margin-left="0" |
178 | + fit-margin-right="0" |
179 | + fit-margin-bottom="0" |
180 | + inkscape:snap-bbox="true" |
181 | + inkscape:bbox-paths="true" |
182 | + inkscape:bbox-nodes="true" |
183 | + inkscape:snap-bbox-edge-midpoints="true" |
184 | + inkscape:snap-bbox-midpoints="true" |
185 | + inkscape:object-paths="true" |
186 | + inkscape:snap-intersection-paths="true" |
187 | + inkscape:object-nodes="true" |
188 | + inkscape:snap-smooth-nodes="true" |
189 | + inkscape:snap-midpoints="true" |
190 | + inkscape:snap-object-midpoints="true" |
191 | + inkscape:snap-center="true" |
192 | + showguides="true" |
193 | + inkscape:guide-bbox="true"> |
194 | + <inkscape:grid |
195 | + type="xygrid" |
196 | + id="grid5451" |
197 | + empspacing="6" /> |
198 | + <sodipodi:guide |
199 | + orientation="1,0" |
200 | + position="6,77" |
201 | + id="guide4063" /> |
202 | + <sodipodi:guide |
203 | + orientation="1,0" |
204 | + position="3,78" |
205 | + id="guide4065" /> |
206 | + <sodipodi:guide |
207 | + orientation="0,1" |
208 | + position="55,84" |
209 | + id="guide4067" /> |
210 | + <sodipodi:guide |
211 | + orientation="0,1" |
212 | + position="53,87" |
213 | + id="guide4069" /> |
214 | + <sodipodi:guide |
215 | + orientation="0,1" |
216 | + position="20,3" |
217 | + id="guide4071" /> |
218 | + <sodipodi:guide |
219 | + orientation="0,1" |
220 | + position="20,6" |
221 | + id="guide4073" /> |
222 | + <sodipodi:guide |
223 | + orientation="1,0" |
224 | + position="87,7" |
225 | + id="guide4075" /> |
226 | + <sodipodi:guide |
227 | + orientation="1,0" |
228 | + position="84,7" |
229 | + id="guide4077" /> |
230 | + <sodipodi:guide |
231 | + orientation="0,1" |
232 | + position="58,81" |
233 | + id="guide4074" /> |
234 | + <sodipodi:guide |
235 | + orientation="1,0" |
236 | + position="9,74" |
237 | + id="guide4076" /> |
238 | + <sodipodi:guide |
239 | + orientation="0,1" |
240 | + position="21,9" |
241 | + id="guide4078" /> |
242 | + <sodipodi:guide |
243 | + orientation="1,0" |
244 | + position="81,4" |
245 | + id="guide4080" /> |
246 | + </sodipodi:namedview> |
247 | + <metadata |
248 | + id="metadata4879"> |
249 | + <rdf:RDF> |
250 | + <cc:Work |
251 | + rdf:about=""> |
252 | + <dc:format>image/svg+xml</dc:format> |
253 | + <dc:type |
254 | + rdf:resource="http://purl.org/dc/dcmitype/StillImage" /> |
255 | + <dc:title></dc:title> |
256 | + </cc:Work> |
257 | + </rdf:RDF> |
258 | + </metadata> |
259 | + <g |
260 | + inkscape:label="Layer 1" |
261 | + inkscape:groupmode="layer" |
262 | + id="layer1" |
263 | + transform="translate(67.857146,-84.50504)"> |
264 | + <g |
265 | + transform="matrix(0,-1,-1,0,373.50506,516.50504)" |
266 | + id="g4845" |
267 | + style="display:inline"> |
268 | + <g |
269 | + transform="matrix(0,-1,-1,0,567.36222,615.36221)" |
270 | + id="g1311" |
271 | + inkscape:export-filename="envelope02.png" |
272 | + inkscape:export-xdpi="90" |
273 | + inkscape:export-ydpi="90"> |
274 | + <g |
275 | + id="g1313" |
276 | + transform="matrix(1.875,0,0,1.875,-366,-1657.8169)"> |
277 | + <rect |
278 | + transform="translate(0,804.3622)" |
279 | + y="152" |
280 | + x="288" |
281 | + height="48" |
282 | + width="48" |
283 | + id="rect1315" |
284 | + style="opacity:0.21171169;fill:none;stroke:none" /> |
285 | + </g> |
286 | + <path |
287 | + style="color:#000000;display:inline;overflow:visible;visibility:visible;fill:#df382c;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:3;marker:none;enable-background:accumulate" |
288 | + d="m 215,162.36222 0,8.9668 c 0,2.63533 0.12502,5.07657 0.37305,7.32617 0.248,2.21747 0.5808,4.45146 0.99414,6.70117 l 5.32812,0 c 0.37204,-2.24971 0.68364,-4.4837 0.93164,-6.70117 C 222.87497,176.4376 223,173.99659 223,171.32902 l 0,-8.9668 -8,0 z m 4,27 c -1.23751,0 -2.30703,0.43478 -3.20703,1.30273 -0.86251,0.83022 -1.29297,1.904 -1.29297,3.22461 0,1.32094 0.43046,2.39635 1.29297,3.22657 0.9,0.83022 1.96952,1.24609 3.20703,1.24609 1.27501,0 2.34452,-0.41587 3.20703,-1.24609 0.86251,-0.83022 1.29297,-1.90563 1.29297,-3.22657 0,-1.32061 -0.43046,-2.39439 -1.29297,-3.22461 -0.86251,-0.86795 -1.93202,-1.30273 -3.20703,-1.30273 z" |
289 | + id="path4116" |
290 | + inkscape:connector-curvature="0" /> |
291 | + <path |
292 | + style="color:#000000;display:inline;overflow:visible;visibility:visible;opacity:1;fill:#df382c;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:8;marker:none;enable-background:accumulate" |
293 | + d="M 45 0 C 45 0 35.356858 16.072266 9.6425781 16.072266 C 9.6425781 70.715115 45 90 45 90 C 45 90 80.357422 70.715115 80.357422 16.072266 C 54.643142 16.072266 45 0 45 0 z M 45 9.4726562 L 45.673828 10.085938 C 46.798488 11.110356 47.985902 12.142591 49.388672 13.144531 C 54.684312 16.927151 62.604557 20.501476 72.935547 21.759766 L 73.869141 21.873047 L 73.814453 22.810547 C 72.519263 44.972167 65.068544 59.989992 57.677734 69.732422 C 52.592794 76.435292 48.497251 79.867214 45.587891 81.976562 L 45 82.402344 L 44.412109 81.976562 C 41.502749 79.867214 37.407206 76.435292 32.322266 69.732422 C 24.931456 59.989992 17.480737 44.972167 16.185547 22.810547 L 16.130859 21.873047 L 17.064453 21.759766 C 27.395443 20.501476 35.315688 16.927151 40.611328 13.144531 C 42.014098 12.142591 43.201512 11.110356 44.326172 10.085938 L 45 9.4726562 z " |
294 | + transform="translate(174,135.36222)" |
295 | + id="path4155" /> |
296 | + </g> |
297 | + </g> |
298 | + </g> |
299 | +</svg> |
300 | |
301 | === added file 'src/ubuntu/images/view-collapse.svg' |
302 | --- src/ubuntu/images/view-collapse.svg 1970-01-01 00:00:00 +0000 |
303 | +++ src/ubuntu/images/view-collapse.svg 2014-10-10 07:47:39 +0000 |
304 | @@ -0,0 +1,163 @@ |
305 | +<?xml version="1.0" encoding="UTF-8" standalone="no"?> |
306 | +<!-- Created with Inkscape (http://www.inkscape.org/) --> |
307 | + |
308 | +<svg |
309 | + xmlns:dc="http://purl.org/dc/elements/1.1/" |
310 | + xmlns:cc="http://creativecommons.org/ns#" |
311 | + xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" |
312 | + xmlns:svg="http://www.w3.org/2000/svg" |
313 | + xmlns="http://www.w3.org/2000/svg" |
314 | + xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd" |
315 | + xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape" |
316 | + width="90" |
317 | + height="90" |
318 | + id="svg4874" |
319 | + version="1.1" |
320 | + inkscape:version="0.48+devel r" |
321 | + viewBox="0 0 90 90.000001" |
322 | + sodipodi:docname="view-collapse.svg"> |
323 | + <defs |
324 | + id="defs4876" /> |
325 | + <sodipodi:namedview |
326 | + id="base" |
327 | + pagecolor="#ffffff" |
328 | + bordercolor="#666666" |
329 | + borderopacity="1.0" |
330 | + inkscape:pageopacity="0.0" |
331 | + inkscape:pageshadow="2" |
332 | + inkscape:zoom="9.9475984" |
333 | + inkscape:cx="9.5249119" |
334 | + inkscape:cy="33.239179" |
335 | + inkscape:document-units="px" |
336 | + inkscape:current-layer="g1726" |
337 | + showgrid="true" |
338 | + showborder="true" |
339 | + fit-margin-top="0" |
340 | + fit-margin-left="0" |
341 | + fit-margin-right="0" |
342 | + fit-margin-bottom="0" |
343 | + inkscape:snap-bbox="true" |
344 | + inkscape:bbox-paths="true" |
345 | + inkscape:bbox-nodes="true" |
346 | + inkscape:snap-bbox-edge-midpoints="true" |
347 | + inkscape:snap-bbox-midpoints="true" |
348 | + inkscape:object-paths="true" |
349 | + inkscape:snap-intersection-paths="true" |
350 | + inkscape:object-nodes="true" |
351 | + inkscape:snap-smooth-nodes="true" |
352 | + inkscape:snap-midpoints="true" |
353 | + inkscape:snap-object-midpoints="true" |
354 | + inkscape:snap-center="true" |
355 | + showguides="true" |
356 | + inkscape:guide-bbox="true"> |
357 | + <inkscape:grid |
358 | + type="xygrid" |
359 | + id="grid5451" |
360 | + empspacing="6" /> |
361 | + <sodipodi:guide |
362 | + orientation="1,0" |
363 | + position="6,77" |
364 | + id="guide4063" /> |
365 | + <sodipodi:guide |
366 | + orientation="1,0" |
367 | + position="3,78" |
368 | + id="guide4065" /> |
369 | + <sodipodi:guide |
370 | + orientation="0,1" |
371 | + position="55,84" |
372 | + id="guide4067" /> |
373 | + <sodipodi:guide |
374 | + orientation="0,1" |
375 | + position="53,87" |
376 | + id="guide4069" /> |
377 | + <sodipodi:guide |
378 | + orientation="0,1" |
379 | + position="20,3" |
380 | + id="guide4071" /> |
381 | + <sodipodi:guide |
382 | + orientation="0,1" |
383 | + position="20,6" |
384 | + id="guide4073" /> |
385 | + <sodipodi:guide |
386 | + orientation="1,0" |
387 | + position="87,7" |
388 | + id="guide4075" /> |
389 | + <sodipodi:guide |
390 | + orientation="1,0" |
391 | + position="84,7" |
392 | + id="guide4077" /> |
393 | + <sodipodi:guide |
394 | + orientation="0,1" |
395 | + position="58,81" |
396 | + id="guide4074" /> |
397 | + <sodipodi:guide |
398 | + orientation="1,0" |
399 | + position="9,74" |
400 | + id="guide4076" /> |
401 | + <sodipodi:guide |
402 | + orientation="0,1" |
403 | + position="21,9" |
404 | + id="guide4078" /> |
405 | + <sodipodi:guide |
406 | + orientation="1,0" |
407 | + position="81,4" |
408 | + id="guide4080" /> |
409 | + </sodipodi:namedview> |
410 | + <metadata |
411 | + id="metadata4879"> |
412 | + <rdf:RDF> |
413 | + <cc:Work |
414 | + rdf:about=""> |
415 | + <dc:format>image/svg+xml</dc:format> |
416 | + <dc:type |
417 | + rdf:resource="http://purl.org/dc/dcmitype/StillImage" /> |
418 | + <dc:title></dc:title> |
419 | + </cc:Work> |
420 | + </rdf:RDF> |
421 | + </metadata> |
422 | + <g |
423 | + inkscape:label="Layer 1" |
424 | + inkscape:groupmode="layer" |
425 | + id="layer1" |
426 | + transform="translate(67.857146,-84.50504)"> |
427 | + <g |
428 | + transform="matrix(0,-1,-1,0,373.50506,516.50504)" |
429 | + id="g4845" |
430 | + style="display:inline"> |
431 | + <g |
432 | + inkscape:label="Layer 1" |
433 | + id="g1724" |
434 | + transform="matrix(0,-1,-1,0,1394.3622,441.36221)" |
435 | + style="display:inline" |
436 | + inkscape:export-filename="search01.png" |
437 | + inkscape:export-xdpi="90" |
438 | + inkscape:export-ydpi="90"> |
439 | + <g |
440 | + transform="matrix(0.99934414,0,0,1,-106.92982,549.00002)" |
441 | + id="g1726" |
442 | + style="display:inline"> |
443 | + <rect |
444 | + style="opacity:0.05;color:#000000;fill:none;stroke:none;stroke-width:2;marker:none;visibility:visible;display:inline;overflow:visible;enable-background:accumulate" |
445 | + id="rect1728" |
446 | + width="90.059067" |
447 | + height="90.000015" |
448 | + x="107" |
449 | + y="-503.36218" |
450 | + transform="scale(1,-1)" /> |
451 | + <path |
452 | + style="color:#000000;display:inline;overflow:visible;visibility:visible;fill:#808080;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:2;marker:none;enable-background:accumulate" |
453 | + d="m 134.01772,455.33488 0,6.0546 36.02363,0 0,-6.0546 z" |
454 | + id="path825" |
455 | + inkscape:connector-curvature="0" |
456 | + sodipodi:nodetypes="ccccc" /> |
457 | + <path |
458 | + inkscape:connector-curvature="0" |
459 | + style="font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:15px;line-height:125%;font-family:Ubuntu;-inkscape-font-specification:Ubuntu;text-align:center;letter-spacing:0px;word-spacing:0px;writing-mode:lr-tb;text-anchor:middle;display:inline;opacity:1;fill:#808080;fill-opacity:1;stroke:none" |
460 | + d="m 142.02297,425.36218 c -12.00787,0 -23.0151,0 -23.0151,21.62695 l 0,22.7461 c 0,21.62695 11.00723,21.62695 23.0151,21.62695 l 20.01312,0 c 12.00788,0 23.01509,0 23.01509,-21.62695 l 0,-22.7461 c 0,-21.62695 -11.00721,-21.62695 -23.01509,-21.62695 z m 1.86841,6 16.27629,0 c 11.87499,0 18.87957,0 18.87957,18.19141 l 0,17.61718 c 0,18.19141 -7.00458,18.19141 -18.87957,18.19141 l -16.27629,0 c -11.87497,0 -18.87957,0 -18.87957,-18.19141 l 0,-17.61718 c 0,-18.19141 7.0046,-18.19141 18.87957,-18.19141 z" |
461 | + id="path4098" |
462 | + sodipodi:nodetypes="ssssssssssssssssss" /> |
463 | + </g> |
464 | + </g> |
465 | + </g> |
466 | + </g> |
467 | +</svg> |
468 | |
469 | === added file 'src/ubuntu/images/view-expand.svg' |
470 | --- src/ubuntu/images/view-expand.svg 1970-01-01 00:00:00 +0000 |
471 | +++ src/ubuntu/images/view-expand.svg 2014-10-10 07:47:39 +0000 |
472 | @@ -0,0 +1,163 @@ |
473 | +<?xml version="1.0" encoding="UTF-8" standalone="no"?> |
474 | +<!-- Created with Inkscape (http://www.inkscape.org/) --> |
475 | + |
476 | +<svg |
477 | + xmlns:dc="http://purl.org/dc/elements/1.1/" |
478 | + xmlns:cc="http://creativecommons.org/ns#" |
479 | + xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" |
480 | + xmlns:svg="http://www.w3.org/2000/svg" |
481 | + xmlns="http://www.w3.org/2000/svg" |
482 | + xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd" |
483 | + xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape" |
484 | + width="90" |
485 | + height="90" |
486 | + id="svg4874" |
487 | + version="1.1" |
488 | + inkscape:version="0.48+devel r" |
489 | + viewBox="0 0 90 90.000001" |
490 | + sodipodi:docname="view-expand.svg"> |
491 | + <defs |
492 | + id="defs4876" /> |
493 | + <sodipodi:namedview |
494 | + id="base" |
495 | + pagecolor="#ffffff" |
496 | + bordercolor="#666666" |
497 | + borderopacity="1.0" |
498 | + inkscape:pageopacity="0.0" |
499 | + inkscape:pageshadow="2" |
500 | + inkscape:zoom="9.9475984" |
501 | + inkscape:cx="9.5249119" |
502 | + inkscape:cy="33.239179" |
503 | + inkscape:document-units="px" |
504 | + inkscape:current-layer="g1726" |
505 | + showgrid="true" |
506 | + showborder="true" |
507 | + fit-margin-top="0" |
508 | + fit-margin-left="0" |
509 | + fit-margin-right="0" |
510 | + fit-margin-bottom="0" |
511 | + inkscape:snap-bbox="true" |
512 | + inkscape:bbox-paths="true" |
513 | + inkscape:bbox-nodes="true" |
514 | + inkscape:snap-bbox-edge-midpoints="true" |
515 | + inkscape:snap-bbox-midpoints="true" |
516 | + inkscape:object-paths="true" |
517 | + inkscape:snap-intersection-paths="true" |
518 | + inkscape:object-nodes="true" |
519 | + inkscape:snap-smooth-nodes="true" |
520 | + inkscape:snap-midpoints="true" |
521 | + inkscape:snap-object-midpoints="true" |
522 | + inkscape:snap-center="true" |
523 | + showguides="true" |
524 | + inkscape:guide-bbox="true"> |
525 | + <inkscape:grid |
526 | + type="xygrid" |
527 | + id="grid5451" |
528 | + empspacing="6" /> |
529 | + <sodipodi:guide |
530 | + orientation="1,0" |
531 | + position="6,77" |
532 | + id="guide4063" /> |
533 | + <sodipodi:guide |
534 | + orientation="1,0" |
535 | + position="3,78" |
536 | + id="guide4065" /> |
537 | + <sodipodi:guide |
538 | + orientation="0,1" |
539 | + position="55,84" |
540 | + id="guide4067" /> |
541 | + <sodipodi:guide |
542 | + orientation="0,1" |
543 | + position="53,87" |
544 | + id="guide4069" /> |
545 | + <sodipodi:guide |
546 | + orientation="0,1" |
547 | + position="20,3" |
548 | + id="guide4071" /> |
549 | + <sodipodi:guide |
550 | + orientation="0,1" |
551 | + position="20,6" |
552 | + id="guide4073" /> |
553 | + <sodipodi:guide |
554 | + orientation="1,0" |
555 | + position="87,7" |
556 | + id="guide4075" /> |
557 | + <sodipodi:guide |
558 | + orientation="1,0" |
559 | + position="84,7" |
560 | + id="guide4077" /> |
561 | + <sodipodi:guide |
562 | + orientation="0,1" |
563 | + position="58,81" |
564 | + id="guide4074" /> |
565 | + <sodipodi:guide |
566 | + orientation="1,0" |
567 | + position="9,74" |
568 | + id="guide4076" /> |
569 | + <sodipodi:guide |
570 | + orientation="0,1" |
571 | + position="21,9" |
572 | + id="guide4078" /> |
573 | + <sodipodi:guide |
574 | + orientation="1,0" |
575 | + position="81,4" |
576 | + id="guide4080" /> |
577 | + </sodipodi:namedview> |
578 | + <metadata |
579 | + id="metadata4879"> |
580 | + <rdf:RDF> |
581 | + <cc:Work |
582 | + rdf:about=""> |
583 | + <dc:format>image/svg+xml</dc:format> |
584 | + <dc:type |
585 | + rdf:resource="http://purl.org/dc/dcmitype/StillImage" /> |
586 | + <dc:title></dc:title> |
587 | + </cc:Work> |
588 | + </rdf:RDF> |
589 | + </metadata> |
590 | + <g |
591 | + inkscape:label="Layer 1" |
592 | + inkscape:groupmode="layer" |
593 | + id="layer1" |
594 | + transform="translate(67.857146,-84.50504)"> |
595 | + <g |
596 | + transform="matrix(0,-1,-1,0,373.50506,516.50504)" |
597 | + id="g4845" |
598 | + style="display:inline"> |
599 | + <g |
600 | + inkscape:label="Layer 1" |
601 | + id="g1724" |
602 | + transform="matrix(0,-1,-1,0,1394.3622,441.36221)" |
603 | + style="display:inline" |
604 | + inkscape:export-filename="search01.png" |
605 | + inkscape:export-xdpi="90" |
606 | + inkscape:export-ydpi="90"> |
607 | + <g |
608 | + transform="matrix(0.99934414,0,0,1,-106.92982,549.00002)" |
609 | + id="g1726" |
610 | + style="display:inline"> |
611 | + <rect |
612 | + style="opacity:0.05;color:#000000;fill:none;stroke:none;stroke-width:2;marker:none;visibility:visible;display:inline;overflow:visible;enable-background:accumulate" |
613 | + id="rect1728" |
614 | + width="90.059067" |
615 | + height="90.000015" |
616 | + x="107" |
617 | + y="-503.36218" |
618 | + transform="scale(1,-1)" /> |
619 | + <path |
620 | + style="color:#000000;display:inline;overflow:visible;visibility:visible;fill:#808080;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:2;marker:none;enable-background:accumulate" |
621 | + d="m 155.05882,440.36218 -6.05857,0 0,14.9727 -14.98253,0 0,6.0546 14.98253,0 0,14.9727 6.05857,0 0,-14.9727 14.98253,0 0,-6.0546 -14.98253,0 z" |
622 | + id="path825" |
623 | + inkscape:connector-curvature="0" |
624 | + sodipodi:nodetypes="ccccccccccccc" /> |
625 | + <path |
626 | + inkscape:connector-curvature="0" |
627 | + style="font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:15px;line-height:125%;font-family:Ubuntu;-inkscape-font-specification:Ubuntu;text-align:center;letter-spacing:0px;word-spacing:0px;writing-mode:lr-tb;text-anchor:middle;display:inline;opacity:1;fill:#808080;fill-opacity:1;stroke:none" |
628 | + d="m 142.02297,425.36218 c -12.00787,0 -23.0151,0 -23.0151,21.62695 l 0,22.7461 c 0,21.62695 11.00723,21.62695 23.0151,21.62695 l 20.01312,0 c 12.00788,0 23.01509,0 23.01509,-21.62695 l 0,-22.7461 c 0,-21.62695 -11.00721,-21.62695 -23.01509,-21.62695 z m 1.86841,6 16.27629,0 c 11.87499,0 18.87957,0 18.87957,18.19141 l 0,17.61718 c 0,18.19141 -7.00458,18.19141 -18.87957,18.19141 l -16.27629,0 c -11.87497,0 -18.87957,0 -18.87957,-18.19141 l 0,-17.61718 c 0,-18.19141 7.0046,-18.19141 18.87957,-18.19141 z" |
629 | + id="path4098" |
630 | + sodipodi:nodetypes="ssssssssssssssssss" /> |
631 | + </g> |
632 | + </g> |
633 | + </g> |
634 | + </g> |
635 | +</svg> |
636 | |
637 | === modified file 'src/ubuntu/resources.qrc' |
638 | --- src/ubuntu/resources.qrc 2014-08-11 11:58:08 +0000 |
639 | +++ src/ubuntu/resources.qrc 2014-10-10 07:47:39 +0000 |
640 | @@ -19,5 +19,8 @@ |
641 | <file>images/reload.svg</file> |
642 | <file>images/list-add.svg</file> |
643 | <file>images/list-remove.svg</file> |
644 | + <file>images/security-alert.svg</file> |
645 | + <file>images/view-expand.svg</file> |
646 | + <file>images/view-collapse.svg</file> |
647 | </qresource> |
648 | </RCC> |
649 | |
650 | === modified file 'src/ubuntu/ubuntueditorfactory.cpp' |
651 | --- src/ubuntu/ubuntueditorfactory.cpp 2014-08-18 12:29:43 +0000 |
652 | +++ src/ubuntu/ubuntueditorfactory.cpp 2014-10-10 07:47:39 +0000 |
653 | @@ -13,8 +13,8 @@ |
654 | class UbuntuTextEditorActionHandler : public TextEditor::TextEditorActionHandler |
655 | { |
656 | public: |
657 | - explicit UbuntuTextEditorActionHandler(QObject *parent) |
658 | - : TextEditorActionHandler(parent, Constants::UBUNTU_MANIFEST_EDITOR_CONTEXT) |
659 | + explicit UbuntuTextEditorActionHandler(QObject *parent, Core::Id editorContext) |
660 | + : TextEditorActionHandler(parent,editorContext) |
661 | {} |
662 | private: |
663 | TextEditor::BaseTextEditorWidget *resolveTextEditorWidget(Core::IEditor *editor) const |
664 | @@ -29,7 +29,7 @@ |
665 | setId(Constants::UBUNTU_MANIFEST_EDITOR_ID); |
666 | setDisplayName(tr("Ubuntu Manifest editor")); |
667 | addMimeType(Constants::UBUNTU_MANIFEST_MIME_TYPE); |
668 | - new UbuntuTextEditorActionHandler(this); |
669 | + new UbuntuTextEditorActionHandler(this,Constants::UBUNTU_MANIFEST_EDITOR_ID); |
670 | } |
671 | |
672 | Core::IEditor *UbuntuManifestEditorFactory::createEditor() |
673 | @@ -42,7 +42,7 @@ |
674 | setId(Constants::UBUNTU_APPARMOR_EDITOR_ID); |
675 | setDisplayName(tr("Ubuntu Apparmor editor")); |
676 | addMimeType(Constants::UBUNTU_APPARMOR_MIME_TYPE); |
677 | - new UbuntuTextEditorActionHandler(this); |
678 | + new UbuntuTextEditorActionHandler(this,Constants::UBUNTU_APPARMOR_EDITOR_ID); |
679 | } |
680 | |
681 | Core::IEditor *UbuntuApparmorEditorFactory::createEditor() |
PASSED: Continuous integration, rev:285 jenkins. qa.ubuntu. com/job/ qtcreator- plugin- ubuntu- ci/446/ jenkins. qa.ubuntu. com/job/ qtcreator- plugin- ubuntu- utopic- amd64-ci/ 214 jenkins. qa.ubuntu. com/job/ qtcreator- plugin- ubuntu- utopic- armhf-ci/ 214
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/qtcreator- plugin- ubuntu- ci/446/ rebuild
http://