Merge lp:~zeller-benjamin/qtcreator-plugin-ubuntu/moresimple into lp:qtcreator-plugin-ubuntu

Proposed by Benjamin Zeller
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 269
Merged at revision: 270
Proposed branch: lp:~zeller-benjamin/qtcreator-plugin-ubuntu/moresimple
Merge into: lp:qtcreator-plugin-ubuntu
Diff against target: 64 lines (+2/-18)
4 files modified
share/qtcreator/templates/wizards/ubuntu/simple/components/HelloComponent.qml (+0/-14)
share/qtcreator/templates/wizards/ubuntu/simple/main.qml (+1/-2)
share/qtcreator/templates/wizards/ubuntu/simple/tests/autopilot/displayName/__init__.py (+1/-1)
share/qtcreator/templates/wizards/ubuntu/simple/wizard.xml (+0/-1)
To merge this branch: bzr merge lp:~zeller-benjamin/qtcreator-plugin-ubuntu/moresimple
Reviewer Review Type Date Requested Status
Zoltan Balogh Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+234705@code.launchpad.net

Commit message

- Make the simple template, really simple
- make sure autopilot tests work again

Description of the change

Make the simple template, really simple and make sure autopilot tests work again

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Zoltan Balogh (bzoltan) wrote :

OK

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed directory 'share/qtcreator/templates/wizards/ubuntu/simple/components'
2=== removed file 'share/qtcreator/templates/wizards/ubuntu/simple/components/HelloComponent.qml'
3--- share/qtcreator/templates/wizards/ubuntu/simple/components/HelloComponent.qml 2014-08-21 10:23:21 +0000
4+++ share/qtcreator/templates/wizards/ubuntu/simple/components/HelloComponent.qml 1970-01-01 00:00:00 +0000
5@@ -1,14 +0,0 @@
6-import QtQuick 2.0
7-import Ubuntu.Components 1.1
8-
9-UbuntuShape {
10- width: 200
11- height: width
12-
13- property alias text : myText.text
14-
15- Label {
16- id: myText
17- anchors.centerIn: parent
18- }
19-}
20
21=== modified file 'share/qtcreator/templates/wizards/ubuntu/simple/main.qml'
22--- share/qtcreator/templates/wizards/ubuntu/simple/main.qml 2014-09-03 11:49:49 +0000
23+++ share/qtcreator/templates/wizards/ubuntu/simple/main.qml 2014-09-15 15:44:35 +0000
24@@ -1,6 +1,5 @@
25 import QtQuick 2.0
26 import Ubuntu.Components 1.1
27-import "components"
28
29 /*!
30 \brief MainView with a Label and Button elements.
31@@ -35,7 +34,7 @@
32 fill: parent
33 }
34
35- HelloComponent {
36+ Label {
37 id: label
38 objectName: "label"
39
40
41=== modified file 'share/qtcreator/templates/wizards/ubuntu/simple/tests/autopilot/displayName/__init__.py'
42--- share/qtcreator/templates/wizards/ubuntu/simple/tests/autopilot/displayName/__init__.py 2014-06-30 15:20:18 +0000
43+++ share/qtcreator/templates/wizards/ubuntu/simple/tests/autopilot/displayName/__init__.py 2014-09-15 15:44:35 +0000
44@@ -55,7 +55,7 @@
45 "only run from source.")
46
47 def _get_app_qml_source_path(self):
48- qml_file_name = '{0}.qml'.format(self.app_name)
49+ qml_file_name = 'main.qml'
50 return os.path.join(self._get_path_to_app_source(), qml_file_name)
51
52 def _get_path_to_app_source(self):
53
54=== modified file 'share/qtcreator/templates/wizards/ubuntu/simple/wizard.xml'
55--- share/qtcreator/templates/wizards/ubuntu/simple/wizard.xml 2014-09-12 08:39:29 +0000
56+++ share/qtcreator/templates/wizards/ubuntu/simple/wizard.xml 2014-09-15 15:44:35 +0000
57@@ -14,7 +14,6 @@
58 <files>
59 <file source="../share/manifest.json" target="manifest.json" openeditor="true"/>
60 <file source="../share/displayName.qmlproject" target="%ProjectName%.qmlproject" openproject="true"/>
61- <file source="components/HelloComponent.qml" target="components/HelloComponent.qml" openeditor="false"/>
62 <file source="main.qml" target="main.qml" openeditor="true"/>
63 <file source="displayName.png" target="%ProjectName%.png" openeditor="false" binary="true"/>
64 <file source="displayName.desktop" target="%ClickHookName%.desktop" openeditor="false"/>

Subscribers

People subscribed via source and target branches