qtcreator-plugin-ubuntu

Merge lp:~zeller-benjamin/qtcreator-plugin-ubuntu/fixreview into lp:qtcreator-plugin-ubuntu

  1. fixreview
  2. Merge into trunk
Proposed by Benjamin Zeller
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 210
Merged at revision: 214
Proposed branch: lp:~zeller-benjamin/qtcreator-plugin-ubuntu/fixreview
Merge into: lp:qtcreator-plugin-ubuntu
Diff against target: 12 lines (+1/-1)
1 file modified
src/ubuntu/ubuntuconstants.h (+1/-1)
To merge this branch: bzr merge lp:~zeller-benjamin/qtcreator-plugin-ubuntu/fixreview
Reviewer Review Type Date Requested Status
Zoltan Balogh Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+226963@code.launchpad.net

Commit message

Fix execution of click review tools to handle package names with spaces correctly

Description of the change

Fix execution of click review tools to handle package names with spaces correctly

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:210
http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-ci/341/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-utopic-amd64-ci/109
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-utopic-armhf-ci/109

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtcreator-plugin-ubuntu-ci/341/rebuild

review: Approve (continuous-integration)
Revision history for this message
Zoltan Balogh (bzoltan) wrote :

OK

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/ubuntu/ubuntuconstants.h'
2--- src/ubuntu/ubuntuconstants.h 2014-06-11 13:50:09 +0000
3+++ src/ubuntu/ubuntuconstants.h 2014-07-16 06:20:52 +0000
4@@ -440,7 +440,7 @@
5 const char SETTINGS_KEY_CLICK_REVIEWERSTOOLS_LOCATION[] = "ReviewersToolsLocation";
6 const bool SETTINGS_DEFAULT_CLICK_REVIEWERSTOOLS = false;
7 const bool SETTINGS_CLICK_REVIEWERSTOOLS_TRUE = true;
8-const char SETTINGS_DEFAULT_CLICK_REVIEWERSTOOLS_LOCATION[] = "/usr/bin/click-run-checks %0";
9+const char SETTINGS_DEFAULT_CLICK_REVIEWERSTOOLS_LOCATION[] = "/usr/bin/click-run-checks \"%0\"";
10 const char UBUNTUSETTINGSCLICKWIDGET_FILEDIALOG[] = "Location of click-reviewers-tools";
11
12 //build configuration

Subscribers

People subscribed via source and target branches