Merge lp:~zekus-one/byobu/trunk into lp:byobu

Proposed by zekus
Status: Merged
Merged at revision: 1993
Proposed branch: lp:~zekus-one/byobu/trunk
Merge into: lp:byobu
Diff against target: 13 lines (+1/-2)
1 file modified
usr/bin/byobu-status (+1/-2)
To merge this branch: bzr merge lp:~zekus-one/byobu/trunk
Reviewer Review Type Date Requested Status
Dustin Kirkland  Pending
Review via email: mp+142018@code.launchpad.net

Description of the change

Hi,

this small change fixes Bug #1073145 but also Bug #1018538 that was very much annoying me. Now I can finally select text and copy paste using iTerm2 and byobu-tmux. The friends using Konsole in KDE will also benefit from it.

As this is the first time I contribute to a Launchpad project, I hope I have done it correctly :)

Thanks
Antonio

To post a comment you must log in.
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

On Sat, Jan 5, 2013 at 12:11 PM, zekus <email address hidden> wrote:
> zekus has proposed merging lp:~zekus-one/byobu/trunk into lp:byobu.
>
> Requested reviews:
> Dustin Kirkland (kirkland)
>
> For more details, see:
> https://code.launchpad.net/~zekus-one/byobu/trunk/+merge/142018
>
> Hi,
>
> this small change fixes Bug #1073145 but also Bug #1018538 that was very much annoying me. Now I can finally select text and copy paste using iTerm2 and byobu-tmux. The friends using Konsole in KDE will also benefit from it.

Excellent!

> As this is the first time I contribute to a Launchpad project, I hope I have done it correctly :)
>
> Thanks
> Antonio

You did it perfectly ;-) Thank you!

> --
> https://code.launchpad.net/~zekus-one/byobu/trunk/+merge/142018
> You are requested to review the proposed merge of lp:~zekus-one/byobu/trunk into lp:byobu.
>
> === modified file 'usr/bin/byobu-status'
> --- usr/bin/byobu-status 2012-06-24 20:05:52 +0000
> +++ usr/bin/byobu-status 2013-01-05 18:10:27 +0000
> @@ -37,8 +37,7 @@
>
> # Fix status printing for small terminal sizes
> width=$(tmux list-windows -F "#{session_width}")
> -w_last=0
> -[ -r "$BYOBU_RUN_DIR/width" ] && read w_last < $BYOBU_RUN_DIR/width 2>/dev/null 1>&2 || w_last=0
> +if [ -r "$BYOBU_RUN_DIR/width" ]; then read w_last < $BYOBU_RUN_DIR/width 2>/dev/null 1>&2; else w_last=0; fi
> for w in $width; do
> if [ "$w" != "$w_last" ]; then
> tmux set -g status-left-length $(($w*1/4)) >/dev/null 2>&1
>
>

--
:-Dustin

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'usr/bin/byobu-status'
2--- usr/bin/byobu-status 2012-06-24 20:05:52 +0000
3+++ usr/bin/byobu-status 2013-01-05 18:10:27 +0000
4@@ -37,8 +37,7 @@
5
6 # Fix status printing for small terminal sizes
7 width=$(tmux list-windows -F "#{session_width}")
8-w_last=0
9-[ -r "$BYOBU_RUN_DIR/width" ] && read w_last < $BYOBU_RUN_DIR/width 2>/dev/null 1>&2 || w_last=0
10+if [ -r "$BYOBU_RUN_DIR/width" ]; then read w_last < $BYOBU_RUN_DIR/width 2>/dev/null 1>&2; else w_last=0; fi
11 for w in $width; do
12 if [ "$w" != "$w_last" ]; then
13 tmux set -g status-left-length $(($w*1/4)) >/dev/null 2>&1

Subscribers

People subscribed via source and target branches