Merge lp:~zeitgeist/zeitgeist/fix-909708 into lp:~zeitgeist/zeitgeist/bluebird
Proposed by
Seif Lotfy
Status: | Merged |
---|---|
Merge reported by: | Seif Lotfy |
Merged at revision: | not available |
Proposed branch: | lp:~zeitgeist/zeitgeist/fix-909708 |
Merge into: | lp:~zeitgeist/zeitgeist/bluebird |
Diff against target: |
39 lines (+11/-0) 2 files modified
src/engine.vala (+10/-0) test/dbus/remote-test.py (+1/-0) |
To merge this branch: | bzr merge lp:~zeitgeist/zeitgeist/fix-909708 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Siegfried Gevatter | Approve | ||
Review via email: mp+87228@code.launchpad.net |
Description of the change
This branch fixes the issue where inserting and event with 2 subjects.
Since we already parse the subjects before insertion I added a list with subj_uris to find if there is a duplicate and return 0 if one is found
To post a comment you must log in.
- Why do you use a List? Make that a SList. Even better, we know how many subjects there are so we can just use a fixed size array or something.
- Fix the formatting: "null) {", ".append(s".
- A comment before the "return 0" explaining what happened would be nice ("// Events with two subjects with the same URI are not supported."). Also, return a warning so people will notice they're doing it wrong.