Merge lp:~zctgbhu/plymouth/bug-1339954 into lp:ubuntu/utopic/plymouth

Proposed by zhangchao
Status: Needs review
Proposed branch: lp:~zctgbhu/plymouth/bug-1339954
Merge into: lp:ubuntu/utopic/plymouth
Diff against target: 40 lines (+9/-0)
3 files modified
debian/changelog (+6/-0)
debian/control (+1/-0)
debian/initramfs-tools/hooks/plymouth (+2/-0)
To merge this branch: bzr merge lp:~zctgbhu/plymouth/bug-1339954
Reviewer Review Type Date Requested Status
Michael Vogt (community) Needs Information
Review via email: mp+226236@code.launchpad.net

Description of the change

Add A font file to initramfs to support Chinese display (LP: #1339954)

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for this branch! While it will certainly solve the issue I am a bit concerned about the addition of this ttf file to the initrd. Its ~4.4Mb on my system, compared to the current dejavu font that is only ~700kb. I understand that the reason for the small current file is probably that it lacks a lot of glyphs. So I wonder if a) there is a smaller (and still good quality) font package b) if we can stop installing the current dejavu ttf file.

Thanks again for this branch!
 Michael

review: Needs Information
Revision history for this message
zhangchao (zctgbhu) wrote :

> a) there is a smaller (and still good quality) font package
I didn't find smaller font,in the fonts that full support for Chinese.

> b) if we can stop installing the current dejavu ttf file.
I simply compared the glyphs of dejavu and DroidSanFallback,DroidSanFallback is missing a lot of Latin glyphs than dejavu. So I think dejavu ttf still must be installed.

Revision history for this message
zhangchao (zctgbhu) wrote :

> a) there is a smaller (and still good quality) font package
I didn't find smaller font,in the fonts that full support for Chinese.

> b) if we can stop installing the current dejavu ttf file.
I simply compared the glyphs of dejavu and DroidSanFallback,DroidSanFallback is missing a lot of Latin glyphs than dejavu. So I think dejavu ttf still must be installed.

Revision history for this message
V字龍(Vdragon) (vdragon) wrote :

AFAICS we should drop the dejavu font as long as there's no glyphs required for other locale's basic usage, since it just a boot-up screen anyway.

BTW, is Google Noto Sans font a better choice? It divides many different locale glyphs into separate font files.
https://code.google.com/p/noto/

Revision history for this message
V字龍(Vdragon) (vdragon) wrote :

Hi, I heard a better idea to deal with it from local community, maybe we should install font according to system's default locale instead of pack all the glyphs in initramfs.

Unmerged revisions

1472. By zhangchao

debian/initramfs-tools/hooks/plymouth: Add A font file to initramfs to support Chinese display (LP: #1339954)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-04-11 16:01:55 +0000
3+++ debian/changelog 2014-07-10 01:56:20 +0000
4@@ -1,3 +1,9 @@
5+plymouth (0.8.8-0ubuntu18) trusty; urgency=medium
6+
7+ * Add A font file to initramfs to support Chinese display (LP: #1339954)
8+
9+ -- zhangchao <zhangchao@ubuntukylin.com> Thu, 10 Jul 2014 09:43:30 +0800
10+
11 plymouth (0.8.8-0ubuntu17) trusty; urgency=medium
12
13 * Suppress job-name update notifications to plymouthd from
14
15=== modified file 'debian/control'
16--- debian/control 2014-03-13 21:35:54 +0000
17+++ debian/control 2014-07-10 01:56:20 +0000
18@@ -59,6 +59,7 @@
19 Depends: libplymouth2 (= ${binary:Version}),
20 plymouth (= ${binary:Version}),
21 fonts-dejavu-core,
22+ fonts-droid,
23 ${misc:Depends},
24 ${shlibs:Depends}
25 Replaces: plymouth (<< 0.8.1-4)
26
27=== modified file 'debian/initramfs-tools/hooks/plymouth'
28--- debian/initramfs-tools/hooks/plymouth 2013-12-20 06:29:17 +0000
29+++ debian/initramfs-tools/hooks/plymouth 2014-07-10 01:56:20 +0000
30@@ -70,8 +70,10 @@
31 # and copy the font support files needed in order to actually display
32 # any text
33 mkdir -p ${DESTDIR}/usr/share/fonts/truetype/dejavu
34+ mkdir -p ${DESTDIR}/usr/share/fonts/truetype/droid
35 mkdir -p ${DESTDIR}/etc/fonts/conf.d
36 cp /usr/share/fonts/truetype/dejavu/DejaVuSans.ttf ${DESTDIR}/usr/share/fonts/truetype/dejavu/
37+ cp /usr/share/fonts/truetype/droid/DroidSansFallbackFull.ttf ${DESTDIR}/usr/share/fonts/truetype/droid/
38 cp /etc/fonts/fonts.conf ${DESTDIR}/etc/fonts/fonts.conf
39 cp -L /etc/fonts/conf.d/60-latin.conf ${DESTDIR}/etc/fonts/conf.d
40 fi

Subscribers

People subscribed via source and target branches

to all changes: