Merge lp:~zaspire/unity-webapps-linkedin/new-design into lp:unity-webapps-linkedin

[Maxim Ermilov]

LinkedIn has been redesigned and the userscript needs fixing.

LinkedIn has been redesigned and fix the userscript accordingly.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:46
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~zaspire/unity-webapps-linkedin/new-design/+merge/168115/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-webapps-linkedin-ci/1/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-linkedin-saucy-amd64-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-linkedin-saucy-armhf-ci/1/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-linkedin-ci/1/rebuild

review: Needs Fixing (continuous-integration)

[Alexandre Abreu (abreu-alexandre)]

Good, it even simplifies the whole dependancies over the website's structure.

review: Approve

=== modified file 'LinkedIn.test.js'
--- LinkedIn.test.js	2013-04-30 20:41:39 +0000
+++ LinkedIn.test.js	2013-06-07 16:02:35 +0000
@@ -31,15 +31,6 @@
 
         // at least one
         assertEquals('Unity.addAction', log[3].func, 'Unity.addAction');
-
-        // validate self test results
-        var found = false, i;
-        for (i = 0; i < out.length; i++) {
-            if (out[i] === 'PASS SELF TEST') {
-                found = true;
-            }
-        }
-        assertTrue('PASS SELF TEST', found);
     },
 
     scriptName: 'LinkedIn.user.js'

=== modified file 'LinkedIn.user.js'
--- LinkedIn.user.js	2013-05-01 22:46:29 +0000
+++ LinkedIn.user.js	2013-06-07 16:02:35 +0000
@@ -11,26 +11,6 @@
 
 window.Unity = external.getUnityObject(1);
 
-/**
- * User script self validation
- *
- * Called by the testing framework to make sure that
- * the page layout seems ok.
- */
-function selfTest() {
-    if (!getComposeNewMessageClickTargetNode()) {
-        return;
-    }
-
-    // We are done
-    reportTestState('PASS SELF TEST');
-}
-
-function getComposeNewMessageClickTargetNode() {
-    return document.evaluate('//li[@id="nav-primary-inbox"]/ul/li[3]/a',
-                             document, null, XPathResult.ANY_UNORDERED_NODE_TYPE, null).singleNodeValue;
-};
-
 function isCorrectPage() {
     var i, ids = ['header'];
 
@@ -60,7 +40,7 @@
 
     for (i = 0; i < snapshot.snapshotLength; i++) {
         var node = snapshot.snapshotItem(i);
-        var text = node.getElementsByTagName('a')[0].getElementsByTagName('span')[0].textContent;
+        var text = trim(node.getElementsByTagName('a')[0].textContent);
         var link = node.getElementsByTagName('a')[0].href;
 
         console.log(text);
@@ -84,12 +64,8 @@
     }
     var indicatorsController = new Indicators(checkMessagesCount);
 
-    function composeNewMessage() {
-        var node = getComposeNewMessageClickTargetNode();
-        launchClickEvent(node);
-    }
     Unity.Launcher.addAction(_("Compose New Message"),
-                             wrapCallback(composeNewMessage));
+                             makeRedirector("http://www.linkedin.com/msgToConns?displayCreate="));
 
     doMatrixIntegration();