Merge lp:~zarnimng/pantheon-files/fix-1617035-remove-preview-tab into lp:~elementary-apps/pantheon-files/trunk

[Zarni Wang]

Remove "Preview" pane in the properties window

[Zisu Andrei (matzipan)]

Hey Zarni,

That was quick. Maybe it's also worth removing the PREVIEW field in the PanelType enum in src/View/AbstractPropertiesDialog.vala

review: Needs Fixing

[lp:~zarnimng/pantheon-files/fix-1617035-remove-preview-tab]

2299. By Zarni Wang on 2016-08-25

Removes PanelType.PREVIEW

=== modified file 'src/View/AbstractPropertiesDialog.vala'
--- src/View/AbstractPropertiesDialog.vala	2016-07-03 17:40:02 +0000
+++ src/View/AbstractPropertiesDialog.vala	2016-08-25 20:51:33 +0000
@@ -31,8 +31,7 @@
 
     protected enum PanelType {
         INFO,
-        PERMISSIONS,
-        PREVIEW
+        PERMISSIONS
     }
 
     public AbstractPropertiesDialog (string _title, Gtk.Window parent) {

=== modified file 'src/View/PropertiesWindow.vala'
--- src/View/PropertiesWindow.vala	2016-07-03 17:40:02 +0000
+++ src/View/PropertiesWindow.vala	2016-08-25 20:51:33 +0000
@@ -23,7 +23,6 @@
 namespace Marlin.View {
 
 public class PropertiesWindow : AbstractPropertiesDialog {
-    private Granite.Widgets.ImgEventBox evbox;
     private Granite.Widgets.XsEntry perm_code;
     private bool perm_code_should_update = true;
     private Gtk.Label l_perm;
@@ -207,28 +206,6 @@
             }
         }
 
-        /* Preview */
-        if (count == 1 && goffile.flags != 0) {
-            /* Retrieve the low quality (existent) thumbnail.
-             * This will be shown to prevent resizing the properties window
-             * when the large preview is retrieved.
-             */
-            Gdk.Pixbuf small_preview;
-
-            if (view.is_in_recent ()) {
-                small_preview = goffile.get_icon_pixbuf (256, true, GOF.FileIconFlags.NONE);
-            } else {
-                small_preview = goffile.get_icon_pixbuf (256, true, GOF.FileIconFlags.USE_THUMBNAILS);
-            }
-
-            /* Request the creation of the large thumbnail */
-            Marlin.Thumbnailer.get ().queue_file (goffile, null, /* LARGE */ true);
-            var preview_box = new Gtk.Box (Gtk.Orientation.VERTICAL, 0);
-
-            construct_preview_panel (preview_box, small_preview);
-            add_section (stack, _("Preview"), PanelType.PREVIEW.to_string (), preview_box);
-        }
-
         show_all ();
         update_widgets_state ();
     }
@@ -1167,24 +1144,6 @@
         return choice;
     }
 
-    private void construct_preview_panel (Gtk.Box box, Gdk.Pixbuf? small_preview) {
-        evbox = new Granite.Widgets.ImgEventBox (Gtk.Orientation.HORIZONTAL);
-        if (small_preview != null)
-            evbox.set_from_pixbuf (small_preview);
-        box.pack_start (evbox, false, true, 0);
-
-        goffile.icon_changed.connect (() => {
-            var large_preview_path = goffile.get_preview_path ();
-            if (large_preview_path != null)
-                try {
-                    var large_preview = new Gdk.Pixbuf.from_file (large_preview_path);
-                    evbox.set_from_pixbuf (large_preview);
-                } catch (Error e) {
-                    warning (e.message);
-                }
-        });
-    }
-
     private Icon ensure_icon (AppInfo app) {
         Icon icon = app.get_icon ();
         if (icon == null)