Merge lp:~yuningdodo/usb-creator/usb-creator.lp978691v2-select-readded-source into lp:usb-creator

Proposed by Yu Ning
Status: Merged
Merged at revision: 465
Proposed branch: lp:~yuningdodo/usb-creator/usb-creator.lp978691v2-select-readded-source
Merge into: lp:usb-creator
Diff against target: 27 lines (+11/-0)
1 file modified
usbcreator/frontends/gtk/frontend.py (+11/-0)
To merge this branch: bzr merge lp:~yuningdodo/usb-creator/usb-creator.lp978691v2-select-readded-source
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Pending
usb-creator hackers Pending
Review via email: mp+252082@code.launchpad.net

Description of the change

For gtk frontend. If a source is re-added we should select it; always scroll to the selected source.

The scrolling doesn't work with unity, however it works fine with openbox.

To post a comment you must log in.
Revision history for this message
Yu Ning (yuningdodo) wrote :

FYI, this patch is basically based on a previous patch for utopic:
https://code.launchpad.net/~yuningdodo/usb-creator/usb-creator.lp978691-select-readded-source/+merge/238286

I have tested it with the vivid daily image (20150306), it works as expected except the scrolling.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'usbcreator/frontends/gtk/frontend.py'
2--- usbcreator/frontends/gtk/frontend.py 2014-07-25 11:40:08 +0000
3+++ usbcreator/frontends/gtk/frontend.py 2015-03-06 11:06:40 +0000
4@@ -633,6 +633,16 @@
5 if response == Gtk.ResponseType.OK:
6 filename = chooser.get_filename()
7 chooser.destroy()
8+ treeview = self.source_treeview
9+ model = treeview.get_model()
10+ iterator = model.get_iter_first()
11+ while iterator is not None:
12+ if model.get_value(iterator, 0) == filename:
13+ path = model.get_path(iterator)
14+ treeview.set_cursor(path, None, False)
15+ treeview.scroll_to_cell(path)
16+ return
17+ iterator = model.iter_next(iterator)
18 self.backend.add_image(filename)
19 elif response == Gtk.ResponseType.CANCEL:
20 chooser.destroy()
21@@ -815,5 +825,6 @@
22 new_iter = model.append(new_row)
23 if force_selection or (treeview.get_selection().get_selected()[1] is None):
24 treeview.set_cursor(model.get_path(new_iter), None, False)
25+ treeview.scroll_to_cell(model.get_path(new_iter))
26
27 # vim: set ai et sts=4 tabstop=4 sw=4:

Subscribers

People subscribed via source and target branches

to all changes: