Merge lp:~yuningdodo/usb-creator/usb-creator.lp1413494-auto-mount-after-format into lp:usb-creator

[Yu Ning]

I checked the source code and found usb-creator can only calculate the free space for a mounted partition, however the newly formated partition isn't mounted.

So to fix the issue we could mount it automatically after the formating. In the attached patch this job is done in the dbus method Format() in usb-creator-helper. In my own test it works fine.

[Yu Ning (yuningdodo)]

One problem for this patch is it will mount the new partition as root, so the normal user can not unmount it.

I have proposed another patch to mount the new partition as the normal user:
https://code.launchpad.net/~yuningdodo/usb-creator/usb-creator.lp1413494v2-update-free-space-after-format/+merge/250258

Anyway, I think below change is still needed, although it's a different issue:

8 - unmount_all(udisks, dev)
9 + unmount_all(udisks, parent_dev)

[Mathieu Trudel-Lapierre (cyphermox)]

In this case, could you please either update this request appropriately to only keep that change, or provide it in a new merge proposal (along with a bug link if possible?)

Which bug would the umount_all change fix?

review: Needs Fixing

[Yu Ning (yuningdodo)]

Mathieu, thanks for the review. I checked the code again, looks like I had a misunderstanding about the umount_all() function, we shouldn't change the argument from dev to parent_dev. Please help to reject this merge proposal.

review: Disapprove

Unmerged revisions

463. By Yu Ning on 2015-02-19

* auto mount the new partition to calc free space correctly. (LP: #1413494)

=== modified file 'bin/usb-creator-helper'
--- bin/usb-creator-helper	2014-09-02 20:12:12 +0000
+++ bin/usb-creator-helper	2015-02-19 05:17:59 +0000
@@ -231,7 +231,7 @@
             check_system_internal(dev)
 
         # TODO LOCK
-        unmount_all(udisks, dev)
+        unmount_all(udisks, parent_dev)
         # Do NOT use the disk if asked to format a partition.
         # We still need to obtain the disk device name to zero out the MBR
         part = dev.get_partition()
@@ -243,6 +243,9 @@
             part.call_set_type_sync('0x0c', no_options, None)
             part.call_set_flags_sync(boot_dos_flag, no_options, None)
             block.call_format_sync('vfat', GLib.Variant('a{sv}', {'label': GLib.Variant('s', '')}), None)
+
+            # Mount the partition for the frontend to calc free space
+            dev.get_filesystem().call_mount_sync(no_options, None)
         else:
             # Create a new partition table and a FAT partition.
             # Is this correct call to create partition table ?!
@@ -262,6 +265,11 @@
             block = obj.get_block()
             block.call_format_sync('vfat', GLib.Variant('a{sv}', {'label': GLib.Variant('s', '')}), None)
 
+            # Mount the partition for the frontend to calc free space
+            udisks = UDisks.Client.new_sync(None)
+            obj = udisks.get_object(partition)
+            obj.get_filesystem().call_mount_sync(no_options, None)
+
         # Zero out the MBR.  Will require fancy privileges.
         parent_block = parent_dev.get_block()
         parent_file = parent_block.get_cached_property('Device').get_bytestring().decode('utf-8')