Merge lp:~yuningdodo/usb-creator/usb-creator.lp1273925+lp1289269 into lp:usb-creator

[Yu Ning]

* GTK: Handle the backend.format_ended_cb callback otherwise the erasing operation will never ended. (LP: #1289269) (LP: #1273925)

[David Henningsson (diwic)]

Thanks for the patch!

With this version, the problem has changed.

No longer do we wait indefinitely for the "erasing" button do become clear, but when it is finished, the amount of free space is reported as "0.0 B", and you still can't continue to the next step (i e create the USB disk), because the "create startup disk" button is grayed out.

[Yu Ning (yuningdodo)]

That’s weird, I’ll check it tomorrow. Thanks for testing it.

[Yu Ning (yuningdodo)]

I re-checked it, even with usb-creator-kde the free space is also considered as zero after "erase disk". I believe it's a different issue.

By the way, during my experiment I noticed that if we manually zeroed the disk (dd if=/dev/zero of=/dev/sdb bs=1M count=1) then usb-creator will report an error whilte erasing it.

=== modified file 'debian/changelog'
--- debian/changelog	2014-03-13 11:56:48 +0000
+++ debian/changelog	2014-03-18 09:37:48 +0000
@@ -1,3 +1,10 @@
+usb-creator (0.2.56) UNRELEASED; urgency=low
+
+  * GTK: Handle the backend.format_ended_cb callback otherwise the erasing
+         operation will never ended. (LP: #1289269) (LP: #1273925)
+
+ -- Yu Ning <[e-mail]>  Tue, 18 Mar 2014 17:30:09 +0800
+
 usb-creator (0.2.55) trusty; urgency=medium
 
   * KDE: Don't crash when started with --iso. The hiding logic tried to access

=== modified file 'usbcreator/frontends/gtk/frontend.py'
--- usbcreator/frontends/gtk/frontend.py	2013-01-28 12:44:46 +0000
+++ usbcreator/frontends/gtk/frontend.py	2014-03-18 09:37:48 +0000
@@ -122,6 +122,7 @@
         self.backend.install_progress_pulse_stop_cb = self.progress_pulse_stop
         self.backend.retry_cb = self.retry
         self.backend.target_changed_cb = self.update_target
+        self.backend.format_ended_cb = self.format_ended
         self.backend.format_failed_cb = self.format_failed
 
         # Pulse state.
@@ -476,6 +477,10 @@
             msg = ''
         self.dest_status.set_text(msg)
 
+    def format_ended(self):
+        selection = self.dest_treeview.get_selection()
+        self.selection_changed_target(selection)
+
     def selection_changed_source(self, selection):
         model, iterator = selection.get_selected()
         if not iterator: