Merge lp:~yuningdodo/usb-creator/usb-creator.lp1273925+lp1289269 into lp:usb-creator

Proposed by Yu Ning on 2014-03-18
Status: Merged
Merged at revision: 436
Proposed branch: lp:~yuningdodo/usb-creator/usb-creator.lp1273925+lp1289269
Merge into: lp:usb-creator
Diff against target: 37 lines (+12/-0)
2 files modified
debian/changelog (+7/-0)
usbcreator/frontends/gtk/frontend.py (+5/-0)
To merge this branch: bzr merge lp:~yuningdodo/usb-creator/usb-creator.lp1273925+lp1289269
Reviewer Review Type Date Requested Status
usb-creator hackers 2014-03-18 Pending
Review via email: mp+211465@code.launchpad.net

Description of the change

* GTK: Handle the backend.format_ended_cb callback otherwise the erasing operation will never ended. (LP: #1289269) (LP: #1273925)

To post a comment you must log in.
David Henningsson (diwic) wrote :

Thanks for the patch!

With this version, the problem has changed.

No longer do we wait indefinitely for the "erasing" button do become clear, but when it is finished, the amount of free space is reported as "0.0 B", and you still can't continue to the next step (i e create the USB disk), because the "create startup disk" button is grayed out.

Yu Ning (yuningdodo) wrote :

That’s weird, I’ll check it tomorrow. Thanks for testing it.

Yu Ning (yuningdodo) wrote :

I re-checked it, even with usb-creator-kde the free space is also considered as zero after "erase disk". I believe it's a different issue.

By the way, during my experiment I noticed that if we manually zeroed the disk (dd if=/dev/zero of=/dev/sdb bs=1M count=1) then usb-creator will report an error whilte erasing it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-03-13 11:56:48 +0000
3+++ debian/changelog 2014-03-18 09:37:48 +0000
4@@ -1,3 +1,10 @@
5+usb-creator (0.2.56) UNRELEASED; urgency=low
6+
7+ * GTK: Handle the backend.format_ended_cb callback otherwise the erasing
8+ operation will never ended. (LP: #1289269) (LP: #1273925)
9+
10+ -- Yu Ning <ning.yu@canonical.com> Tue, 18 Mar 2014 17:30:09 +0800
11+
12 usb-creator (0.2.55) trusty; urgency=medium
13
14 * KDE: Don't crash when started with --iso. The hiding logic tried to access
15
16=== modified file 'usbcreator/frontends/gtk/frontend.py'
17--- usbcreator/frontends/gtk/frontend.py 2013-01-28 12:44:46 +0000
18+++ usbcreator/frontends/gtk/frontend.py 2014-03-18 09:37:48 +0000
19@@ -122,6 +122,7 @@
20 self.backend.install_progress_pulse_stop_cb = self.progress_pulse_stop
21 self.backend.retry_cb = self.retry
22 self.backend.target_changed_cb = self.update_target
23+ self.backend.format_ended_cb = self.format_ended
24 self.backend.format_failed_cb = self.format_failed
25
26 # Pulse state.
27@@ -476,6 +477,10 @@
28 msg = ''
29 self.dest_status.set_text(msg)
30
31+ def format_ended(self):
32+ selection = self.dest_treeview.get_selection()
33+ self.selection_changed_target(selection)
34+
35 def selection_changed_source(self, selection):
36 model, iterator = selection.get_selected()
37 if not iterator:

Subscribers

People subscribed via source and target branches

to all changes: