Code review comment for lp:~yuningdodo/unity-control-center/unity-control-center.lp1396464-prevent-update-sink-input-in-parallel

Revision history for this message
David Henningsson (diwic) wrote :

If the thing is that set_is_muted is always called together with set_volume, and that in turn fires two signals, maybe one should add a gvc_channel_bar_set_volume_and_mute() function that would update both volume and mute and then fire signal(s)? Would that seem reasonable to you?

If not, I'm okay with merging your patch as it is, as you seem to have done your homework :-)

« Back to merge proposal