Unity Control Center

Code review comment for lp:~yuningdodo/unity-control-center/unity-control-center.lp1396464-prevent-update-sink-input-in-parallel

  1. unity-control-center.lp1396464-prevent-update-sink-input-in-parallel
  2. Merge into trunk
Revision history for this message
David Henningsson (diwic) wrote :

Cool, indeed this looks more reasonable to be the root cause.

But a question here - is it possible that the following can happen, at least in theory:
 1) req_update_sink_info(sink 1)
 2) req_update_sink_info(sink 2)
 3) update_sink(sink 1)
 4) update_sink(sink 2)

In this case, if it can happen, you would actually want them both to run in parallel.

Also, maybe upstream Gnome should be involved in this conversation. Not sure if they would like to break the loop using your suggestion, or rather break the loop at point 3) i e, if the change of mixer is initiated by a callback from PA, that should just update the GUI, not set the PA sink volume again to what it just received. Does that make sense?

« Back to merge proposal