Merge lp:~yuningdodo/rhythmbox/cleanup_open_location_thread into lp:rhythmbox

[Yu Ning]

Hi,

rhythmbox may miss some cleanup in the "open location" thread, which should be the cause of bug #795765.

I am trying to fix this, please have a review, and let me improve it.

Thanks
Ning

[Jeremy Bícha (jbicha)]

For Ubuntu, we need this to be a separate patch instead of modifying the source code directly.

I have converted your patch into a quilt patch in debian/patches/ and uploaded to the Quantal SRU queue. I plan to test on Precise as well and upload there too.

Are you willing and able to submit this patch to GNOME? https://bugzilla.gnome.org/663440

review: Disapprove

[Yu Ning (yuningdodo)]

Thanks for your review. I would try submit my patch to gnome, thanks again.

Unmerged revisions

220. By Yu Ning on 2012-10-18

Destroy parser_cancelable after parsing finished.

If we do not destroy it then we can not resume a paused play.

(LP: #795765)

219. By Michael Terry on 2012-09-19

[ Martin Pitt ]
* debian/source_rhythmbox.py: Fix package name, it's rhythmbox-ubuntuone
  now.

[ Jeremy Bicha ]
* debian/rhythmbox.gsettings-override:
  - Dropped, override moved to ubuntu-settings

[ Michael Terry ]
* debian/patches/git_crash_during_monitor.patch:
  - Backport git patches to guard against crashing due to monitoring
    files outside library (by moving a g_strfreev and also just stopping
    monitoring such files at all). LP: #1029333

218. By Sebastien Bacher on 2012-08-27

debian/patches/git_scale_click.patch: git patch, drop hack which was
breaking "click to jump" behaviour with gtk 3.5 (lp: #953757)

217. By Iain Lane on 2012-07-30

[ Sebastien Bacher ]
* debian/patches/09_keywords.patch:
  - backport upstream patch to set keywords in the desktop entry,
    it makes easier to find totem in the unity dash or gnome-shell
    (lp: #1029964)

[ Iain Lane ]
* debian/*.prs, debian/patches/10_encoding_use_ubuntu_profiles.patch: Add an
  OGG and MP3 preset with improved defaults to use when encoding. Patch
  rhythmbox.gep to work with user-supplied custom settings (LP: #945987)
* debian/patches/dont_free_consumed_floating_gvariant.patch: Take patch from
  upstream bug#680842 (by Ryan Lortie) to not crash when opening preferences
  dialog by trying to free an already consumed value. (LP: #1030295)
* Add Breaks and Replaces on versions of transmageddon which shipped the
  .prs files we are now shipping in -data.

216. By Jamie Strandboge on 2012-07-09

* SECURITY UPDATE: fix insecure directory for python module import in
  context plugin
  - debian/patches/08_CVE-2012-3355.patch: update context plugin to use
    tempfile.mkdtemp() instead of /tmp/context. Patch thanks to
    Andreas Henriksson.
  - CVE-2012-3355

215. By Iain Lane on 2012-06-12

* Resynchronise with Debian, remaining changes:
  - debian/source_rhythmbox.py: Add apport hook
  - debian/control, debian/*.install:
    + Move some core plug-ins into main rhythmbox package.
      o audiocd, generic-player, iradio, mmkeys, power-manager, rb
    + Split out the zeitgeist plug-in to a separate package.
    + Split out the magnatune store plug-in to a separate package.
    + Split out the visualizer plug-in to a separate package.
  - debian/patches/00git_musicbrainz5.patch:
    + Build against musicbrainz5
  - debian/patches/02_use_escaped_podcast_uri.patch
    + Handle podcasts that have sound files with the same basename
  - debian/patches/03_magnatune_partner.patch:
    + Change magnatune partner ID to 'ubuntu'.
  - debian/patches/04_pause_button.patch
    + Turn 'Play' button into 'Play/Pause'.
  - debian/patches/05_hide_on_quit.patch
    + Hide (not quit) if RB is playing when closed.
  - debian/patches/07_quicklists.patch
    + Add quicklists.
  - debian/rhythmbox.gsettings-override
    + Enable a selection of plugins by default.
* debian/control
  - Enable the visualizer plugin since libmx is now in main.
  - Add a versioned Replaces for librhythmbox-core6 to -core5 due to the
    previous uploads inadvertantly shipping the new SONAMEd library in an old
    named package.
* debian/rules: Don't try to make shlibs for packages which only ship plugins.

214. By Robert Ancell on 2012-06-07

* debian/control:
  - Build-depends on libmusicbrainz5-dev
* debian/patches/00git_musicbrainz5.patch:
  - Build against musicbrainz5

213. By Iain Lane on 2012-06-04

* New upstream release 2.97 (LP: #1008406)
 - New more compact header layout, including album art
 - Deprecated artdisplay plugin
 - Fixed buffering for network streams
 - Configurable encoding settings for the library, using GStreamer presets or
   simple quality settings
 - Doesn't preserve mtime on metadata updates
 - Fixed audio CD extraction speed
 - New podcast subscription interface, including iTunes and Miroguide
   searching and auditioning before subscription
* Drop all git backported packages; in this release.
* Drop debian/patches/06_manual_connect_daap_host.patch: upstream and not
  in series.
* Refresh other patches.
* Add BD on libxml2-dev, as required by configure.
* Adjust packaging for removal of artdisplay.

212. By Bryce Harrington on 2012-05-17

No change rebuild

211. By Bryce Harrington on 2012-05-17

Only prompt user to specify type of bug if it isn't a crash.

I.e., if there is no stacktrace present.

=== modified file 'shell/rb-shell-player.c'
--- shell/rb-shell-player.c	2012-10-18 14:13:45 +0000
+++ shell/rb-shell-player.c	2012-10-18 14:13:52 +0000
@@ -1615,6 +1615,9 @@
 		break;
 	}
 
+	g_object_unref(data->player->priv->parser_cancellable);
+	data->player->priv->parser_cancellable = NULL;
+
 	g_object_unref (data->cancellable);
 	g_free (data);
 	return NULL;