Merge lp:~yrke/tapaal/arcpathpoint-issues into lp:tapaal

Proposed by Kenneth Yrke Jørgensen
Status: Merged
Approved by: Jiri Srba
Approved revision: 1108
Merged at revision: 1107
Proposed branch: lp:~yrke/tapaal/arcpathpoint-issues
Merge into: lp:tapaal
Diff against target: 103 lines (+30/-18)
3 files modified
src/pipe/gui/graphicElements/Arc.java (+8/-8)
src/pipe/gui/handler/ArcPathPointHandler.java (+14/-2)
tools/launch4j-template.xml (+8/-8)
To merge this branch: bzr merge lp:~yrke/tapaal/arcpathpoint-issues
Reviewer Review Type Date Requested Status
Jiri Srba Approve
Review via email: mp+392033@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jiri Srba (srba) wrote :

Tested and both bugs are fixed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/pipe/gui/graphicElements/Arc.java'
2--- src/pipe/gui/graphicElements/Arc.java 2020-07-20 07:20:28 +0000
3+++ src/pipe/gui/graphicElements/Arc.java 2020-10-09 09:58:52 +0000
4@@ -296,14 +296,14 @@
5 y + myPath.getBounds().getY() - COMPONENT_DRAW_OFFSET - zoomGrow
6 );
7
8- /*if (!CreateGui.getCurrentTab().isInAnimationMode()) {
9- if (myPath.proximityContains(point) || selected) {
10- // show also if Arc itself selected
11- myPath.showPoints();
12- } else {
13- myPath.hidePoints();
14- }
15- }*/
16+ //if (!CreateGui.getCurrentTab().isInAnimationMode()) {
17+ // if (myPath.proximityContains(point) || selected) {
18+ // // show also if Arc itself selected
19+ // myPath.showPoints();
20+ // } else {
21+ // myPath.hidePoints();
22+ // }
23+ //}
24 return myPath.contains(point);
25 }
26
27
28=== modified file 'src/pipe/gui/handler/ArcPathPointHandler.java'
29--- src/pipe/gui/handler/ArcPathPointHandler.java 2020-06-29 07:43:58 +0000
30+++ src/pipe/gui/handler/ArcPathPointHandler.java 2020-10-09 09:58:52 +0000
31@@ -64,8 +64,20 @@
32 }
33 }
34
35-
36- @Override
37+ @Override
38+ public void mouseDragged(MouseEvent e) {
39+ //Can't drag endpoint at its broken
40+ if (!((ArcPathPoint) myObject).isEndPoint()) {
41+ super.mouseDragged(e);
42+ }
43+ }
44+
45+ @Override
46+ public void mouseEntered(MouseEvent e) {
47+ ((ArcPathPoint) myObject).getArcPath().showPoints();
48+ }
49+
50+ @Override
51 public void mouseReleased(MouseEvent e) {
52 ((ArcPathPoint) e.getComponent()).setVisibilityLock(false);
53 super.mouseReleased(e);
54
55=== modified file 'tools/launch4j-template.xml'
56--- tools/launch4j-template.xml 2020-01-20 08:36:47 +0000
57+++ tools/launch4j-template.xml 2020-10-09 09:58:52 +0000
58@@ -3,17 +3,17 @@
59 <dontWrapJar>true</dontWrapJar>
60 <headerType>gui</headerType>
61 <jar>%EXEDIR%\lib\tapaal.jar</jar>
62- <outfile>tapaal.exe</outfile>
63+ <outfile>C:\Users\kyrke\Downloads\tapaal.exe</outfile>
64 <errTitle></errTitle>
65 <cmdLine></cmdLine>
66 <chdir></chdir>
67 <priority>normal</priority>
68 <downloadUrl>http://java.com/download</downloadUrl>
69- <supportUrl>http://www.tapaal.net</supportUrl>
70+ <supportUrl>https://www.tapaal.net</supportUrl>
71 <stayAlive>false</stayAlive>
72 <restartOnCrash>false</restartOnCrash>
73 <manifest></manifest>
74- <icon></icon>
75+ <icon>C:\Users\kyrke\Downloads\tapaal_3_7_eQ9_icon.ico</icon>
76 <classPath>
77 <mainClass>TAPAAL</mainClass>
78 <cp>%EXEDIR%/lib/*</cp>
79@@ -22,19 +22,19 @@
80 <path></path>
81 <bundledJre64Bit>false</bundledJre64Bit>
82 <bundledJreAsFallback>false</bundledJreAsFallback>
83- <minVersion>1.6.0</minVersion>
84+ <minVersion>11.0.0</minVersion>
85 <maxVersion></maxVersion>
86 <jdkPreference>preferJre</jdkPreference>
87 <runtimeBits>64/32</runtimeBits>
88 <opt>-Dlaunch4j.exedir=&quot;%EXEDIR%&quot;</opt>
89 </jre>
90 <versionInfo>
91- <fileVersion>3.6.0.0</fileVersion>
92- <txtFileVersion>3.6.0.0</txtFileVersion>
93+ <fileVersion>3.7.0.0</fileVersion>
94+ <txtFileVersion>3.7.0.0</txtFileVersion>
95 <fileDescription>TAPAAL</fileDescription>
96 <copyright>TAPAAL Team 2008-2020</copyright>
97- <productVersion>3.6.0.0</productVersion>
98- <txtProductVersion>3.6.0.0</txtProductVersion>
99+ <productVersion>3.7.0.0</productVersion>
100+ <txtProductVersion>3.7.0.0</txtProductVersion>
101 <productName>TAPAAL</productName>
102 <companyName></companyName>
103 <internalName>tapaal</internalName>

Subscribers

People subscribed via source and target branches