Merge lp:~yolanda.robla/ubuntu/trusty/nodejs/add_distribution into lp:ubuntu/trusty/nodejs

Proposed by Yolanda Robla
Status: Work in progress
Proposed branch: lp:~yolanda.robla/ubuntu/trusty/nodejs/add_distribution
Merge into: lp:ubuntu/trusty/nodejs
Diff against target: 97 lines (+34/-2)
7 files modified
.pc/applied-patches (+1/-0)
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/patches/fix_distribution.patch (+21/-0)
debian/patches/series (+1/-0)
node.gyp (+1/-0)
src/node_version.h (+1/-1)
To merge this branch: bzr merge lp:~yolanda.robla/ubuntu/trusty/nodejs/add_distribution
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+197507@code.launchpad.net

Description of the change

  * debian/patches/fix_distribution.patch: show version in nodejs
  * debian/control: added lsb-release as build dependency

To post a comment you must log in.
35. By Yolanda Robla

added trusty distribution

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Yet again, this change is too minor to carry it as an Ubuntu-specific patch, please forward it upstream (or at least get an ACK from upstream about that).

Also, “UBUNTU_DISTRIBUTION” is a bad name for variable, as this patch will work on Debian and any other Linux release.

−1 from me.

Revision history for this message
Iain Lane (laney) wrote :

Please respond once you've heard back from Debian - setting to WIP

Revision history for this message
Yolanda Robla (yolanda.robla) wrote :

Unmerged revisions

35. By Yolanda Robla

added trusty distribution

34. By Yolanda Robla

* debian/patches/fix_distribution.patch: show version in nodejs
* debian/control: added lsb-release as build dependency

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.pc/applied-patches'
2--- .pc/applied-patches 2013-11-30 23:54:20 +0000
3+++ .pc/applied-patches 2013-12-03 12:23:15 +0000
4@@ -9,3 +9,4 @@
5 1003_test_disable_chunked_response.patch
6 1004_test_writeNaN.patch
7 1005_unbreak_bsd_builds.patch
8+fix_distribution.patch
9
10=== modified file 'debian/changelog'
11--- debian/changelog 2013-11-30 23:54:20 +0000
12+++ debian/changelog 2013-12-03 12:23:15 +0000
13@@ -1,3 +1,10 @@
14+nodejs (0.10.22~dfsg1-2ubuntu1) trusty; urgency=low
15+
16+ * debian/patches/fix_distribution.patch: show version in nodejs
17+ * debian/control: added lsb-release as build dependency
18+
19+ -- Yolanda Robla <yolanda.robla@canonical.com> Tue, 03 Dec 2013 12:56:36 +0100
20+
21 nodejs (0.10.22~dfsg1-2) unstable; urgency=low
22
23 * Update 2005 patch, allow test-cluster-dgram-2 to time out.
24
25=== modified file 'debian/control'
26--- debian/control 2013-08-14 00:16:46 +0000
27+++ debian/control 2013-12-03 12:23:15 +0000
28@@ -20,7 +20,8 @@
29 python,
30 libv8-3.14-dev (>= 3.7),
31 libssl-dev (>= 1.0.0g),
32- libc-ares-dev (>= 1.7.5)
33+ libc-ares-dev (>= 1.7.5),
34+ lsb-release
35 Standards-Version: 3.9.4
36 Homepage: http://nodejs.org/
37 Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/nodejs.git
38
39=== added file 'debian/patches/fix_distribution.patch'
40--- debian/patches/fix_distribution.patch 1970-01-01 00:00:00 +0000
41+++ debian/patches/fix_distribution.patch 2013-12-03 12:23:15 +0000
42@@ -0,0 +1,21 @@
43+--- a/node.gyp 2013-12-03 11:50:27.741880000 +0000
44++++ b/node.gyp 2013-12-03 11:55:02.162386103 +0000
45+@@ -144,6 +144,7 @@
46+ 'ARCH="<(target_arch)"',
47+ 'PLATFORM="<(OS)"',
48+ 'NODE_TAG="<(node_tag)"',
49++ 'UBUNTU_DISTRIBUTION="<!(lsb_release -si)"'
50+ ],
51+
52+ 'conditions': [
53+--- a/src/node_version.h 2013-12-03 11:50:27.741880000 +0000
54++++ b/src/node_version.h 2013-12-03 12:05:31.774386103 +0000
55+@@ -49,7 +49,7 @@
56+ NODE_TAG "-pre"
57+ #endif
58+
59+-#define NODE_VERSION "v" NODE_VERSION_STRING
60++#define NODE_VERSION "v" NODE_VERSION_STRING " (" UBUNTU_DISTRIBUTION ")"
61+
62+
63+ #define NODE_VERSION_AT_LEAST(major, minor, patch) \
64
65=== modified file 'debian/patches/series'
66--- debian/patches/series 2013-11-30 23:54:20 +0000
67+++ debian/patches/series 2013-12-03 12:23:15 +0000
68@@ -9,3 +9,4 @@
69 1003_test_disable_chunked_response.patch
70 1004_test_writeNaN.patch
71 1005_unbreak_bsd_builds.patch
72+fix_distribution.patch
73
74=== modified file 'node.gyp'
75--- node.gyp 2013-07-28 18:50:13 +0000
76+++ node.gyp 2013-12-03 12:23:15 +0000
77@@ -144,6 +144,7 @@
78 'ARCH="<(target_arch)"',
79 'PLATFORM="<(OS)"',
80 'NODE_TAG="<(node_tag)"',
81+ 'UBUNTU_DISTRIBUTION="<!(lsb_release -si)>"'
82 ],
83
84 'conditions': [
85
86=== modified file 'src/node_version.h'
87--- src/node_version.h 2013-11-13 23:17:51 +0000
88+++ src/node_version.h 2013-12-03 12:23:15 +0000
89@@ -49,7 +49,7 @@
90 NODE_TAG "-pre"
91 #endif
92
93-#define NODE_VERSION "v" NODE_VERSION_STRING
94+#define NODE_VERSION "v" NODE_VERSION_STRING " (" UBUNTU_DISTRIBUTION ")"
95
96
97 #define NODE_VERSION_AT_LEAST(major, minor, patch) \

Subscribers

People subscribed via source and target branches

to all changes: