Merge lp:~yolanda.robla/ubuntu/saucy/net-snmp/debian_merge into lp:ubuntu/saucy/net-snmp

Proposed by Yolanda Robla
Status: Merged
Merge reported by: Martin Pitt
Merged at revision: not available
Proposed branch: lp:~yolanda.robla/ubuntu/saucy/net-snmp/debian_merge
Merge into: lp:ubuntu/saucy/net-snmp
Diff against target: 357 lines (+200/-29)
10 files modified
debian/changelog (+61/-0)
debian/control (+12/-10)
debian/libsnmp-base.install (+2/-0)
debian/libsnmp-perl.preinst (+30/-0)
debian/libsnmp30.install (+0/-2)
debian/rules (+1/-1)
debian/snmp.postinst (+34/-0)
debian/snmp.preinst (+17/-8)
debian/snmp.prerm (+14/-2)
debian/snmpd.postinst (+29/-6)
To merge this branch: bzr merge lp:~yolanda.robla/ubuntu/saucy/net-snmp/debian_merge
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Review via email: mp+175043@code.launchpad.net

Description of the change

Merging new Debian version (LP: #1200516)

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Aside from the already documented apport delta, there is also this:

+.PHONY: override_dh_installinit
+override_dh_installinit:
+ dh_installinit -u"start 20 2 3 4 5 . stop 20 1 ."

Is it still necessary? Please document it in "remaining changes" or drop it.

Thanks!

review: Needs Fixing
61. By Yolanda Robla

removed dh_installinit override

62. By Yolanda Robla

Call dh_installinit correctly to avoid installing links in rc[06].d

63. By Yolanda Robla

restored dh_installinit

Revision history for this message
Yolanda Robla (yolanda.robla) wrote :

> Aside from the already documented apport delta, there is also this:
>
> +.PHONY: override_dh_installinit
> +override_dh_installinit:
> + dh_installinit -u"start 20 2 3 4 5 . stop 20 1 ."
>
> Is it still necessary? Please document it in "remaining changes" or drop it.
>
> Thanks!

Link is added without that fix, so preserved it and documented in changelog

Revision history for this message
Martin Pitt (pitti) wrote :

Great, thanks. Uploaded.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file '.pc/02_statistics.patch/.timestamp'
2=== added file '.pc/03_makefiles.patch/.timestamp'
3=== added file '.pc/05_searchdirs.patch/.timestamp'
4=== added file '.pc/06_extramibs.patch/.timestamp'
5=== added file '.pc/07_docfiles.patch/.timestamp'
6=== added file '.pc/26_kfreebsd.patch/.timestamp'
7=== added file '.pc/27_kfreebsd_bug625985.patch/.timestamp'
8=== added file '.pc/60_libsensors_api.patch/.timestamp'
9=== added file '.pc/61_vacm_missing_dependency_check.patch/.timestamp'
10=== added file '.pc/62_add_lib_cflags.patch/.timestamp'
11=== added file '.pc/64_missing_lib.patch/.timestamp'
12=== added file '.pc/after_RFC5378/.timestamp'
13=== added file '.pc/fix_logging_option.patch/.timestamp'
14=== added file '.pc/fix_man_error.patch/.timestamp'
15=== added file '.pc/fix_manpage-has-errors_break_line.patch/.timestamp'
16=== added file '.pc/fix_regular_expression.patch/.timestamp'
17=== added file '.pc/fix_snmpcheck_perl_path.patch/.timestamp'
18=== added file '.pc/fix_spelling_error.patch/.timestamp'
19=== added file '.pc/fix_typo_in_snmpd.conf.patch/.timestamp'
20=== added file '.pc/snmptranslate.1.patch/.timestamp'
21=== modified file 'debian/changelog'
22--- debian/changelog 2013-05-16 21:01:27 +0000
23+++ debian/changelog 2013-07-23 12:00:48 +0000
24@@ -1,3 +1,64 @@
25+net-snmp (5.7.2~dfsg-8ubuntu1) saucy; urgency=low
26+
27+ * Merge from Debian unstable (LP: #1200516). Remaining changes:
28+ + Add apport hook (LP: #533603):
29+ - debian/source.apport: apport hook
30+ - debian/control: Build-depends on dh-apport.
31+ - debian/rules:
32+ + Add --with apport.
33+ + override_dh_apport to install hook on snmpd package only.
34+ * Call dh_installinit correctly to avoid installing links in rc[06].d
35+
36+ -- Yolanda Robla <yolanda.robla@canonical.com> Fri, 12 Jul 2013 09:47:12 +0200
37+
38+net-snmp (5.7.2~dfsg-8) unstable; urgency=low
39+
40+ * add libsnmp-perl.preinst to deal with empty directory by libsnmp15
41+ package removal (Closes: #709761)
42+ * {snmp,snmpd}.postinst: deal with "copyright file missing after upgrade
43+ (policy 12.5)" (Closes: #709087)
44+
45+ -- Hideki Yamane <henrich@debian.org> Thu, 06 Jun 2013 08:49:02 +0900
46+
47+net-snmp (5.7.2~dfsg-7) unstable; urgency=low
48+
49+ * debian/control
50+ - libsnmp-base: update to more policy polite (Breaks/Replaces: libsnmp15
51+ (<<5.7.2~dfsg-5)), thanks to James McCoy
52+ * debian/snmp.preinst
53+ - fix incomplete script.
54+
55+ -- Hideki Yamane <henrich@debian.org> Mon, 20 May 2013 14:19:36 +0900
56+
57+net-snmp (5.7.2~dfsg-6) unstable; urgency=low
58+
59+ * debian/rules
60+ - Fix Hurd build issue, thanks Pino Toscano <pino@debian.org> for
61+ the patch (Closes: #708951)
62+ * debian/snmpd.init
63+ - patch from Ubuntu, LSBified
64+ * debian/snmp.pre{inst,rm}
65+ - patch from Ubuntu, Kill any/all processes owned by snmp user before
66+ install/uninstall.
67+ * debian/control
68+ - add "Conflicts: libsnmp15" to libsnmp-base since moving net-snmp-config
69+ in previous version cause trouble (Closes: #708983)
70+
71+ -- Hideki Yamane <henrich@debian.org> Mon, 20 May 2013 08:49:14 +0900
72+
73+net-snmp (5.7.2~dfsg-5) unstable; urgency=low
74+
75+ * debian/control
76+ - fix typo and improve description, thanks to Martin Eberhard Schauer
77+ <Martin.E.Schauer@gmx.de> for the patch (Closes: #708519)
78+ - libsnmp-base: add "Conflicts: libsnmp30 (<< 5.7.2~dfsg-5)" since
79+ net-snmp-config file moves from libsnmp30 to libsnmp-base
80+ (Closes: #708298)
81+ - update descriptions
82+ * debian/{libsnmp-base,libsnmp30}.install: update
83+
84+ -- Hideki Yamane <henrich@debian.org> Sun, 19 May 2013 23:09:52 +0900
85+
86 net-snmp (5.7.2~dfsg-4ubuntu1) saucy; urgency=low
87
88 * Merge from Debian unstable. Remaining changes:
89
90=== modified file 'debian/control'
91--- debian/control 2013-05-16 21:01:27 +0000
92+++ debian/control 2013-07-23 12:00:48 +0000
93@@ -47,22 +47,24 @@
94 Package: libsnmp-base
95 Section: libs
96 Architecture: all
97-Replaces: libsnmp-dev (<< 5.4~dfsg), libsnmp9-dev (<< 5.4~dfsg)
98-Conflicts: libsnmp-dev (<< 5.4~dfsg), libsnmp9-dev (<< 5.4~dfsg)
99+Replaces: libsnmp-dev (<< 5.4~dfsg), libsnmp9-dev (<< 5.4~dfsg), libsnmp15 (<< 5.7.2~dfsg-5)
100+Conflicts: libsnmp-dev (<< 5.4~dfsg), libsnmp9-dev (<< 5.4~dfsg), libsnmp30 (<< 5.7.2~dfsg-5)
101+Breaks: libsnmp15 (<< 5.7.2~dfsg-5)
102 Depends: ${misc:Depends}
103 Suggests: snmp-mibs-downloader
104-Description: SNMP (Simple Network Management Protocol) MIBs and documentation
105+Description: SNMP configuration script, MIBs and documentation
106 The Simple Network Management Protocol (SNMP) provides a framework
107 for the exchange of management information between agents (servers)
108 and clients.
109 .
110- This package includes documentation and MIBs (Management Information
111- Bases) for the SNMP libraries, agents and applications. MIBs contain
112- a formal description of the data that can be managed using SNMP.
113- and applications.
114+ This package includes net-snmp-config scripts, documentation and MIBs
115+ (Management Information Bases) for the SNMP libraries, agents and
116+ applications. MIBs contain a formal description of the data that can be
117+ managed using SNMP and applications.
118 .
119- NOTE: If you want the OIDs to resolve to their text description, you need to
120- activate the non-free repository and install "snmp-mibs-downloader" package.
121+ NOTE: If you want the OIDs (Object Identifiers) to resolve to their text
122+ description, you need to activate the non-free repository and install the
123+ "snmp-mibs-downloader" package.
124
125 Package: libsnmp30
126 Section: libs
127@@ -71,7 +73,7 @@
128 Breaks: libsnmp15
129 Multi-Arch: same
130 Pre-Depends: ${misc:Pre-Depends}
131-Depends: ${shlibs:Depends}, ${misc:Depends}
132+Depends: ${shlibs:Depends}, ${misc:Depends}, libsnmp-base
133 Description: SNMP (Simple Network Management Protocol) library
134 The Simple Network Management Protocol (SNMP) provides a framework
135 for the exchange of management information between agents (servers)
136
137=== modified file 'debian/libsnmp-base.install'
138--- debian/libsnmp-base.install 2013-05-16 21:01:27 +0000
139+++ debian/libsnmp-base.install 2013-07-23 12:00:48 +0000
140@@ -1,2 +1,4 @@
141 mibs/*.txt usr/share/snmp/mibs
142 usr/share/snmp/mib2c-data
143+usr/bin/net-snmp-config
144+usr/share/man/man1/net-snmp-config.1
145
146=== added file 'debian/libsnmp-perl.preinst'
147--- debian/libsnmp-perl.preinst 1970-01-01 00:00:00 +0000
148+++ debian/libsnmp-perl.preinst 2013-07-23 12:00:48 +0000
149@@ -0,0 +1,30 @@
150+#!/bin/sh
151+# preinst script for libsnmp-perl
152+
153+set -e
154+
155+
156+case "$1" in
157+ install|upgrade)
158+
159+ DOCDIR=/usr/share/doc/libsnmp-perl
160+ if [ -L $DOCDIR ]; then
161+ rm $DOCDIR
162+ fi
163+ ;;
164+
165+ abort-upgrade)
166+ ;;
167+
168+ *)
169+ echo "preinst called with unknown argument \`$1'" >&2
170+ exit 1
171+ ;;
172+esac
173+
174+# dh_installdeb will replace this with shell code automatically
175+# generated by other debhelper scripts.
176+
177+#DEBHELPER#
178+
179+exit 0
180
181=== modified file 'debian/libsnmp30.install'
182--- debian/libsnmp30.install 2013-03-19 16:43:02 +0000
183+++ debian/libsnmp30.install 2013-07-23 12:00:48 +0000
184@@ -1,3 +1,1 @@
185 usr/lib/*/lib*.so.*
186-usr/bin/net-snmp-config
187-usr/share/man/man1/net-snmp-config.1
188
189=== modified file 'debian/rules'
190--- debian/rules 2013-05-16 21:01:27 +0000
191+++ debian/rules 2013-07-23 12:00:48 +0000
192@@ -27,7 +27,7 @@
193 DEB_DH_GENCONTROL_ARGS=-- -Vos-specific-dev="libkvm-dev"
194 endif
195 endif
196-ifeq (hurd,$(DEB_BUILD_HOST_OS))
197+ifeq (hurd,$(DEB_BUILD_ARCH_OS))
198 IPV6 = --enable-ipv6
199 EXCL_MIB_MODULES += mibII
200 else
201
202=== added file 'debian/snmp.postinst'
203--- debian/snmp.postinst 1970-01-01 00:00:00 +0000
204+++ debian/snmp.postinst 2013-07-23 12:00:48 +0000
205@@ -0,0 +1,34 @@
206+#!/bin/sh
207+# postinst script for snmp
208+#
209+# see: dh_installdeb(1)
210+
211+set -e
212+
213+case "$1" in
214+ configure)
215+
216+ DOCDIR=/usr/share/doc/snmp
217+ DOCLINK=libsnmp30
218+
219+ if [ -d $DOCDIR ] && [ ! -L $DOCDIR ]; then
220+ rmdir $DOCDIR
221+ ln -s $DOCLINK $DOCDIR
222+ fi
223+ ;;
224+
225+ abort-upgrade|abort-remove|abort-deconfigure)
226+ ;;
227+
228+ *)
229+ echo "postinst called with unknown argument \`$1'" >&2
230+ exit 1
231+ ;;
232+esac
233+
234+# dh_installdeb will replace this with shell code automatically
235+# generated by other debhelper scripts.
236+
237+#DEBHELPER#
238+
239+exit 0
240
241=== modified file 'debian/snmp.preinst'
242--- debian/snmp.preinst 2010-06-22 14:04:48 +0000
243+++ debian/snmp.preinst 2013-07-23 12:00:48 +0000
244@@ -1,20 +1,29 @@
245-#! /bin/sh
246+#!/bin/sh
247
248 set -e
249
250-action="$1"
251-
252-killall -u snmp 2>/dev/null || true
253-
254-if [ "$action" = upgrade ]
255-then
256+case "$1" in
257+
258+install|upgrade)
259 if [ -L /usr/share/doc/snmp ]; then
260 rm -f /usr/share/doc/snmp
261 fi
262 if [ -d /usr/doc/snmp ]; then
263 rm -rf /usr/doc/snmp
264 fi
265-fi
266+
267+ killall -u snmp 2>/dev/null || true
268+
269+ ;;
270+abort-upgrade)
271+ ;;
272+
273+*)
274+ echo "preinst called with unknown argument \`$1'" >&2
275+ exit 1
276+ ;;
277+
278+esac
279
280 #DEBHELPER#
281
282
283=== modified file 'debian/snmp.prerm'
284--- debian/snmp.prerm 2010-06-22 14:04:48 +0000
285+++ debian/snmp.prerm 2013-07-23 12:00:48 +0000
286@@ -1,8 +1,20 @@
287-#! /bin/sh
288+#!/bin/sh
289
290 set -e
291
292-killall -u snmp 2>/dev/null || true
293+case "$1" in
294+ remove|upgrade|deconfigure)
295+ killall -u snmp 2>/dev/null || true
296+ ;;
297+
298+ failed-upgrade)
299+ ;;
300+
301+ *)
302+ echo "prerm called with unknown argument \`$1'" >&2
303+ exit 1
304+ ;;
305+esac
306
307 #DEBHELPER#
308
309
310=== modified file 'debian/snmpd.postinst'
311--- debian/snmpd.postinst 2013-05-16 21:01:27 +0000
312+++ debian/snmpd.postinst 2013-07-23 12:00:48 +0000
313@@ -2,16 +2,39 @@
314
315 set -e
316
317-. /usr/share/debconf/confmodule
318-db_version 2.0
319-
320-if [ "x$1" = xconfigure ]; then
321+case "$1" in
322+ configure)
323+
324+ . /usr/share/debconf/confmodule
325+ db_version 2.0
326+
327 if ! getent group snmp >/dev/null ; then
328- deluser --quiet --system snmp
329+ deluser --quiet --system snmp
330 fi
331 adduser --quiet --system --group --no-create-home --home /var/lib/snmp snmp
332 chown -R snmp:snmp /var/lib/snmp
333-fi
334+
335+ # Bug#709087
336+ DOCDIR=/usr/share/doc/snmpd
337+ DOCLINK=libsnmp30
338+
339+ if [ -d $DOCDIR ] && [ ! -L $DOCDIR ]; then
340+ rmdir $DOCDIR
341+ ln -s $DOCLINK $DOCDIR
342+ fi
343+ ;;
344+
345+ abort-upgrade|abort-remove|abort-deconfigure)
346+ ;;
347+
348+ *)
349+ echo "postinst called with unknown argument \`$1'" >&2
350+ exit 1
351+ ;;
352+esac
353+
354+# dh_installdeb will replace this with shell code automatically
355+# generated by other debhelper scripts.
356
357 #DEBHELPER#
358

Subscribers

People subscribed via source and target branches

to all changes: