Merge lp:~yolanda.robla/ubuntu/saucy/iscsitarget/dep-8-tests into lp:ubuntu/saucy/iscsitarget

Proposed by Yolanda Robla
Status: Merged
Merge reported by: Martin Pitt
Merged at revision: not available
Proposed branch: lp:~yolanda.robla/ubuntu/saucy/iscsitarget/dep-8-tests
Merge into: lp:ubuntu/saucy/iscsitarget
Diff against target: 59 lines (+30/-0)
4 files modified
debian/changelog (+6/-0)
debian/control (+1/-0)
debian/tests/control (+3/-0)
debian/tests/daemon (+20/-0)
To merge this branch: bzr merge lp:~yolanda.robla/ubuntu/saucy/iscsitarget/dep-8-tests
Reviewer Review Type Date Requested Status
Martin Pitt Approve
James Hunt (community) Approve
Review via email: mp+163368@code.launchpad.net

Description of the change

Added dep-8-tests

To post a comment you must log in.
Revision history for this message
James Hunt (jamesodhunt) wrote :

LGTM.

review: Approve
Revision history for this message
Martin Pitt (pitti) wrote :

Verified on current saucy with "run-adt-test -sS lp:~yolanda.robla/ubuntu/saucy/iscsitarget/dep-8-tests iscsitarget".

Applied patch manually on apt-get source, as UDD branch is out of date. Closing MP manually.

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-06-30 15:40:51 +0000
3+++ debian/changelog 2013-05-10 20:51:29 +0000
4@@ -1,3 +1,9 @@
5+iscsitarget (1.4.20.2-5ubuntu2) saucy; urgency=low
6+
7+ * d/tests: added dep-8-tests
8+
9+ -- Yolanda <yolanda.robla@canonical.com> Fri, 10 May 2013 22:47:14 +0200
10+
11 iscsitarget (1.4.20.2-5ubuntu1) oneiric; urgency=low
12
13 * Resynchronise with Debian experimental. Remaining changes:
14
15=== modified file 'debian/control'
16--- debian/control 2011-06-29 11:04:54 +0000
17+++ debian/control 2013-05-10 20:51:29 +0000
18@@ -9,6 +9,7 @@
19 Homepage: http://iscsitarget.sourceforge.net/
20 Vcs-Git: git://git.debian.org/git/pkg-iscsi/iscsitarget.git
21 Vcs-Browser: http://git.debian.org/?p=pkg-iscsi/iscsitarget.git
22+XS-Testsuite: autopkgtest
23
24 Package: iscsitarget
25 Architecture: any
26
27=== added directory 'debian/tests'
28=== added file 'debian/tests/control'
29--- debian/tests/control 1970-01-01 00:00:00 +0000
30+++ debian/tests/control 2013-05-10 20:51:29 +0000
31@@ -0,0 +1,3 @@
32+Tests: daemon
33+Depends: iscsitarget, iscsitarget-dkms
34+Restrictions: needs-root
35
36=== added file 'debian/tests/daemon'
37--- debian/tests/daemon 1970-01-01 00:00:00 +0000
38+++ debian/tests/daemon 2013-05-10 20:51:29 +0000
39@@ -0,0 +1,20 @@
40+#!/bin/bash
41+#--------------------------
42+# Testing iscitarget daemon
43+#--------------------------
44+set -e
45+
46+# modify /etc/default/iscsitarget to enable it
47+CONFIG_FILE=/etc/default/iscsitarget
48+TMP_CONFIG_FILE=/etc/default/iscsitarget.old
49+sed -e "s/ISCSITARGET_ENABLE=false/ISCITARGET_ENABLE=true/g" $CONFIG_FILE > $TMP_CONFIG_FILE
50+mv $TMP_CONFIG_FILE $CONFIG_FILE
51+/etc/init.d/iscsitarget start >/dev/null 2>&1
52+
53+if ps aux | grep -v "grep" | grep -q "iscsitarget" > /dev/null; then
54+ echo "OK"
55+ exit 0
56+else
57+ echo "ERROR: ISCITARGET IS NOT RUNNING"
58+ exit 1
59+fi

Subscribers

People subscribed via source and target branches

to all changes: