Merge lp:~yolanda.robla/ubuntu/raring/python-pecan/updated-deps into lp:ubuntu/raring/python-pecan
Proposed by
Yolanda Robla
Status: | Merged |
---|---|
Merge reported by: | James Page |
Merged at revision: | not available |
Proposed branch: | lp:~yolanda.robla/ubuntu/raring/python-pecan/updated-deps |
Merge into: | lp:ubuntu/raring/python-pecan |
Diff against target: |
44 lines (+17/-2) 2 files modified
debian/changelog (+6/-0) debian/control (+11/-2) |
To merge this branch: | bzr merge lp:~yolanda.robla/ubuntu/raring/python-pecan/updated-deps |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Page | Needs Fixing | ||
Review via email: mp+151467@code.launchpad.net |
Description of the change
Updated dependencies
To post a comment you must log in.
Hi Yolanda
I had a review of your merge proposal; I'd actually do this a little differently.
Rather than adding runtime dependencies, I'd add the required dependencies to the source package; with backporting to precise in mind this picks up issues at build time rather than runtime (always preferable IMHO).
So looking at the deps you added:
python-mako (>= 0.6.2), (OK) simplegeneric (>= 0.8), (OK)
python-markupsafe (>= 0.15), (Drop version - already in precise - also I can't find this in the actual source)
python-webob (>= 1.2b3), (I'd go with >= 1.2.3 which is in raring & experimental)
python-webtest (>= 1.3.3), (Drop version - already in precise)
python-
I'd add them as source BD's and alter the versions inline with above; as 12.04 is the earliest backport we would reasonably expect to target I'd drop the versioned dependencies for packages which are already good enough in terms of version for 12.04.
HTH
Cheers
James