Merge lp:~yolanda.robla/ubuntu/raring/python-pecan/updated-deps into lp:ubuntu/raring/python-pecan

Proposed by Yolanda Robla
Status: Merged
Merge reported by: James Page
Merged at revision: not available
Proposed branch: lp:~yolanda.robla/ubuntu/raring/python-pecan/updated-deps
Merge into: lp:ubuntu/raring/python-pecan
Diff against target: 44 lines (+17/-2)
2 files modified
debian/changelog (+6/-0)
debian/control (+11/-2)
To merge this branch: bzr merge lp:~yolanda.robla/ubuntu/raring/python-pecan/updated-deps
Reviewer Review Type Date Requested Status
James Page Needs Fixing
Review via email: mp+151467@code.launchpad.net

Description of the change

Updated dependencies

To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote :

Hi Yolanda

I had a review of your merge proposal; I'd actually do this a little differently.

Rather than adding runtime dependencies, I'd add the required dependencies to the source package; with backporting to precise in mind this picks up issues at build time rather than runtime (always preferable IMHO).

So looking at the deps you added:

 python-mako (>= 0.6.2), (OK)
 python-markupsafe (>= 0.15), (Drop version - already in precise - also I can't find this in the actual source)
 python-webob (>= 1.2b3), (I'd go with >= 1.2.3 which is in raring & experimental)
 python-webtest (>= 1.3.3), (Drop version - already in precise)
 python-simplegeneric (>= 0.8), (OK)

I'd add them as source BD's and alter the versions inline with above; as 12.04 is the earliest backport we would reasonably expect to target I'd drop the versioned dependencies for packages which are already good enough in terms of version for 12.04.

HTH

Cheers

James

review: Needs Fixing
Revision history for this message
James Page (james-page) wrote :

Oh - and don't add markupsafe - as far as I can tell its not actually used :-)

4. By Yolanda Robla

refreshed deps

5. By Yolanda Robla

adding python-webtest again

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-01-24 09:06:05 +0000
3+++ debian/changelog 2013-03-05 14:24:22 +0000
4@@ -1,3 +1,9 @@
5+python-pecan (0.2.0b2-0ubuntu2) raring; urgency=low
6+
7+ * debian/control: Updated dependencies
8+
9+ -- Yolanda Robla <yolanda.robla@canonical.com> Mon, 04 Mar 2013 11:59:00 +0100
10+
11 python-pecan (0.2.0b2-0ubuntu1) raring; urgency=low
12
13 * New upstream release.
14
15=== modified file 'debian/control'
16--- debian/control 2013-01-24 09:06:05 +0000
17+++ debian/control 2013-03-05 14:24:22 +0000
18@@ -8,7 +8,14 @@
19 Thomas Goirand <zigo@debian.org>,
20 Ghe Rivero <ghe.rivero@stackops.com>,
21 Mehdi Abaakouk <sileht@sileht.net>
22-Build-Depends: debhelper (>= 9), python-setuptools, python-all (>= 2.6.6-3~)
23+Build-Depends:
24+ debhelper (>= 9),
25+ python-setuptools,
26+ python-all (>= 2.6.6-3~),
27+ python-mako (>= 0.6.2),
28+ python-webob (>= 1.2.3),
29+ python-simplegeneric (>= 0.8),
30+ python-webtest
31 Standards-Version: 3.9.3
32 Vcs-Browser: http://anonscm.debian.org/gitweb/?p=openstack/python-pecan.git
33 Vcs-Git: git://anonscm.debian.org/openstack/python-pecan.git
34@@ -17,7 +24,9 @@
35 Package: python-pecan
36 Architecture: all
37 Pre-Depends: dpkg (>= 1.15.6~)
38-Depends: ${python:Depends}, ${misc:Depends}
39+Depends:
40+ ${python:Depends},
41+ ${misc:Depends}
42 Description: WSGI object-dispatching web framework
43 The Pecan Python module is a WSGI object-dispatching web framework designed to
44 be lean and fast with few dependencies. Pecan comes bundled with a lightweight

Subscribers

People subscribed via source and target branches

to all changes: