Merge lp:~yolanda.robla/heat/icehouse_add_heatclient into lp:~ubuntu-server-dev/heat/icehouse

Proposed by Yolanda Robla
Status: Merged
Approved by: Chuck Short
Approved revision: 29
Merged at revision: 28
Proposed branch: lp:~yolanda.robla/heat/icehouse_add_heatclient
Merge into: lp:~ubuntu-server-dev/heat/icehouse
Diff against target: 34 lines (+6/-1)
2 files modified
debian/changelog (+5/-1)
debian/control (+1/-0)
To merge this branch: bzr merge lp:~yolanda.robla/heat/icehouse_add_heatclient
Reviewer Review Type Date Requested Status
Chuck Short (community) Needs Fixing
Review via email: mp+197579@code.launchpad.net

Description of the change

Added heatclient to test requirements.

To post a comment you must log in.
Revision history for this message
Chuck Short (zulcss) wrote :

This is wrong, the python-heatclient needs to be added to the debian/control not the test_requirements.txt

review: Needs Fixing
29. By Yolanda Robla

debian/control: Added python-heatclient as a build dependency.

Revision history for this message
Yolanda Robla (yolanda.robla) wrote :

Ok, problem is that for me builds locally, so I patched a bit supposing the failure. Moved python-heatclient as build dependency.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-11-26 01:52:24 +0000
3+++ debian/changelog 2013-12-03 18:40:18 +0000
4@@ -1,5 +1,6 @@
5 heat (2013.2-0ubuntu2) UNRELEASED; urgency=low
6
7+ [ Chuck Short ]
8 * debian/control:
9 + Open icehouse release.
10 + Dropped python-argparse.
11@@ -7,7 +8,10 @@
12 + Add python-testscenarios as a build dependency.
13 * debian/patches/default-sqlite.patch: Dropped no longer needed.
14
15- -- Chuck Short <zulcss@ubuntu.com> Tue, 22 Oct 2013 09:55:12 -0700
16+ [ Yolanda Robla ]
17+ * debian/control: Added python-heatclient as a build dependency.
18+
19+ -- Yolanda Robla <yolanda.robla@canonical.com> Tue, 03 Dec 2013 18:39:12 +0100
20
21 heat (2013.2-0ubuntu1) saucy; urgency=low
22
23
24=== modified file 'debian/control'
25--- debian/control 2013-11-26 01:52:24 +0000
26+++ debian/control 2013-12-03 18:40:18 +0000
27@@ -24,6 +24,7 @@
28 python-extras,
29 python-glanceclient,
30 python-greenlet (>= 0.3.2),
31+ python-heatclient,
32 python-httplib2,
33 python-iso8601,
34 python-keystoneclient (>= 1:0.2.3),

Subscribers

People subscribed via source and target branches