Merge lp:~yofel/ubuntu/maverick/samba/lp-623798 into lp:ubuntu/maverick/samba

[Philip Muškovac]

Fix a typo in the apport hook that causes it to crash when choosing 'others' for the client question:

*** Which clients are failing to connect?

Choices:
  1: Windows
  2: Ubuntu
  3: Both
  4: Other
  C: Cancel
Please choose (1/2/3/4/C):4
hook /usr/share/apport/package-hooks//source_samba.py crashed:
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/apport/report.py", line 636, in add_hooks_info
    symb['add_info'](self, ui)
  File "/usr/share/apport/package-hooks//source_samba.py", line 95, in add_info
    if repsonse[0] == 3:
NameError: global name 'repsonse' is not defined

[Mathias Gug (mathiaz)]

Thanks. I've updated the diff against the latest version of the samba package in maverick and uploaded it to maverick.

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2010-08-16 15:09:30 +0000
+++ debian/changelog	2010-09-01 23:04:50 +0000
@@ -1,3 +1,9 @@
+samba (2:3.5.4~dfsg-1ubuntu4) maverick; urgency=low
+
+  * Fix typo in apport hook (LP: #623798)
+
+ -- Philip Muskovac <[e-mail]>  Thu, 02 Sep 2010 00:59:56 +0200
+
 samba (2:3.5.4~dfsg-1ubuntu3) maverick; urgency=low
 
   * Add the translation of Unix Error code -ENOTSUP to NT Error Code

=== modified file 'debian/source_samba.py'
--- debian/source_samba.py	2010-06-07 19:06:51 +0000
+++ debian/source_samba.py	2010-09-01 23:04:50 +0000
@@ -71,7 +71,7 @@
 	ui.information("As a part of the bug reporting process, you'll be asked as series of questions to help provide a more descriptive bug report. Please answer the following questions to the best of your abilities. Afterwards, a browser will be opened to finish filing this as a bug in the Launchpad bug tracking system.")
 
 	response = ui.choice("How would you best describe your setup?", ["I am running a Windows File Server.", "I am connecting to a Windows File Server."], False)
-	
+
 	if response == None:
 		raise StopIteration # user has canceled
 	elif response[0] == 0: #its a server
@@ -82,7 +82,7 @@
 			report['SambaServerRegression'] = "No"
 		if response == True:
 			report['SambaServerRegression'] = 'Yes'
-	
+
 		response = ui.choice("Which clients are failing to connect?", ["Windows", "Ubuntu", "Both", "Other"], False)
 		if response == None:
 			raise StopIteration # user has canceled
@@ -92,7 +92,7 @@
 			report['WindowsFailedConnect'] = 'Yes'
 		if response[0] == 2:
 			report['BothFailedConnect']  = 'Yes'
-		if repsonse[0] == 3:
+		if response[0] == 3:
 			report['OtherFailedconnect'] = 'Yes'
 
 		response = ui.yesno("The contents of your /etc/samba/smb.conf file may help developers diagnose your bug more quickly. However, it may contain sensitive information.  Do you want to include it in your bug report?")