Merge lp:~yellow/testrepository/bug988481 into lp:~testrepository/testrepository/trunk
Status: | Rejected |
---|---|
Rejected by: | Robert Collins |
Proposed branch: | lp:~yellow/testrepository/bug988481 |
Merge into: | lp:~testrepository/testrepository/trunk |
Diff against target: |
119 lines (+5/-47) 6 files modified
testrepository/commands/failing.py (+1/-1) testrepository/commands/last.py (+1/-1) testrepository/results.py (+0/-39) testrepository/tests/commands/test_load.py (+0/-1) testrepository/tests/test_results.py (+2/-4) testrepository/ui/cli.py (+1/-1) |
To merge this branch: | bzr merge lp:~yellow/testrepository/bug988481 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Collins | Disapprove | ||
Review via email: mp+103704@code.launchpad.net |
Description of the change
This branch depends on lp:~yellow/subunit/real-time and lp:~yellow/subunit/test-count. The following MP text is slightly modified from the MP for the first branch.
testrepository had a class (also called TestResultFilter) that tried to send all time calls through. To implement, it subclassed subunit's TestResultFilter and then reached into the _buffered_calls while in the stopTest method to try and find the time calls. Because of use of the decorator pattern, this was fragile.
The associated change in subunit gives that class the behavior that testrepository wants.
This change in subunit, plus the change in lp:~yellow/subunit/test-count, means that testrepository can use subunit's TestResultFilter directly, thereby getting rid of the fragility associated with the combination of subclassing, decorating, and accessing a protected attribute.
This is work done by Benji York and Brad Crittenden; I'm just helping out with the MP.
Unmerged revisions
- 149. By Gary Poster
-
remove functionality that has been moved into subunit
Thanks. I'm very much in favour of removing this subclass, and this patch looks like the right way to do it. I've taken issue with https:/ /code.launchpad .net/~yellow/ subunit/ test-count/ +merge/ 103717, and I suspect this patch will have to change as a result of required changes there.