Merge lp:~yavor-nikolov/pbzip2/fix-bug-740502-hang-with-ignore-trailing-garbage into lp:pbzip2/1.1

Proposed by Yavor Nikolov
Status: Merged
Merged at revision: 12
Proposed branch: lp:~yavor-nikolov/pbzip2/fix-bug-740502-hang-with-ignore-trailing-garbage
Merge into: lp:pbzip2/1.1
Diff against target: 30 lines (+5/-0)
2 files modified
ChangeLog (+2/-0)
pbzip2.cpp (+3/-0)
To merge this branch: bzr merge lp:~yavor-nikolov/pbzip2/fix-bug-740502-hang-with-ignore-trailing-garbage
Reviewer Review Type Date Requested Status
Yavor Nikolov Approve
Review via email: mp+55001@code.launchpad.net

Description of the change

Fixed hang on decompress with --ignore-trailing-garbage=1 and higher numCPU (e.g. > 2) (bug #740502)

To post a comment you must log in.
Revision history for this message
Yavor Nikolov (yavor-nikolov) wrote :

Patch has also been confirmed as helpful on http://bugs.gentoo.org/show_bug.cgi?id=320313

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ChangeLog'
2--- ChangeLog 2011-02-19 10:38:24 +0000
3+++ ChangeLog 2011-03-27 13:47:27 +0000
4@@ -1,4 +1,6 @@
5 Changes in 1.1.3 (NOT RELEASED YET)
6+- Fixed hang on decompress with --ignore-trailing-garbage=1 and higher
7+ numCPU (e.g. > 2) (bug #740502)
8 Changes in 1.1.2 (Feb 19, 2011)
9 - Fix directdecompress segfault when destination file can't be
10 opened (e.g. read-only) (bug #717852)
11
12=== modified file 'pbzip2.cpp'
13--- pbzip2.cpp 2011-02-19 10:38:24 +0000
14+++ pbzip2.cpp 2011-03-27 13:47:27 +0000
15@@ -187,6 +187,8 @@
16 * - Fixed hang on decompress of some truncated archives (bug #590225).
17 * - Implemented --ignore-trailing-garbage feature (bug #594868)
18 * - Fixed hang on decompress of some truncated archives (bug #590225)
19+ * - Fixed hang on decompress with --ignore-trailing-garbage=1 and higher
20+ * numCPU (e.g. > 2) (bug #740502)
21 *
22 *
23 * Specials thanks for suggestions and testing: Phillippe Welsh,
24@@ -1387,6 +1389,7 @@
25 {
26 if (consumerDecompressCheckInterrupt(fileData) != 0)
27 {
28+ safe_mutex_unlock(fifo->mut);
29 return (NULL);
30 }
31

Subscribers

People subscribed via source and target branches