Merge lp:~yann-papouin/ocb-addons/6.1-bug-1275659-crm-my-items-filters into lp:ocb-addons/6.1

Proposed by Yann Papouin
Status: Needs review
Proposed branch: lp:~yann-papouin/ocb-addons/6.1-bug-1275659-crm-my-items-filters
Merge into: lp:ocb-addons/6.1
Diff against target: 39 lines (+4/-0)
2 files modified
crm/crm_lead_view.xml (+2/-0)
crm/crm_phonecall_view.xml (+2/-0)
To merge this branch: bzr merge lp:~yann-papouin/ocb-addons/6.1-bug-1275659-crm-my-items-filters
Reviewer Review Type Date Requested Status
Ana Juaristi Olalde (community) Approve
Stefan Rijnhart (Opener) Disapprove
Holger Brunn (Therp) Approve
Pedro Manuel Baeza Abstain
Review via email:
To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Yann, are those filters really so needed?

review: Needs Information
Revision history for this message
Yann Papouin (yann-papouin) wrote :

It was made to mimic the 7.0/trunk behaviour where these filters are available by default.
I know that's not a major change, that's why I set the bug importance to "Wishlist".

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Well, for me, it's not problem to include it on OCB instead of an extra module, but let's see what others say.


review: Abstain
Revision history for this message
Serpent Consulting Services (serpent-consulting-services) wrote :

IMHO, this is a facility, but an end user can add as many as he wants!
In this case, 'My' filters are applicable to almost every business model.

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

given it's in 7.0, I don't think this needs its own module

review: Approve
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Not against this change per se, but I'm thinking that users are going to be annoyed if these untranslated buttons show up. So in this particular case I think having the improvement in a separate module in which the translations can be maintained easily should be preferred.

review: Disapprove
Revision history for this message
Ana Juaristi Olalde (ajuaristio) wrote :

I think any facility to avoid user configuring additional things is good idea.
I agree that user can create his own filter without needing a module to install, but this way he/she doesn't need to do it.

I approve since I don't see any risk.

review: Approve

Unmerged revisions

6831. By Yann Papouin

Add new filters "My Leads", "My Opportunities", "My Phonecalls"

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'crm/crm_lead_view.xml'
2--- crm/crm_lead_view.xml 2013-09-09 09:32:18 +0000
3+++ crm/crm_lead_view.xml 2014-02-03 14:09:39 +0000
4@@ -383,6 +383,7 @@
5 <field name="name" string="Lead / Customer"
6 filter_domain="['|','|',('partner_name','ilike',self),('email_from','ilike',self),('name','ilike',self)]"/>
7 <field name="user_id">
8+ <filter domain="[('user_id','=',uid)]" help="My Leads" icon="terp-personal"/>
9 <filter icon="terp-personal-"
10 domain="[('user_id','=', False)]"
11 help="Unassigned Leads" />
12@@ -655,6 +656,7 @@
13 <field name="name" string="Opportunity / Customer"
14 filter_domain="['|','|','|',('partner_id','ilike',self),('partner_name','ilike',self),('email_from','ilike',self),('name', 'ilike', self)]"/>
15 <field name="user_id">
16+ <filter domain="[('user_id','=',uid)]" help="My Opportunities" icon="terp-personal"/>
17 <filter icon="terp-personal-"
18 domain="[('user_id','=', False)]"
19 help="Unassigned Opportunities" />
21=== modified file 'crm/crm_phonecall_view.xml'
22--- crm/crm_phonecall_view.xml 2013-09-09 09:32:18 +0000
23+++ crm/crm_phonecall_view.xml 2014-02-03 14:09:39 +0000
24@@ -209,6 +209,7 @@
25 <field name="name"/>
26 <field name="partner_id"/>
27 <field name="user_id">
28+ <filter domain="[('user_id','=',uid)]" help="My Phonecalls" icon="terp-personal"/>
29 <filter icon="terp-personal-"
30 domain="[('user_id','=',False)]"
31 help="Unassigned Phonecalls" />
32@@ -259,6 +260,7 @@
33 <field name="name"/>
34 <field name="partner_id"/>
35 <field name="user_id">
36+ <filter domain="[('user_id','=',uid)]" help="My Phonecalls" icon="terp-personal"/>
37 <filter icon="terp-personal-"
38 domain="[('user_id','=',False)]"
39 help="Unassigned Phonecalls" />


People subscribed via source and target branches