Merge lp:~yann-papouin/ocb-addons/6.1-bug-1275659-crm-my-items-filters into lp:ocb-addons/6.1

[Yann Papouin]

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Yann, are those filters really so needed?

review: Needs Information

[Yann Papouin (yann-papouin)]

It was made to mimic the 7.0/trunk behaviour where these filters are available by default.
I know that's not a major change, that's why I set the bug importance to "Wishlist".

[Pedro Manuel Baeza (pedro.baeza)]

Well, for me, it's not problem to include it on OCB instead of an extra module, but let's see what others say.

Regards.

review: Abstain

[Serpent Consulting Services (serpent-consulting-services)]

IMHO, this is a facility, but an end user can add as many as he wants!
In this case, 'My' filters are applicable to almost every business model.

[Holger Brunn (Therp) (hbrunn)]

given it's in 7.0, I don't think this needs its own module

review: Approve

[Stefan Rijnhart (Opener) (stefan-opener)]

Not against this change per se, but I'm thinking that users are going to be annoyed if these untranslated buttons show up. So in this particular case I think having the improvement in a separate module in which the translations can be maintained easily should be preferred.

review: Disapprove

[Ana Juaristi Olalde (ajuaristio)]

I think any facility to avoid user configuring additional things is good idea.
I agree that user can create his own filter without needing a module to install, but this way he/she doesn't need to do it.

I approve since I don't see any risk.

review: Approve

Unmerged revisions

6831. By Yann Papouin on 2014-02-03

Add new filters "My Leads", "My Opportunities", "My Phonecalls"

=== modified file 'crm/crm_lead_view.xml'
--- crm/crm_lead_view.xml	2013-09-09 09:32:18 +0000
+++ crm/crm_lead_view.xml	2014-02-03 14:09:39 +0000
@@ -383,6 +383,7 @@
                 <field name="name" string="Lead / Customer"
                     filter_domain="['|','|',('partner_name','ilike',self),('email_from','ilike',self),('name','ilike',self)]"/>
                 <field name="user_id">
+                    <filter domain="[('user_id','=',uid)]" help="My Leads" icon="terp-personal"/>
                     <filter icon="terp-personal-"
                         domain="[('user_id','=', False)]"
                         help="Unassigned Leads" />
@@ -655,6 +656,7 @@
                 <field name="name" string="Opportunity / Customer"
                     filter_domain="['|','|','|',('partner_id','ilike',self),('partner_name','ilike',self),('email_from','ilike',self),('name', 'ilike', self)]"/>
                 <field name="user_id">
+                    <filter domain="[('user_id','=',uid)]" help="My Opportunities" icon="terp-personal"/>
                     <filter icon="terp-personal-"
                         domain="[('user_id','=', False)]"
                         help="Unassigned Opportunities" />

=== modified file 'crm/crm_phonecall_view.xml'
--- crm/crm_phonecall_view.xml	2013-09-09 09:32:18 +0000
+++ crm/crm_phonecall_view.xml	2014-02-03 14:09:39 +0000
@@ -209,6 +209,7 @@
                <field name="name"/>
                <field name="partner_id"/>
                <field name="user_id">
+                   <filter domain="[('user_id','=',uid)]" help="My Phonecalls" icon="terp-personal"/>
                    <filter icon="terp-personal-"
                        domain="[('user_id','=',False)]"
                        help="Unassigned Phonecalls" />
@@ -259,6 +260,7 @@
                <field name="name"/>
                <field name="partner_id"/>
                <field name="user_id">
+                   <filter domain="[('user_id','=',uid)]" help="My Phonecalls" icon="terp-personal"/>
                    <filter icon="terp-personal-"
                        domain="[('user_id','=',False)]"
                        help="Unassigned Phonecalls" />