Code review comment for lp:~yann-papouin/ocb-addons/6.1-bug-1267845-product-and-category-search-improved-usability

Revision history for this message
Yann Papouin (yann-papouin) wrote :

New commit with your regex in place.

To mimic the already existing behaviour, I've added an extended search based on name.

Note that contrary to the original code, I'm not using a python set because it is not ordered, I'm just using postgresql to filter the second query by removing previously found IDs. A sorted operation is done at the end, after the name_get.

Since this part of the code is really close to the existing code, maybe a mix between these two parts could be considered.

« Back to merge proposal