Code review comment for lp:~yann-papouin/ocb-addons/6.1-bug-1267845-product-and-category-search-improved-usability

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

which gives the same result as the original regex

>>> re.compile('(\[(.*?)\])').search('[Code[A][B][C]] Product name').group(2)

and the code path you added would search for 'Code[A][B][C' which doesn't seem that much better to me.

Don't you think that's a quite theoretical case?

« Back to merge proposal