Merge lp:~yann-papouin/account-financial-tools/6.1-bug-1255543-chart-update-records-wrong-dict into lp:~account-core-editors/account-financial-tools/6.1

Proposed by Yann Papouin on 2013-11-27
Status: Merged
Merged at revision: 106
Proposed branch: lp:~yann-papouin/account-financial-tools/6.1-bug-1255543-chart-update-records-wrong-dict
Merge into: lp:~account-core-editors/account-financial-tools/6.1
Diff against target: 11 lines (+1/-1)
1 file modified
account_chart_update/ (+1/-1)
To merge this branch: bzr merge lp:~yann-papouin/account-financial-tools/6.1-bug-1255543-chart-update-records-wrong-dict
Reviewer Review Type Date Requested Status
Joaquin Gutierrez (community) code review and test Approve on 2013-12-04
Pedro Manuel Baeza code review, no test 2013-11-27 Approve on 2013-11-27
Review via email:
To post a comment you must log in.
Pedro Manuel Baeza (pedro.baeza) wrote :

Thanks for catching up!


review: Approve (code review, no test)

Hello Yann:

Good job.


review: Approve (code review and test)
Pedro Manuel Baeza (pedro.baeza) wrote :

I proceed with the merge, having two functional reviews and this fix is needed for some tasks now on l10n_fr, as I have readed.


Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_chart_update/'
2--- account_chart_update/ 2012-12-07 09:52:37 +0000
3+++ account_chart_update/ 2013-11-27 14:37:40 +0000
4@@ -1193,7 +1193,7 @@
5 taxes_res = self._update_taxes(
6 cr, uid, wizard, log, tax_codes_res['mapping'], context=context)
7 accounts_res = self._update_accounts(
8- cr, uid, wizard, log, taxes_res['pending'], context=context)
9+ cr, uid, wizard, log, taxes_res['mapping'], context=context)
10 self._update_taxes_pending_for_accounts(cr, uid, wizard, log, taxes_res['pending'], accounts_res['mapping'], context=context)
11 fps_res = self._update_fiscal_positions(cr, uid, wizard, log, taxes_res['mapping'], accounts_res['mapping'], context=context)


People subscribed via source and target branches