Merge lp:~ya-bo-ng/ubuntu-online-tour/fixes-1471544 into lp:ubuntu-online-tour/14.04

Proposed by Anthony Dillon
Status: Merged
Merged at revision: 174
Proposed branch: lp:~ya-bo-ng/ubuntu-online-tour/fixes-1471544
Merge into: lp:ubuntu-online-tour/14.04
Diff against target: 81 lines (+9/-9)
2 files modified
en/index.html (+4/-4)
zh-CN/index.html (+5/-5)
To merge this branch: bzr merge lp:~ya-bo-ng/ubuntu-online-tour/fixes-1471544
Reviewer Review Type Date Requested Status
Graham Bancroft (community) Approve
Review via email: mp+265813@code.launchpad.net

Description of the change

# Details
- Bug: https://bugs.launchpad.net/ubuntu-online-tour/+bug/1471544
- Card: https://canonical.leankit.com/Boards/View/111185042/115908513

## Done
- Updated the language switcher links
- Updated the "back to site" link on both en and zh-CN

### QA
- You could check all updated links work in the code
- If you want to visual QA pull down the project and open index.html in /en/ and /zh-CN/
- Check there are no 404 resources on the pages

To post a comment you must log in.
Revision history for this message
Graham Bancroft (gbancroft-canonical) wrote :

Lgtm +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'en/index.html'
2--- en/index.html 2014-05-22 09:44:31 +0000
3+++ en/index.html 2015-07-24 11:09:24 +0000
4@@ -50,7 +50,7 @@
5 This demo uses JavaScript. Either your browser doesn't support JavaScript, or it's currently switched off.
6 <br/>
7 <br/>
8- Don't panic. We've got <a href="/ubuntu/take-the-tour-gallery">a non-JavaScript version</a> of the online tour you can view instead. :)
9+ Don't panic. We've got <a href="http://www.ubuntu.com/desktop/take-the-tour-gallery">a non-JavaScript version</a> of the online tour you can view instead. :)
10 </p>
11 </noscript>
12 </div>
13@@ -895,7 +895,7 @@
14 <div class="firefox-internet">
15 <div class="web-overlay-tran"></div>
16 <div class="theIframe">
17- <iframe src="../http://www.ubuntu.com" id="firefoxInternet" >
18+ <iframe src="http://start.ubuntu.com" id="firefoxInternet" >
19 <p>
20 Your browser does not support iframes.
21 </p>
22@@ -1003,7 +1003,7 @@
23 </ul>
24 <div class="language-mode">
25 <span class="active">English</span>
26- <a href="/tour/zh-CN/">中文</a>
27+ <a href="/zh-CN/">中文</a>
28 </div>
29 <a class="explore-mode primary" href="#">Show yourself around</a>
30 <a class="tour-mode" href="#">Take the guided tour</a>
31@@ -1016,7 +1016,7 @@
32 <div class="guide-logo"><img src="../img/tourguide/back-to-welcome.png" /></div>
33 <h3>Ubuntu online tour</h3>
34 <p>
35- We hope you've enjoyed the Ubuntu online tour. <a href="http://www.ubuntu.com/download/ubuntu/download?utm_source=tour&utm_medium=online&utm_campaign=tour" target="_blank">Ready to download?</a> or <a href="/ubuntu/take-the-tour" >back to the site</a>
36+ We hope you've enjoyed the Ubuntu online tour. <a href="http://www.ubuntu.com/download/ubuntu/download?utm_source=tour&utm_medium=online&utm_campaign=tour" target="_blank">Ready to download?</a> or <a href="http://www.ubuntu.com/desktop/take-the-tour" >back to the site</a>
37 </p>
38 </div>
39 <div class="guide-container home">
40
41=== modified file 'zh-CN/index.html'
42--- zh-CN/index.html 2014-04-30 23:17:33 +0000
43+++ zh-CN/index.html 2015-07-24 11:09:24 +0000
44@@ -50,7 +50,7 @@
45 This demo uses JavaScript. Either your browser doesn't support JavaScript, or it's currently switched off.
46 <br/>
47 <br/>
48- Don't panic. We've got <a href="/ubuntu/take-the-tour-gallery">a non-JavaScript version</a> of the online tour you can view instead. :)
49+ Don't panic. We've got <a href="http://www.ubuntu.com/desktop/take-the-tour-gallery">a non-JavaScript version</a> of the online tour you can view instead. :)
50 </p>
51 </noscript>
52 </div>
53@@ -884,7 +884,7 @@
54 <div class="firefox-internet">
55 <div class="web-overlay-tran"></div>
56 <div class="theIframe">
57- <iframe src="../http://www.ubuntu.com" id="firefoxInternet" >
58+ <iframe src="http://start.ubuntu.com" id="firefoxInternet" >
59 <p>
60 您的浏览器不支持 iframes
61 </p>
62@@ -991,8 +991,8 @@
63 </li>
64 </ul>
65 <div class="language-mode">
66- <span class="active">英文</span>
67- <a href="/tour/zh-CN/">中文</a>
68+ <a class="active" href="/en/">English</a>
69+ <span class="active">中文</span>
70 </div>
71 <a class="explore-mode primary" href="#">四处看看</a>
72 <a class="tour-mode" href="#">观看此向导</a>
73@@ -1005,7 +1005,7 @@
74 <div class="guide-logo"><img src="../img/tourguide/back-to-welcome.png" /></div>
75 <h3>Ubuntu 在线体验</h3>
76 <p>
77- 希望您喜欢 Ubuntu 在线漫游 <a href="http://www.ubuntu.com/download/ubuntu/download?utm_source=tour&utm_medium=online&utm_campaign=tour" target="_blank">准备好下载了吗?</a> 或 <a href="/ubuntu/take-the-tour" >返回网站</a>
78+ 希望您喜欢 Ubuntu 在线漫游 <a href="http://www.ubuntu.com/download/ubuntu/download?utm_source=tour&utm_medium=online&utm_campaign=tour" target="_blank">准备好下载了吗?</a> 或 <a href="http://www.ubuntu.com/desktop/take-the-tour" >返回网站</a>
79 </p>
80 </div>
81 <div class="guide-container home">

Subscribers

People subscribed via source and target branches