Merge lp:~ya-bo-ng/resource-centre/add-webinar-mailing-list into lp:resource-centre

Proposed by Anthony Dillon
Status: Merged
Merged at revision: 103
Proposed branch: lp:~ya-bo-ng/resource-centre/add-webinar-mailing-list
Merge into: lp:resource-centre
Diff against target: 23 lines (+5/-1)
1 file modified
includes/_digest.php (+5/-1)
To merge this branch: bzr merge lp:~ya-bo-ng/resource-centre/add-webinar-mailing-list
Reviewer Review Type Date Requested Status
David Callé (community) Approve
Canonical Website Editors Pending
Review via email: mp+332364@code.launchpad.net

Description of the change

## Done
Added a checkbox for webinars when subscribing to the mailing list.

## QA
Run the code and open the homepage. There should be a checkbox for webinars on the right-hand side. Click on a category and see that only that cat and webinar is auto selected.

## Demo
http://insights.canonicalwebteam.com/

To post a comment you must log in.
Revision history for this message
David Callé (davidc3) wrote :

lgtm!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'includes/_digest.php'
2--- includes/_digest.php 2017-04-06 07:29:37 +0000
3+++ includes/_digest.php 2017-10-17 15:17:06 +0000
4@@ -27,6 +27,10 @@
5 <input class="mktoLogicalField mktoCheckboxList mktoHasWidth" type="checkbox" id="insightsiot" name="insightsiot" value="yes"<?php if(in_array('internet-of-things', $termsString) or $current_tax == 'internet-of-things' or is_home() or is_page_template( 'page-press.php' )) echo ' checked="checked" ' ?>/>
6 <label for="insightsiot">Internet of Things</label>
7 </li>
8+ <li>
9+ <input class="mktoLogicalField mktoCheckboxList mktoHasWidth" type="checkbox" id="insightswebinar" name="insightswebinar" value="yes" checked="checked" />
10+ <label for="insightswebinar">Webinars</label>
11+ </li>
12 </ul>
13 </li>
14 <li class="mktFormReq mktField">
15@@ -38,7 +42,7 @@
16 </li>
17 <li class="mktField">
18 <span class='mktoButtonWrap'><button type='submit' class='mktoButton'>Subscribe now</button></span>
19-
20+
21 <input value="1959" class="mktoField mktoFieldDescriptor" name="lpId" type="hidden">
22 <input value="30" class="mktoField mktoFieldDescriptor" name="subId" type="hidden">
23 <input type="hidden" name="lpurl" value="https://pages.canonical.com/Insights-Subscription_Insights-Subscription-test.html?cr={creative}&amp;kw={keyword}" />

Subscribers

People subscribed via source and target branches