Merge ~ya-bo-ng/maas:unwrap-code-blocks into ~deadlight/maas:vanilla

Proposed by Anthony Dillon
Status: Merged
Approved by: Karl Williams
Approved revision: 94f401ad09250c095c2e1125cfe477e83b78c0ba
Merged at revision: db47a470fbfb2025586e074aa20d0d14456a8d47
Proposed branch: ~ya-bo-ng/maas:unwrap-code-blocks
Merge into: ~deadlight/maas:vanilla
Diff against target: 26 lines (+2/-2)
2 files modified
src/maasserver/static/js/angular/directives/code_lines.js (+1/-1)
src/maasserver/static/partials/node-result.html (+1/-1)
Reviewer Review Type Date Requested Status
LukeWH (community) Approve
Review via email: mp+337569@code.launchpad.net

Description of the change

## Done
Removed the new lines after code which was causing breaking spaces

To post a comment you must log in.
Revision history for this message
LukeWH (0-luke) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/static/js/angular/directives/code_lines.js b/src/maasserver/static/js/angular/directives/code_lines.js
2index 9dd8c6c..160d99a 100644
3--- a/src/maasserver/static/js/angular/directives/code_lines.js
4+++ b/src/maasserver/static/js/angular/directives/code_lines.js
5@@ -33,7 +33,7 @@
6 // its appropriate line number
7 $.each(lines, function() {
8 insert += '<span class="code-line">' +
9- this + '</span>\n';
10+ this + '</span>';
11 });
12 insert += "</code>";
13
14diff --git a/src/maasserver/static/partials/node-result.html b/src/maasserver/static/partials/node-result.html
15index f4d9428..a3648f2 100644
16--- a/src/maasserver/static/partials/node-result.html
17+++ b/src/maasserver/static/partials/node-result.html
18@@ -5,7 +5,7 @@
19 </div>
20 </header>
21 </div>
22-<div class="ng-hide" data-ng-show="loaded">
23+<div class="ng-hide u-no-margin--top" data-ng-show="loaded">
24 <header class="p-strip--light is-shallow is-bordered page-header" media-query="min-width: 769px">
25 <div class="row">
26 <div class="col-8">

Subscribers

People subscribed via source and target branches

to all changes: