Merge ~ya-bo-ng/maas:user-edit into ~deadlight/maas:vanilla

Proposed by Anthony Dillon
Status: Merged
Approved by: Karl Williams
Approved revision: 7deb10dc73d24379275666d29a5c9ddca0a5f5d8
Merged at revision: af3a9582d0002c784b492738e1e429e5c87eb026
Proposed branch: ~ya-bo-ng/maas:user-edit
Merge into: ~deadlight/maas:vanilla
Diff against target: 112 lines (+49/-39)
2 files modified
src/maasserver/templates/maasserver/user_confirm_delete.html (+15/-13)
src/maasserver/templates/maasserver/user_edit.html (+34/-26)
Reviewer Review Type Date Requested Status
Karl Williams Approve
Review via email: mp+337154@code.launchpad.net

Description of the change

Update the edit_user template.

## QA
Go to settings and edit a user
The edit user page should look good

To post a comment you must log in.
Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

Also added user delete page.

Revision history for this message
Karl Williams (deadlight) wrote :

LGTM +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/templates/maasserver/user_confirm_delete.html b/src/maasserver/templates/maasserver/user_confirm_delete.html
2index 6946b48..4c94df7 100644
3--- a/src/maasserver/templates/maasserver/user_confirm_delete.html
4+++ b/src/maasserver/templates/maasserver/user_confirm_delete.html
5@@ -5,19 +5,21 @@
6 {% block page-title %}Delete user: {{ user_to_delete.user.username }}{% endblock %}
7
8 {% block content %}
9-<div class="eight-col">
10- <h2>Are you sure you want to delete the user "{{ user_to_delete.user.username }}"?</h2>
11-</div>
12-<div class="eight-col">
13- <p>This action is permanent and can not be undone.</p>
14-</div>
15-<div class="eight-col">
16- <form method="post">{% csrf_token %}
17- <input type="hidden" name="post" value="yes" />
18- <div class="u-float--right">
19- <a class="button--secondary button--inline" href="{% url 'settings' %}">Cancel</a>
20- <button type="submit" class="button--destructive button--inline">Delete user</button>
21+<div class="p-strip">
22+ <div class="row">
23+ <div class="col-8">
24+ <h2>Are you sure you want to delete the user "{{ user_to_delete.user.username }}"?</h2>
25+ <p>This action is permanent and can not be undone.</p>
26+ </div>
27+ </div>
28+ <div class="row">
29+ <div class="col-8 u-align--right">
30+ <form method="post">{% csrf_token %}
31+ <input type="hidden" name="post" value="yes" />
32+ <a class="p-button--neutral" href="{% url 'settings' %}">Cancel</a>
33+ <button type="submit" class="p-button--negative">Delete user</button>
34+ </form>
35 </div>
36- </form>
37+ </div>
38 </div>
39 {% endblock %}
40diff --git a/src/maasserver/templates/maasserver/user_edit.html b/src/maasserver/templates/maasserver/user_edit.html
41index 2fcf716..b9a2958 100644
42--- a/src/maasserver/templates/maasserver/user_edit.html
43+++ b/src/maasserver/templates/maasserver/user_edit.html
44@@ -5,34 +5,42 @@
45 {% block page-title %}Edit User{% endblock %}
46
47 {% block content %}
48-<div class="eight-col">
49- <h2>Settings</h2>
50- <div id="profile" class="eight-col u-border--bottom">
51- <form method="post" class="eight-col">
52- {% csrf_token %}
53- <ul>
54- {% for field in profile_form %} {% include "maasserver/form_field.html" %} {% endfor %}
55- </ul>
56- <input type="hidden" name="profile_submit" value="1" />
57- <div class="u-float--right">
58- <a href="{% url 'settings' %}" class="button--base button--inline">Cancel</a>
59- <button type="submit" class="button--positive button--inline">Save user</button>
60+<div class="p-strip is-bordered">
61+ <form method="post">
62+ <div class="row">
63+ <div class="col-8">
64+ <h2>Settings</h2>
65+ {% csrf_token %}
66+ <ul class="p-list">
67+ {% for field in profile_form %} {% include "maasserver/form_field.html" %} {% endfor %}
68+ </ul>
69+ <input type="hidden" name="profile_submit" value="1" />
70 </div>
71- </form>
72- </div>
73- <h2>Change password</h2>
74- <div id="password" class="eight-col">
75- <form method="post">
76- {% csrf_token %}
77- <ul>
78- {% for field in password_form %} {% include "maasserver/form_field.html" %} {% endfor %}
79- </ul>
80- <input type="hidden" name="password_submit" value="1" />
81- <div class="u-float--right">
82- <a href="{% url 'settings' %}"class="button--base button--inline">Cancel</a>
83- <button type="submit" class="button--positive button--inline">Save password</button>
84+ </div>
85+ <div class="row">
86+ <div class="col-8 u-align--right">
87+ <a href="{% url 'settings' %}" class="p-button--base">Cancel</a>
88+ <button type="submit" class="p-button--positive">Save user</button>
89 </div>
90- </form>
91+ </div>
92+ </form>
93+</div>
94+<div class="p-strip">
95+ <div class="row">
96+ <div class="col-8" id="password">
97+ <h2>Change password</h2>
98+ <form method="post">
99+ {% csrf_token %}
100+ <ul class="p-list">
101+ {% for field in password_form %} {% include "maasserver/form_field.html" %} {% endfor %}
102+ </ul>
103+ <input type="hidden" name="password_submit" value="1" />
104+ <div class="u-float--right">
105+ <a href="{% url 'settings' %}"class="p-button--base">Cancel</a>
106+ <button type="submit" class="p-button--positive">Save password</button>
107+ </div>
108+ </form>
109+ </div>
110 </div>
111 </div>
112 {% endblock %}

Subscribers

People subscribed via source and target branches

to all changes: