Merge lp:~ya-bo-ng/juju-gui/onboarding-continued into lp:juju-gui/experimental

Proposed by Anthony Dillon
Status: Merged
Merged at revision: 1156
Proposed branch: lp:~ya-bo-ng/juju-gui/onboarding-continued
Merge into: lp:juju-gui/experimental
Diff against target: 188 lines (+20/-26)
5 files modified
app/subapps/browser/browser.js (+1/-1)
app/templates/onboarding.handlebars (+7/-8)
lib/views/browser/onboarding.less (+9/-5)
test/test_browser_app.js (+3/-10)
test/test_onboarding.js (+0/-2)
To merge this branch: bzr merge lp:~ya-bo-ng/juju-gui/onboarding-continued
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+192247@code.launchpad.net

Description of the change

Update to onboarding

Added a mask of the header at all time with the logo attached. Inishal onboarding is now fully masked.

To post a comment you must log in.
1149. By Anthony Dillon

Removed onboarding flag

1150. By Anthony Dillon

Remove flag onboarding from browser-app testing

1151. By Anthony Dillon

Update inspector image

1152. By Anthony Dillon

Update to the copy

1153. By Anthony Dillon

Resolve conflict

1154. By Anthony Dillon

Pushing up resolved file

1155. By Anthony Dillon

Linted

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/assets/images/non-sprites/onboarding/3-inspector.png'
2Binary files app/assets/images/non-sprites/onboarding/3-inspector.png 2013-10-10 11:44:44 +0000 and app/assets/images/non-sprites/onboarding/3-inspector.png 2013-10-25 23:04:49 +0000 differ
3=== modified file 'app/subapps/browser/browser.js'
4--- app/subapps/browser/browser.js 2013-10-21 23:05:08 +0000
5+++ app/subapps/browser/browser.js 2013-10-25 23:04:49 +0000
6@@ -855,7 +855,7 @@
7 // Only show the onboarding messaging if we're hitting the sidebar view
8 // without any extra url bits to the user. It's meant for a fresh user
9 // to see, not someone doing what they know they want to do.
10- if (!this._onboarding && window.flags.onboard) {
11+ if (!this._onboarding) {
12 if (!this._viewState.search &&
13 !this._viewState.charmID) {
14 this.renderOnboarding();
15
16=== modified file 'app/templates/onboarding.handlebars'
17--- app/templates/onboarding.handlebars 2013-10-22 21:16:30 +0000
18+++ app/templates/onboarding.handlebars 2013-10-25 23:04:49 +0000
19@@ -8,27 +8,26 @@
20 <a class="onboarding-cross sprite close-inspector-normal" href="" ></a>
21 <div class="panel panel-0">
22 <h3 class="header type3">Welcome to Juju</h3>
23- <p class="text type11">Juju enables you to configure, manage, maintain, deploy and scale efficiently with best-practice Charms on any cloud or your own Ubuntu laptop.</p>
24+ <p class="text type11">Use Juju to quickly create, configure and deploy your application architectures to public clouds like EC2, Azure and HP, any OpenStack cloud and even your own Ubuntu based laptop with Charms.</p>
25 </div>
26 <div class="panel panel-1">
27 <h3 class="header type3">Build your environment</h3>
28- <p class="text type11">The Charm browser has hundreds of Charms allowing you to build complex services which can be visualised in Juju.</p>
29- <p class=" text type11">Drag them from the Charm browser onto your canvas to start building your environments.</p>
30+ <p class="text type11">Charms define applications as services. Write your own or use any of the hundreds of high-quality existing Charms. Just drag them from the Charm browser onto your canvas to start building your environments.</p>
31 </div>
32 <div class="panel panel-2">
33- <h3 class="header type3">Connect services</h3>
34- <p class="text type11">Configure and deploy your services and connect them with intelligent relationship lines to build your environment.</p>
35+ <h3 class="header type3">Connect your services</h3>
36+ <p class="text type11">Charms know about how services integrate with each other. After you configure and deploy your services, easily build intelligent relationships by dragging and dropping connections between the services you want.</p>
37 <img src="/juju-ui/assets/images/non-sprites/onboarding/2-service-blocks.png" class="service-blocks" />
38 </div>
39 <div class="panel panel-3">
40- <h3 class="header type3">Monitor and manage</h3>
41- <p class="text type11">The Juju GUI inspector offers comprehensive tools that give you ability to scale out, triage errors and update your services.</p>
42+ <h3 class="header type3">Monitor and manage your cloud</h3>
43+ <p class="text type11">The Juju inspector gives you the ability to scale out, triage errors and update your services simply and easily.</p>
44 <img src="/juju-ui/assets/images/non-sprites/onboarding/3-service-block.png" class="service-block" />
45 <img src="/juju-ui/assets/images/non-sprites/onboarding/3-inspector.png" class="inspector" />
46 </div>
47 <ul>
48 <li><a href="" class="onboarding-close">Get started</a></li>
49- <li><a href="" class="onboarding-start highlight">Quick tour of Juju</a></li>
50+ <li><a href="" class="onboarding-start highlight">Tour</a></li>
51 <li><a href="" class="onboarding-next highlight">Next</a></li>
52 <li><a href="" class="onboarding-prev">Prev</a></li>
53 </ul>
54
55=== modified file 'lib/views/browser/onboarding.less'
56--- lib/views/browser/onboarding.less 2013-10-22 21:16:30 +0000
57+++ lib/views/browser/onboarding.less 2013-10-25 23:04:49 +0000
58@@ -43,7 +43,7 @@
59 left: 350px;
60 width: 320px;
61 background-color: @inspector-background-color;
62- padding: 20px;
63+ padding: 20px 20px 0;
64
65 .onboarding-cross {
66 float: right;
67@@ -68,10 +68,13 @@
68 }
69
70 ul {
71+ background-color: rgba(34, 30, 28, 0.75);
72 position: relative;
73 list-style: none;
74- margin-left: 0;
75 height: 57px;
76+ margin-left: -20px;
77+ margin-right: -20px;
78+ padding: 20px;
79
80 li {
81 display: inline;
82@@ -85,7 +88,7 @@
83 display: inline-block;
84 height: 40px;
85 margin-top: 17px;
86- padding: 0 30px;
87+ padding: 0 29px;
88 color: #fff;
89 line-height: 40px;
90
91@@ -152,8 +155,9 @@
92 display: none;
93 }
94 .service-blocks {
95- top: 210px;
96- left: 125px;
97+ left: 90px;
98+ top: 87px;
99+ max-width: none;
100 }
101 }
102 }
103
104=== modified file 'test/test_browser_app.js'
105--- test/test_browser_app.js 2013-10-25 21:00:21 +0000
106+++ test/test_browser_app.js 2013-10-25 23:04:49 +0000
107@@ -723,7 +723,7 @@
108 sidebar: false,
109 renderCharmDetails: false,
110 renderEditorial: false,
111- renderOnboarding: false,
112+ renderOnboarding: true,
113 renderSearchResults: false
114 };
115 };
116@@ -1236,7 +1236,6 @@
117 });
118
119 it('onboarding is called in build mode', function() {
120- window.flags.onboard = true;
121 var req = {
122 path: '/sidebar/',
123 params: {
124@@ -1248,14 +1247,11 @@
125 renderEditorial: true,
126 renderOnboarding: true
127 });
128-
129 browser.routeView(req, undefined, function() {});
130 assert.deepEqual(hits, expected);
131- window.flags = {};
132 });
133
134 it('onboarding is not called with a charm id', function() {
135- window.flags.onboard = true;
136 var req = {
137 path: '/sidebar/',
138 params: {
139@@ -1267,16 +1263,14 @@
140 sidebar: true,
141 renderEditorial: true,
142 renderCharmDetails: true,
143- renderOnboarding: false
144+ renderOnboarding: true
145 });
146
147 browser.routeView(req, undefined, function() {});
148 assert.deepEqual(hits, expected);
149- window.flags = {};
150 });
151
152 it('onboarding is not called with a search', function() {
153- window.flags.onboard = true;
154 var req = {
155 path: '/sidebar/search',
156 params: {
157@@ -1287,12 +1281,11 @@
158 var expected = Y.merge(hits, {
159 sidebar: true,
160 renderSearchResults: true,
161- renderOnboarding: false
162+ renderOnboarding: true
163 });
164
165 browser.routeView(req, undefined, function() {});
166 assert.deepEqual(hits, expected);
167- window.flags = {};
168 });
169
170 it('/minimized dispatches correctly', function() {
171
172=== modified file 'test/test_onboarding.js'
173--- test/test_onboarding.js 2013-10-21 23:05:08 +0000
174+++ test/test_onboarding.js 2013-10-25 23:04:49 +0000
175@@ -40,13 +40,11 @@
176 beforeEach(function() {
177 container = utils.makeContainer('onboarding');
178 env_help = utils.makeContainer('environment-help');
179- window.flags.onboard = true;
180 });
181
182 afterEach(function() {
183 container.remove(true);
184 env_help.remove(true);
185- window.flags = {};
186 });
187
188 after(function() {

Subscribers

People subscribed via source and target branches