lp:~ya-bo-ng/juju-gui/linkify-charm-descriptions
- Get this branch:
- bzr branch lp:~ya-bo-ng/juju-gui/linkify-charm-descriptions
Branch merges
- Juju GUI Hackers: Pending requested
-
Diff: 102 lines (+34/-7)3 files modifiedapp/subapps/browser/templates/browser_charm.handlebars (+3/-3)
app/subapps/browser/views/charm.js (+30/-4)
lib/views/browser/charm-full.less (+1/-0)
Branch information
Recent revisions
- 1166. By Richard Harding
-
Provide a 'deploy' button in quicksearch results.
- Add the control to the tokens for both charms and bundles
- Wire up a new event that the search widget can fire EVT_DEPLOY
- Make views that extend view.js (fullscree/sidebar) watch for that event and
build a proper deploy command.
- Make sure those views get access to the deploy and bundleDeploy helpers from
the browser.js
- Deploying does not actual perform a selection so no search or details takes
place. It's an alternate behavior for quicksearch.Several drive-by fixes for things. Documented in the reviewer comments.
QA:
The button is feature flagged due to the fact that this quick deploy doesn't
involve the charm cache and causes the inspector to 'hang' for a sec when you
hit the deploy button. It's not an ideal experience.http://
gui:8888/ :flags: /searchDeploy Search for apa and then click on the + next to apache2. It should deploy to
the canvas. No text is in the quicksearch box, no charm highlighted, etc.You can also QA this with a bundle.
http://
gui:8888/ :flags: /searchDeploy/ charmworldv3/ Now enter "TestB" and get the TestBundle result. Press the + to deploy the
bundle.R=gary.poster, jeff.pihach
CC=
https://codereview. appspot. com/18920045 - 1165. By Brad Crittenden
-
Show bundle change log.
Other changes:
* Change date format for charm and bundle change logs to be like 2013-10-31.
* Lots of drive-by typo fixes. Sorry for the noise but I cannot help myself.R=jeff.pihach, benji
CC=
https://codereview. appspot. com/19380044 - 1164. By Huw Wilkins
-
More sprite and CSS cleanups
Moved images that are only used via background-image out of the sprites folder.
Changed some images to be used as sprites.
Removed some unused images.
Added a new mixin to handle using sprites for hover.
Removed some CSS that is no longer being used.
Cleaned up a little CSS for the sake of file size.
Removed old slider images from the Makefile as they were no longer being used.
Drive-by fix for bug #1245907 where extra scrollbars where appearing in the ghost inspector. - 1163. By Huw Wilkins
-
Remove "charms" from section titles
With the addition of bundles the section headers no longer make sense. Under the feature flag that adds bundles I've removed "charms" from the titles in the browser.
R=jeff.pihach
CC=
https://codereview. appspot. com/18950044 - 1162. By Jeff Pihach
-
Adds confirmation to bundle deploy
When clicking the 'add to canvas' button in the bundle
details page it will now show a notification above the
button and require an additional click on the button
which now reads, 'Yes, I'm sure'.R=gary.poster
CC=
https://codereview. appspot. com/19570043 - 1161. By Jeff Pihach
-
Add Deploy tab to bundle details view
Also adds:
bundle location into bundle details view header
bzr branch command to Code tab
moved the Readme tab to the second tab spot as per UXR=bac
CC=
https://codereview. appspot. com/18630045 - 1160. By Huw Wilkins
-
Fix fullscreen bundles
The fullscreen bundles page was quite broken. Added the appropriate classes to make it work.
R=jeff.pihach
CC=
https://codereview. appspot. com/18980043 - 1159. By Huw Wilkins
-
Big CSS cleanup
Apologies for the size of this branch.
In this branch:
Moved mixins to own file.
Removed old @vars and those only used once (no need for them to remain a var).
Removed classes that are no longer being used.
Added comments to classes.
Changed remaining font sizes to use px (to be consistent with the web team).
Added some documentation on class ordering.
Redesigned login/connecting to juju/unsupported browser notice to fit with the current GUI style.R=jeff.pihach
CC=
https://codereview. appspot. com/18970043
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:juju-gui/experimental