Merge lp:~ya-bo-ng/canonical-identity-provider/feedback-styles into lp:canonical-identity-provider/release

Proposed by Anthony Dillon
Status: Rejected
Rejected by: Natalia Bidart
Proposed branch: lp:~ya-bo-ng/canonical-identity-provider/feedback-styles
Merge into: lp:canonical-identity-provider/release
Diff against target: 30 lines (+17/-2)
1 file modified
src/identityprovider/media/ubuntuone/css/ubuntuone.css (+17/-2)
To merge this branch: bzr merge lp:~ya-bo-ng/canonical-identity-provider/feedback-styles
Reviewer Review Type Date Requested Status
Jonas G. Drange (community) Approve
Review via email: mp+178973@code.launchpad.net

Description of the change

Adding simple styles to the warning and information feedback messages. These are inline with the web guidelines.

To post a comment you must log in.
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

LGTM

review: Approve
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Setting MP as Rejected to reduce numbers of landing candidates in @reviewlist. Change status again if this MP is still current.

Unmerged revisions

991. By Anthony Dillon

Added styles for warning and info messages

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/identityprovider/media/ubuntuone/css/ubuntuone.css'
2--- src/identityprovider/media/ubuntuone/css/ubuntuone.css 2013-06-25 09:09:13 +0000
3+++ src/identityprovider/media/ubuntuone/css/ubuntuone.css 2013-08-07 13:45:43 +0000
4@@ -107,9 +107,24 @@
5 text-decoration: underline;
6 }
7
8-.success,
9+.success {
10+ background: #38B44A;
11+ color: white;
12+}
13+.success a {
14+ color: white;
15+ text-decoration: underline;
16+}
17 .informational,
18-.info {}
19+.info {
20+ background: #ECA918;
21+ color: white;
22+}
23+.informational a,
24+.info a {
25+ color: white;
26+ text-decoration: underline;
27+}
28
29 /* Form box -------------------------------------------------------------------*/
30 .form-box {