Merge lp:~xtrusia/charms/trusty/nova-compute/lp1417891 into lp:~openstack-charmers-archive/charms/trusty/nova-compute/next

Proposed by Seyeong Kim on 2015-02-25
Status: Merged
Merged at revision: 112
Proposed branch: lp:~xtrusia/charms/trusty/nova-compute/lp1417891
Merge into: lp:~openstack-charmers-archive/charms/trusty/nova-compute/next
Diff against target: 22 lines (+3/-1)
2 files modified
Makefile (+1/-1)
templates/libvirt-bin (+2/-0)
To merge this branch: bzr merge lp:~xtrusia/charms/trusty/nova-compute/lp1417891
Reviewer Review Type Date Requested Status
OpenStack Charmers 2015-03-09 Pending
James Page 2015-02-25 Pending
Review via email: mp+250901@code.launchpad.net

This proposal supersedes a proposal from 2015-02-06.

To post a comment you must log in.
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #1779 nova-compute-next for xtrusia mp248854
    LINT FAIL: lint-test failed
    LINT FAIL: charm-proof failed

LINT Results (max last 2 lines):
  I: config.yaml: option disk-cachemodes has no default value
  make: *** [lint] Error 100

Full lint test output: http://paste.ubuntu.com/10085402/
Build: http://10.245.162.77:8080/job/charm_lint_check/1779/

uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #1607 nova-compute-next for xtrusia mp248854
    UNIT FAIL: unit-test failed

UNIT Results (max last 2 lines):
  FAILED (SKIP=5, failures=1)
  make: *** [unit_test] Error 1

Full unit test output: http://paste.ubuntu.com/10085404/
Build: http://10.245.162.77:8080/job/charm_unit_test/1607/

uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #1799 nova-compute-next for xtrusia mp248854
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
  ERROR subprocess encountered error code 1
  make: *** [test] Error 1

Full amulet test output: http://paste.ubuntu.com/10085471/
Build: http://10.245.162.77:8080/job/charm_amulet_test/1799/

uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #1780 nova-compute-next for xtrusia mp248854
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/1780/

uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #1608 nova-compute-next for xtrusia mp248854
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/1608/

uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #1800 nova-compute-next for xtrusia mp248854
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
  ERROR subprocess encountered error code 1
  make: *** [test] Error 1

Full amulet test output: http://paste.ubuntu.com/10085837/
Build: http://10.245.162.77:8080/job/charm_amulet_test/1800/

uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #1831 nova-compute-next for xtrusia mp248854
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/1831/

uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #1659 nova-compute-next for xtrusia mp248854
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/1659/

uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #1850 nova-compute-next for xtrusia mp248854
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
  ERROR subprocess encountered error code 124
  make: *** [test] Error 124

Full amulet test output: http://paste.ubuntu.com/10149913/
Build: http://10.245.162.77:8080/job/charm_amulet_test/1850/

uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #2278 nova-compute-next for xtrusia mp248854
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/2278/

uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #2067 nova-compute-next for xtrusia mp248854
    UNIT FAIL: unit-test failed

UNIT Results (max last 2 lines):
  FAILED (SKIP=5, failures=1)
  make: *** [unit_test] Error 1

Full unit test output: http://paste.ubuntu.com/10404000/
Build: http://10.245.162.77:8080/job/charm_unit_test/2067/

uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #2183 nova-compute-next for xtrusia mp248854
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
  ERROR subprocess encountered error code 1
  make: *** [test] Error 1

Full amulet test output: http://paste.ubuntu.com/10404140/
Build: http://10.245.162.77:8080/job/charm_amulet_test/2183/

James Page (james-page) wrote : Posted in a previous version of this proposal

Thanks for your proposal to resolve this problem.

I think that we should really fix this by setting the ulimit always for libvirt - so a configuration option is not really required.

We do this in other areas as well; I'd also like to see if we can get this into the Ubuntu packaging as well.

So please could you rework with the following changes:

1) Drop the configuration option

2) Set the ulimit via /etc/default/libvirt-bin

There's already a template for this - by doing it here, we ensure that this change is not lost when Ubuntu migrates to using systemd instead of upstream.

Thanks!

review: Needs Fixing

charm_lint_check #2282 nova-compute-next for xtrusia mp250901
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/2282/

charm_unit_test #2071 nova-compute-next for xtrusia mp250901
    UNIT FAIL: unit-test failed

UNIT Results (max last 2 lines):
  FAILED (SKIP=5, failures=1)
  make: *** [unit_test] Error 1

Full unit test output: http://paste.ubuntu.com/10406541/
Build: http://10.245.162.77:8080/job/charm_unit_test/2071/

106. By Seyeong Kim on 2015-02-25

remove bad unit_test

charm_amulet_test #2187 nova-compute-next for xtrusia mp250901
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
  ERROR subprocess encountered error code 124
  make: *** [test] Error 124

Full amulet test output: http://paste.ubuntu.com/10406789/
Build: http://10.245.162.77:8080/job/charm_amulet_test/2187/

charm_lint_check #2283 nova-compute-next for xtrusia mp250901
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/2283/

charm_unit_test #2072 nova-compute-next for xtrusia mp250901
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/2072/

charm_amulet_test #2188 nova-compute-next for xtrusia mp250901
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
  ERROR subprocess encountered error code 124
  make: *** [test] Error 124

Full amulet test output: http://paste.ubuntu.com/10407217/
Build: http://10.245.162.77:8080/job/charm_amulet_test/2188/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2014-09-30 20:31:36 +0000
3+++ Makefile 2015-02-25 11:39:46 +0000
4@@ -23,7 +23,7 @@
5 # coreycb note: The -v should only be temporary until Amulet sends
6 # raise_status() messages to stderr:
7 # https://bugs.launchpad.net/amulet/+bug/1320357
8- @juju test -v -p AMULET_HTTP_PROXY --timeout 900 \
9+ @juju test -v -p AMULET_HTTP_PROXY --timeout 3000 \
10 00-setup 14-basic-precise-icehouse 15-basic-trusty-icehouse
11
12 publish: lint unit_test
13
14=== modified file 'templates/libvirt-bin'
15--- templates/libvirt-bin 2013-08-01 23:21:58 +0000
16+++ templates/libvirt-bin 2015-02-25 11:39:46 +0000
17@@ -14,3 +14,5 @@
18
19 # pass in location of kerberos keytab
20 #export KRB5_KTNAME=/etc/libvirt/libvirt.keytab
21+
22+limit nofile 65535 65535

Subscribers

People subscribed via source and target branches